mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 00:03:45 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
93 lines
2.8 KiB
TypeScript
93 lines
2.8 KiB
TypeScript
import { EventEmitter } from 'node:events'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import type { ChildProcessWithoutNullStreams } from 'node:child_process'
|
|
|
|
const handlers = new Map<string, (_event: unknown, args: unknown) => Promise<unknown> | unknown>()
|
|
const { spawnMock, handleMock, resolveAuthorizedPathMock } = vi.hoisted(() => ({
|
|
spawnMock: vi.fn(),
|
|
handleMock: vi.fn((channel: string, handler: (event: unknown, args: unknown) => unknown) => {
|
|
handlers.set(channel, handler)
|
|
}),
|
|
resolveAuthorizedPathMock: vi.fn()
|
|
}))
|
|
|
|
vi.mock('child_process', () => ({
|
|
spawn: spawnMock
|
|
}))
|
|
|
|
vi.mock('electron', () => ({
|
|
ipcMain: {
|
|
handle: handleMock
|
|
}
|
|
}))
|
|
|
|
vi.mock('./filesystem-auth', () => ({
|
|
resolveAuthorizedPath: resolveAuthorizedPathMock
|
|
}))
|
|
|
|
import { registerNotebookHandlers } from './notebook'
|
|
|
|
function createMockProcess(pid = 1234): ChildProcessWithoutNullStreams {
|
|
const proc = new EventEmitter() as ChildProcessWithoutNullStreams
|
|
Object.assign(proc, {
|
|
pid,
|
|
stdout: new EventEmitter(),
|
|
stderr: new EventEmitter(),
|
|
kill: vi.fn(),
|
|
unref: vi.fn()
|
|
})
|
|
return proc
|
|
}
|
|
|
|
describe('notebook IPC', () => {
|
|
let processKillSpy: ReturnType<typeof vi.spyOn>
|
|
|
|
beforeEach(() => {
|
|
handlers.clear()
|
|
vi.useFakeTimers()
|
|
vi.clearAllMocks()
|
|
resolveAuthorizedPathMock.mockResolvedValue('/repo/notebook.ipynb')
|
|
processKillSpy = vi.spyOn(process, 'kill').mockImplementation(() => true)
|
|
})
|
|
|
|
afterEach(() => {
|
|
processKillSpy.mockRestore()
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('kills the Python process group when a cell times out', async () => {
|
|
const proc = createMockProcess(4321)
|
|
const killerProc = createMockProcess(4322)
|
|
spawnMock.mockReturnValueOnce(proc).mockReturnValue(killerProc)
|
|
registerNotebookHandlers({} as never)
|
|
|
|
const handler = handlers.get('notebook:runPythonCell')
|
|
expect(handler).toBeDefined()
|
|
const resultPromise = handler?.(null, {
|
|
filePath: '/repo/notebook.ipynb',
|
|
code: 'while True: pass'
|
|
}) as Promise<unknown>
|
|
|
|
await vi.advanceTimersByTimeAsync(60_000)
|
|
await expect(resultPromise).resolves.toMatchObject({
|
|
exitCode: null,
|
|
error: 'Python cell timed out.'
|
|
})
|
|
expect(proc.stdout.listenerCount('data')).toBe(0)
|
|
expect(proc.stderr.listenerCount('data')).toBe(0)
|
|
expect(proc.listenerCount('error')).toBe(0)
|
|
expect(proc.listenerCount('close')).toBe(0)
|
|
|
|
if (process.platform !== 'win32') {
|
|
expect(spawnMock).toHaveBeenCalledWith(
|
|
'python3',
|
|
expect.any(Array),
|
|
expect.objectContaining({ detached: true })
|
|
)
|
|
expect(processKillSpy).toHaveBeenCalledWith(-4321, 'SIGTERM')
|
|
await vi.advanceTimersByTimeAsync(2000)
|
|
expect(processKillSpy).toHaveBeenCalledWith(-4321, 'SIGKILL')
|
|
}
|
|
})
|
|
})
|