mirror of
https://github.com/stablyai/orca.git
synced 2026-10-01 08:01:56 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
130 lines
4.3 KiB
TypeScript
130 lines
4.3 KiB
TypeScript
import type { LinearIssueAttributeFilter } from '../../shared/linear/issue-attribute-filter'
|
|
import type { LinearIssueUpdate } from '../../shared/issue-mutation-types'
|
|
import type { LinearComment, LinearIssue } from '../../shared/linear/issue-types'
|
|
import type {
|
|
LinearCustomViewModel,
|
|
LinearCustomViewSummary,
|
|
LinearProjectDetail,
|
|
LinearProjectSummary
|
|
} from '../../shared/linear/project-types'
|
|
import type {
|
|
LinearCollectionResult,
|
|
LinearConnectionStatus,
|
|
LinearLabel,
|
|
LinearMember,
|
|
LinearTeam,
|
|
LinearViewer,
|
|
LinearWorkflowState,
|
|
LinearWorkspaceSelection
|
|
} from '../../shared/linear/workspace-types'
|
|
|
|
export type LinearApi = {
|
|
connect: (args: {
|
|
apiKey: string
|
|
}) => Promise<{ ok: true; viewer: LinearViewer } | { ok: false; error: string }>
|
|
disconnect: (args?: { workspaceId?: string }) => Promise<void>
|
|
selectWorkspace: (args: {
|
|
workspaceId: LinearWorkspaceSelection
|
|
}) => Promise<LinearConnectionStatus>
|
|
status: () => Promise<LinearConnectionStatus>
|
|
testConnection: (args?: {
|
|
workspaceId?: string
|
|
}) => Promise<{ ok: true; viewer: LinearViewer } | { ok: false; error: string }>
|
|
searchIssues: (args: {
|
|
query: string
|
|
limit?: number
|
|
workspaceId?: LinearWorkspaceSelection
|
|
}) => Promise<LinearIssue[]>
|
|
listIssues: (args?: {
|
|
filter?: 'assigned' | 'created' | 'all' | 'completed'
|
|
limit?: number
|
|
workspaceId?: LinearWorkspaceSelection
|
|
attributeFilter?: LinearIssueAttributeFilter
|
|
}) => Promise<LinearCollectionResult<LinearIssue>>
|
|
createIssue: (args: {
|
|
teamId: string
|
|
title: string
|
|
description?: string
|
|
workspaceId?: string
|
|
parentIssueId?: string
|
|
projectId?: string | null
|
|
stateId?: string
|
|
priority?: number
|
|
assigneeId?: string | null
|
|
labelIds?: string[]
|
|
}) => Promise<
|
|
| { ok: true; id: string; identifier: string; title: string; url: string }
|
|
| { ok: false; error: string }
|
|
>
|
|
getIssue: (args: { id: string; workspaceId?: string }) => Promise<LinearIssue | null>
|
|
updateIssue: (args: {
|
|
id: string
|
|
updates: LinearIssueUpdate
|
|
workspaceId?: string
|
|
}) => Promise<{ ok: true } | { ok: false; error: string }>
|
|
addIssueComment: (args: {
|
|
issueId: string
|
|
body: string
|
|
workspaceId?: string
|
|
}) => Promise<{ ok: true; id: string } | { ok: false; error: string }>
|
|
issueComments: (args: { issueId: string; workspaceId?: string }) => Promise<LinearComment[]>
|
|
listTeams: (args?: { workspaceId?: LinearWorkspaceSelection }) => Promise<LinearTeam[]>
|
|
listProjects: (args?: {
|
|
query?: string
|
|
limit?: number
|
|
workspaceId?: LinearWorkspaceSelection
|
|
force?: boolean
|
|
}) => Promise<LinearCollectionResult<LinearProjectSummary>>
|
|
createProject: (args: {
|
|
name: string
|
|
description?: string
|
|
content?: string
|
|
teamIds: string[]
|
|
workspaceId?: string
|
|
leadId?: string | null
|
|
memberIds?: string[]
|
|
labelIds?: string[]
|
|
priority?: number
|
|
startDate?: string
|
|
targetDate?: string
|
|
}) => Promise<{ ok: true; project: LinearProjectDetail } | { ok: false; error: string }>
|
|
getProject: (args: {
|
|
id: string
|
|
workspaceId: string
|
|
force?: boolean
|
|
}) => Promise<LinearProjectDetail | null>
|
|
listProjectIssues: (args: {
|
|
projectId: string
|
|
limit?: number
|
|
workspaceId: string
|
|
force?: boolean
|
|
}) => Promise<LinearCollectionResult<LinearIssue>>
|
|
listCustomViews: (args: {
|
|
model: LinearCustomViewModel
|
|
limit?: number
|
|
workspaceId?: LinearWorkspaceSelection
|
|
force?: boolean
|
|
}) => Promise<LinearCollectionResult<LinearCustomViewSummary>>
|
|
getCustomView: (args: {
|
|
viewId: string
|
|
model: LinearCustomViewModel
|
|
workspaceId: string
|
|
force?: boolean
|
|
}) => Promise<LinearCustomViewSummary | null>
|
|
listCustomViewIssues: (args: {
|
|
viewId: string
|
|
limit?: number
|
|
workspaceId: string
|
|
force?: boolean
|
|
}) => Promise<LinearCollectionResult<LinearIssue>>
|
|
listCustomViewProjects: (args: {
|
|
viewId: string
|
|
limit?: number
|
|
workspaceId: string
|
|
force?: boolean
|
|
}) => Promise<LinearCollectionResult<LinearProjectSummary>>
|
|
teamStates: (args: { teamId: string; workspaceId?: string }) => Promise<LinearWorkflowState[]>
|
|
teamLabels: (args: { teamId: string; workspaceId?: string }) => Promise<LinearLabel[]>
|
|
teamMembers: (args: { teamId: string; workspaceId?: string }) => Promise<LinearMember[]>
|
|
}
|