mirror of
https://github.com/stablyai/orca.git
synced 2026-09-29 16:02:50 +00:00
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
152 lines
4.3 KiB
TypeScript
152 lines
4.3 KiB
TypeScript
import type { PRCheckDetail } from '../../shared/github/check-types'
|
|
import type { CheckStatus, IssueInfo, PRInfo } from '../../shared/github/pull-request-types'
|
|
import { derivePRCheckStatusFromRollup } from '../../shared/pr-check-status'
|
|
|
|
// ── REST API check-runs mapping ───────────────────────────────────────
|
|
// The REST check-runs endpoint returns separate status + conclusion fields
|
|
// (unlike gh pr checks which merges them into a single "state" string).
|
|
|
|
export function mapCheckRunRESTStatus(status: string): PRCheckDetail['status'] {
|
|
const s = status?.toLowerCase()
|
|
if (s === 'queued') {
|
|
return 'queued'
|
|
}
|
|
if (s === 'in_progress') {
|
|
return 'in_progress'
|
|
}
|
|
return 'completed'
|
|
}
|
|
|
|
const conclusionMap: Record<string, PRCheckDetail['conclusion']> = {
|
|
success: 'success',
|
|
failure: 'failure',
|
|
cancelled: 'cancelled',
|
|
timed_out: 'timed_out',
|
|
skipped: 'skipped',
|
|
neutral: 'neutral',
|
|
action_required: 'action_required',
|
|
stale: 'failure',
|
|
startup_failure: 'failure'
|
|
}
|
|
|
|
export function mapCheckRunRESTConclusion(
|
|
status: string,
|
|
conclusion: string | null
|
|
): PRCheckDetail['conclusion'] {
|
|
if (status?.toLowerCase() !== 'completed') {
|
|
return 'pending'
|
|
}
|
|
if (!conclusion) {
|
|
return null
|
|
}
|
|
return conclusionMap[conclusion.toLowerCase()] ?? null
|
|
}
|
|
|
|
// ── REST API commit status mapping ──────────────────────────────────────
|
|
// Legacy Jenkins/Prow integrations report commit statuses, not check runs.
|
|
|
|
export function mapCommitStatusRESTStatus(state: string): PRCheckDetail['status'] {
|
|
const s = state?.toLowerCase()
|
|
return s === 'pending' ? 'queued' : 'completed'
|
|
}
|
|
|
|
export function mapCommitStatusRESTConclusion(state: string): PRCheckDetail['conclusion'] {
|
|
const s = state?.toLowerCase()
|
|
if (s === 'success') {
|
|
return 'success'
|
|
}
|
|
if (s === 'failure' || s === 'error') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'pending') {
|
|
return 'pending'
|
|
}
|
|
return null
|
|
}
|
|
|
|
// ── gh pr checks mapping (single "state" string) ─────────────────────
|
|
|
|
export function mapCheckStatus(state: string): PRCheckDetail['status'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'PENDING' || s === 'QUEUED') {
|
|
return 'queued'
|
|
}
|
|
if (s === 'IN_PROGRESS') {
|
|
return 'in_progress'
|
|
}
|
|
return 'completed'
|
|
}
|
|
|
|
export function mapCheckConclusion(state: string): PRCheckDetail['conclusion'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'SUCCESS' || s === 'PASS') {
|
|
return 'success'
|
|
}
|
|
if (s === 'FAILURE' || s === 'FAIL') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'ACTION_REQUIRED') {
|
|
return 'action_required'
|
|
}
|
|
if (s === 'STALE' || s === 'STARTUP_FAILURE') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'CANCELLED') {
|
|
return 'cancelled'
|
|
}
|
|
if (s === 'TIMED_OUT') {
|
|
return 'timed_out'
|
|
}
|
|
if (s === 'SKIPPED') {
|
|
return 'skipped'
|
|
}
|
|
if (s === 'PENDING' || s === 'QUEUED' || s === 'IN_PROGRESS') {
|
|
return 'pending'
|
|
}
|
|
if (s === 'NEUTRAL') {
|
|
return 'neutral'
|
|
}
|
|
return null
|
|
}
|
|
|
|
export function mapPRState(state: string, isDraft?: boolean): PRInfo['state'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'MERGED') {
|
|
return 'merged'
|
|
}
|
|
if (s === 'CLOSED') {
|
|
return 'closed'
|
|
}
|
|
if (isDraft) {
|
|
return 'draft'
|
|
}
|
|
return 'open'
|
|
}
|
|
|
|
// ── Issue mapping ────────────────────────────────────────────────────
|
|
// REST API returns html_url + lowercase state; gh issue view returns url + mixed-case state.
|
|
// This helper normalises both shapes into IssueInfo.
|
|
|
|
export function mapIssueInfo(data: {
|
|
number: number
|
|
title: string
|
|
state: string
|
|
url?: string
|
|
html_url?: string
|
|
labels?: { name: string }[]
|
|
body?: string | null
|
|
}): IssueInfo {
|
|
return {
|
|
number: data.number,
|
|
title: data.title,
|
|
state: data.state?.toLowerCase() === 'open' ? 'open' : 'closed',
|
|
url: data.html_url ?? data.url ?? '',
|
|
labels: (data.labels || []).map((l) => l.name),
|
|
...(typeof data.body === 'string' ? { description: data.body } : {})
|
|
}
|
|
}
|
|
|
|
export function deriveCheckStatus(rollup: unknown[] | null | undefined): CheckStatus {
|
|
return derivePRCheckStatusFromRollup(rollup)
|
|
}
|