Files
orca/src/main/opencode/hook-plugin-child-attention.test.ts
T
OrcaWinandOrcaWin 7d6603aa17 [comment audit] Complete repository-wide comment cleanup (#33249)
* [comment audit] Align legacy failure-read counts with cached display

* [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci]

* [comment audit] Condense shared generation, path and preview comments [skip ci]

* [comment audit] Condense host, file and Git contract rationale [skip ci]

* [comment audit] Tighten Git lifecycle and provider contract comments [skip ci]

* [comment audit] Clarify shared host authority and launch isolation [skip ci]

* [comment audit] simplify local access mobile and native chat contracts [skip ci]

* [comment audit] simplify native chat presentation and state contracts [skip ci]

* [comment audit] simplify native runtime and provider contracts [skip ci]

* [comment audit] simplify migration and orchestration contracts [skip ci]

* [comment audit] simplify plugin trust and process capture rationale [skip ci]

* [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci]

* [comment audit] clarify remote recovery and launch wire rationale [skip ci]

* [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci]

* [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci]

* [comment audit] clarify sidebar, skill and SSH invariants [skip ci]

* [comment audit] condense structured chat delivery and timing rationale [skip ci]

* [comment audit] condense terminal replay and telemetry invariants [skip ci]

* [comment audit] clarify launch permission and terminal delivery rationale [skip ci]

* [comment audit] clarify workspace ownership and layout contracts [skip ci]

* [comment audit] wait for fitted and painted SSH terminal links

* [comment audit] clarify layout persistence and session ownership [skip ci]

* [comment audit] clarify host routing and workspace lifecycle contracts [skip ci]

* [comment audit] clarify startup persistence and app lifetime comments [skip ci]

* [comment audit] clarify recovery and activity boundaries [skip ci]

* [comment audit] condense activity and artifact invariants [skip ci]

* [comment audit] condense automation authority contracts [skip ci]

* [comment audit] simplify automation scheduling and history contracts [skip ci]

* [comment audit] clarify browser chrome and annotation lifecycles [skip ci]

* [comment audit] clarify browser routing and retained guest ownership [skip ci]

* [comment audit] clarify browser recovery and document ownership comments [skip ci]

* [comment audit] restore hosted runners required by native IME fixtures

* [comment audit] shorten preview, palette and dashboard invariants [skip ci]

* [comment audit] clarify terminal preview, dashboard and retention comments [skip ci]

* [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci]

* [comment audit] shorten rich-text and combined-diff ownership comments [skip ci]

* [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci]

* [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci]

* [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci]

* [comment audit] clarify rich Markdown source and selection safeguards [skip ci]

* [comment audit] clarify editor loading and emulator stream lifetimes [skip ci]

* [comment audit] trim emulator and feature tour narration [skip ci]

* [comment audit] clarify floating workspace and GitHub cache ownership [skip ci]

* [comment audit] trim provider controls and Linear filter explanations [skip ci]

* [comment audit] clarify pairing and chat resume lifetimes [skip ci]

* [comment audit] clarify chat delivery and transcript lifetimes [skip ci]

* [comment audit] clarify session options and host-owned status [skip ci]

* [comment audit] clarify draft durability and live-status precedence [skip ci]

* [comment audit] Trim chat send and model ownership explanations [skip ci]

* [comment audit] Shorten transcript ownership and send recovery comments [skip ci]

* [comment audit] Simplify native chat composer and transcript hook comments [skip ci]

* [comment audit] Shorten native chat scroll and structured session explanations [skip ci]

* [comment audit] Trim workspace picker and onboarding commentary [skip ci]

* [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci]

* [comment audit] Trim sidebar and session history explanations [skip ci]

* [comment audit] Condense session resume and review checks comments [skip ci]

* [comment audit] Shorten checks state and file explorer refresh comments [skip ci]

* [comment audit] Trim plugin bridge and source-control action rationale [skip ci]

* [comment audit] Trim source-control listing and review rationale [skip ci]

* [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci]

* [comment audit] Condense Settings account and appearance rationale [skip ci]

* [comment audit] Trim pairing and repository Settings explanations [skip ci]

* [comment audit] Condense Settings search SSH and terminal safeguards [skip ci]

* [comment audit] Shorten Settings voice and provider ownership comments [skip ci]

* [comment audit] Condense Settings draft persistence and host-state rationale [skip ci]

* [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci]

* [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci]

* [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci]

* [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci]

* [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci]

* [comment audit] Prune focus-read baseline after comment cleanup

* [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci]

* [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci]

* [comment audit] Clarify viewport geometry and skill update safeguards [skip ci]

* [comment audit] Tighten skill inventory, usage and host status comments [skip ci]

* [comment audit] Clarify usage ownership and resource kill safeguards [skip ci]

* [comment audit] Tighten tab selection, rename and search contracts [skip ci]

* [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci]

* [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci]

* [comment audit] Tighten provider loading and terminal recovery comments [skip ci]

* [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci]

* [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci]

* [comment audit] Tighten PTY startup and replay explanations [skip ci]

* [comment audit] Clarify PTY identity and delivery ownership [skip ci]

* [comment audit] Shorten remote reconnect and input replay rationale [skip ci]

* [comment audit] Condense terminal parking clipboard and file link comments [skip ci]

* [comment audit] Clarify IME ownership and trim trace history [skip ci]

* [comment audit] Shorten pane recovery and parked watcher explanations [skip ci]

* [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci]

* [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci]

* [comment audit] Trim renderer lifecycle and menu rationale [skip ci]

* [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci]

* [comment audit] Clarify renderer hook evidence and source ownership [skip ci]

* [comment audit] Tighten IPC ownership and reconnect explanations [skip ci]

* [comment audit] Trim renderer focus, paste and attention comments [skip ci]

* [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci]

* [comment audit] Trim agent launch, resume and ownership commentary [skip ci]

* [comment audit] Shorten account, browser and editor comments [skip ci]

* [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci]

* [comment audit] Condense launch recovery and editor tokenization comments [skip ci]

* [comment audit] Condense workspace selection and terminal pane rationale [skip ci]

* [comment audit] Condense terminal fitting and rendering recovery comments [skip ci]

* [comment audit] Condense terminal input and host routing explanations [skip ci]

* [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci]

* [comment audit] Condense structured launch and terminal link explanations [skip ci]

* [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci]

* [comment audit] Condense session persistence and workspace activation rationale [skip ci]

* [comment audit] Condense workspace routing and browser ownership rationale [skip ci]

* [comment audit] Condense mirror recovery and layout authority rationale [skip ci]

* [comment audit] Condense runtime transport and file safety rationale [skip ci]

* [comment audit] Condense runtime graph and structured session rationale [skip ci]

* [comment audit] Condense browser creation and remote tab recovery rationale [skip ci]

* [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci]

* [comment audit] Condense frame, startup and provider cache rationale [skip ci]

* [comment audit] Condense host twin and agent lifecycle rationale [skip ci]

* [comment audit] Condense browser authority and editor cleanup rationale [skip ci]

* [comment audit] Condense editor buffer identity and review cache rationale [skip ci]

* [comment audit] Condense provider lifetime and repository ownership rationale [skip ci]

* [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci]

* [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci]

* [comment audit] Condense cleanup ownership and listing admission rationale [skip ci]

* [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci]

* [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci]

* [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci]

* [comment audit] Condense cloud rollout and assignment safety rationale [skip ci]

* [comment audit] Condense relay session and database recovery rationale [skip ci]

* [comment audit] Condense relay placement and protocol compatibility rationale [skip ci]

* [comment audit] Condense build and packaging constraints [skip ci]

* [comment audit] Condense CI gates and validation isolation rationale [skip ci]

* [comment audit] Condense catalog identity and browser validation rationale [skip ci]

* [comment audit] Condense mobile browser and frame-budget rationale [skip ci]

* [comment audit] Shorten mobile route and browser test explanations [skip ci]

* [comment audit] Condense editor and session seam test rationale [skip ci]

* [comment audit] Trim session and terminal closure history [skip ci]

* [comment audit] Shorten terminal browser and census explanations [skip ci]

* [comment audit] Preserve root-only E2E diagnostic baseline

* [comment audit] Condense mobile seam and HTML preview test rationale [skip ci]

* [comment audit] Condense preview instrumentation and render harness rationale [skip ci]

* [comment audit] Condense bundle contracts and native-build constraints [skip ci]

* [comment audit] Shorten native packaging and CI routing rationale [skip ci]

* [comment audit] Condense release tooling and benchmark constraints [skip ci]

* [comment audit] Condense packaging and platform gate rationale [skip ci]

* [comment audit] Shorten mobile route and history rationale [skip ci]

* [comment audit] Condense mobile browser and component rationale [skip ci]

* [comment audit] Shorten drawer and workspace-form rationale [skip ci]

* [comment audit] Trim mobile review and editor-document explanations [skip ci]

* [comment audit] Condense editor lifecycle and Markdown explanations [skip ci]

* [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci]

* [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci]

* [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci]

* [comment audit] Condense bridge stream, native request and audio rationale [skip ci]

* [comment audit] Reduce bridge schema and page-client commentary [skip ci]

* [comment audit] Tighten mobile page bridge contracts [skip ci]

* [comment audit] Clarify mobile cache and session constraints [skip ci]

* [comment audit] Condense mobile route and lifecycle rationale [skip ci]

* [comment audit] Tighten mobile shell hook timing rationale [skip ci]

* [comment audit] Clarify route handoff and notification compatibility [skip ci]

* [comment audit] Clarify push registration and dictation cleanup constraints [skip ci]

* [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci]

* [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci]

* [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci]

* [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci]

* [comment audit] Tighten stream replay and queued session ownership rationale [skip ci]

* [comment audit] Condense mobile composer and reply-schema constraints [skip ci]

* [comment audit] Clarify mobile transcript recovery and session ownership [skip ci]

* [comment audit] Clarify mobile queue and source-control compatibility [skip ci]

* [comment audit] Condense storage and task launch constraints [skip ci]

* [comment audit] Clarify task schemas and terminal document ownership [skip ci]

* [comment audit] Tighten terminal input and viewport rationale [skip ci]

* [comment audit] Shorten terminal and RPC recorder contracts [skip ci]

* [comment audit] Condense recorder engine and connection contracts [skip ci]

* [comment audit] Shorten host credential and relay recovery comments [skip ci]

* [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci]

* [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci]

* [comment audit] Condense catalog and relay entry contracts [skip ci]

* [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci]

* [comment audit] Condense WSL relay and E2E regression rationale [skip ci]

* [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci]

* [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci]

* [comment audit] Shorten layout oracle and regression explanations [skip ci]

* [comment audit] Condense paired recovery and ownership regression contracts [skip ci]

* [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci]

* [comment audit] Condense terminal rendering and IME regression rationale [skip ci]

* [comment audit] Shorten terminal recovery and benchmark contracts [skip ci]

* [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci]

* [comment audit] Condense workflow routing and release rationale [skip ci]

* [comment audit] Condense mobile security and installer contracts [skip ci]

* [comment audit] Shorten native rationale and stylesheet workarounds [skip ci]

* [comment audit] Shorten Windows visibility probe rationale [skip ci]

* [comment audit] Condense embedded release and signing rationale [skip ci]

* [comment audit] Retain current main test behavior in final reconciliation [skip ci]

* [comment audit] Complete final comment review across current source inventory

* [comment audit] Handle consolidated audit reports before final CI

* [comment audit] Preserve credential storage census detail [skip ci]

* [comment audit] Scale broad changed E2E selections with verified timing shards

* [comment audit] Align E2E assertions with browser close and settled session metadata

* [comment audit] Match existing E2Es to current resource and windowing contracts

* [comment audit] Observe the shared server outage notice in reconnect coverage

* [comment audit] Make existing renderer probes measure settled tab and PTY work

* [comment audit] Align palette E2E selector with task search

* [comment audit] Refresh remaining palette search selectors

* [comment audit] Keep selector correction within selected audit specs

* [comment audit] Await emoji fixture settings inside renderer evaluation

* [comment audit] Cancel fixture fit retries between terminal tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-25 04:05:46 -07:00

604 lines
19 KiB
TypeScript

import { mkdtempSync, rmSync, writeFileSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { pathToFileURL } from 'node:url'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
const { getPathMock } = vi.hoisted(() => ({
getPathMock: vi.fn<(name: string) => string>()
}))
vi.mock('electron', () => ({
app: { getPath: getPathMock }
}))
import { _internals } from './hook-service'
type SessionFixture = { id: string; parentID?: string }
type PluginEvent = { type: string; properties?: Record<string, unknown> }
type PluginEventHandler = (input: { event: PluginEvent }) => Promise<void>
type PluginHooks = { event: PluginEventHandler; dispose?: () => Promise<void> }
type PluginFactory = (ctx: unknown) => Promise<PluginHooks>
type SessionList = (
parameters?: { signal?: AbortSignal },
options?: { signal?: AbortSignal }
) => Promise<{ data: SessionFixture[] }>
type RecordedPost = {
hook_event_name: string
id?: string
sessionID?: string
}
const ENV_KEYS = [
'ORCA_PANE_KEY',
'ORCA_AGENT_HOOK_PORT',
'ORCA_AGENT_HOOK_TOKEN',
'ORCA_AGENT_HOOK_ENDPOINT'
] as const
describe('OpenCode plugin child attention', () => {
let tempDir: string
let posts: RecordedPost[]
let savedEnv: Record<string, string | undefined>
let savedFetch: typeof globalThis.fetch
let pluginFactory: PluginFactory | undefined
beforeEach(() => {
tempDir = mkdtempSync(join(tmpdir(), 'orca-opencode-child-attention-'))
posts = []
savedEnv = {}
for (const key of ENV_KEYS) {
savedEnv[key] = process.env[key]
}
process.env.ORCA_PANE_KEY = 'tab-1:leaf-1'
process.env.ORCA_AGENT_HOOK_PORT = '45678'
process.env.ORCA_AGENT_HOOK_TOKEN = 'test-token'
delete process.env.ORCA_AGENT_HOOK_ENDPOINT
pluginFactory = undefined
savedFetch = globalThis.fetch
globalThis.fetch = vi.fn(async (_url: RequestInfo | URL, init?: RequestInit) => {
const body = JSON.parse(String(init?.body)) as { payload: RecordedPost }
posts.push(body.payload)
return new Response(null, { status: 204 })
}) as typeof globalThis.fetch
})
afterEach(() => {
vi.useRealTimers()
globalThis.fetch = savedFetch
for (const key of ENV_KEYS) {
if (savedEnv[key] === undefined) {
delete process.env[key]
} else {
process.env[key] = savedEnv[key]
}
}
rmSync(tempDir, { recursive: true, force: true })
})
async function createHooks(
sessions: SessionFixture[],
list: SessionList = async () => ({
data: sessions
})
): Promise<PluginHooks> {
if (!pluginFactory) {
const pluginPath = join(tempDir, 'orca-opencode-status.mjs')
writeFileSync(pluginPath, _internals.getOpenCodePluginSource())
const module = (await import(pathToFileURL(pluginPath).href)) as {
OrcaOpenCodeStatusPlugin: PluginFactory
}
pluginFactory = module.OrcaOpenCodeStatusPlugin
}
return pluginFactory({
client: {
session: {
list
}
}
})
}
function status(type: 'busy' | 'idle', sessionID: string): PluginEvent {
return {
type: 'session.status',
properties: { sessionID, status: { type } }
}
}
function attention(
type: 'permission.asked' | 'question.asked',
id: string,
sessionID: string,
tool?: { messageID: string; callID: string }
): PluginEvent {
return {
type,
properties: { id, sessionID, ...(tool ? { tool } : {}) }
}
}
function resolution(
type: 'permission.replied' | 'question.replied' | 'question.rejected',
requestID: string,
sessionID: string
): PluginEvent {
return {
type,
properties: { requestID, sessionID }
}
}
function completedQuestion(
sessionID: string,
messageID: string,
callID: string,
status: 'completed' | 'error' = 'completed'
): PluginEvent {
return {
type: 'message.part.updated',
properties: {
sessionID,
part: {
type: 'tool',
tool: 'question',
messageID,
callID,
state: { status }
}
}
}
}
function names(): string[] {
return posts.map((post) => post.hook_event_name)
}
it.each([
['permission.asked', 'PermissionRequest'],
['question.asked', 'AskUserQuestion']
] as const)('attributes nested child %s to the root pane', async (type, expectedName) => {
const hooks = await createHooks([
{ id: 'root' },
{ id: 'child', parentID: 'root' },
{ id: 'grandchild', parentID: 'child' }
])
await hooks.event({ event: status('busy', 'root') })
await hooks.event({ event: attention(type, 'request-1', 'grandchild') })
expect(posts.at(-1)).toMatchObject({
hook_event_name: expectedName,
id: 'request-1',
sessionID: 'root'
})
})
it('clears only the matching child reply or rejection and preserves root Busy', async () => {
const hooks = await createHooks([
{ id: 'root' },
{ id: 'child-a', parentID: 'root' },
{ id: 'child-b', parentID: 'root' }
])
await hooks.event({ event: status('busy', 'root') })
await hooks.event({ event: attention('question.asked', 'question-a', 'child-a') })
const waitingPosts = posts.length
await hooks.event({ event: status('busy', 'root') })
expect(posts).toHaveLength(waitingPosts)
await hooks.event({ event: attention('permission.asked', 'permission-b', 'child-b') })
await hooks.event({
event: resolution('permission.replied', 'permission-b', 'child-a')
})
expect(posts.at(-1)?.hook_event_name).toBe('PermissionRequest')
await hooks.event({
event: resolution('permission.replied', 'permission-b', 'child-b')
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'question-a',
sessionID: 'root'
})
await hooks.event({
event: resolution('question.rejected', 'question-a', 'child-a')
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'SessionBusy',
sessionID: 'root'
})
await hooks.event({ event: status('idle', 'root') })
expect(posts.at(-1)?.hook_event_name).toBe('SessionIdle')
})
it.each(['completed', 'error'] as const)(
'clears only the matching child question when its tool is %s',
async (completionStatus) => {
const hooks = await createHooks([
{ id: 'root' },
{ id: 'child-a', parentID: 'root' },
{ id: 'child-b', parentID: 'root' }
])
const toolA = { messageID: 'message-a', callID: 'call-a' }
const toolB = { messageID: 'message-b', callID: 'call-b' }
await hooks.event({
event: attention('question.asked', 'question-a', 'child-a', toolA)
})
await hooks.event({
event: attention('question.asked', 'question-b', 'child-b', toolB)
})
const waitingPosts = posts.length
await hooks.event({
event: completedQuestion('child-a', toolB.messageID, toolB.callID, completionStatus)
})
await hooks.event({
event: completedQuestion('child-b', toolB.messageID, 'wrong-call', completionStatus)
})
expect(posts).toHaveLength(waitingPosts)
await hooks.event({
event: completedQuestion('child-b', toolB.messageID, toolB.callID, completionStatus)
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'question-a',
sessionID: 'root'
})
await hooks.event({
event: completedQuestion('child-a', toolA.messageID, toolA.callID, completionStatus)
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'SessionIdle',
sessionID: 'root'
})
}
)
it('uses child Idle only to clean that child blocker, then restores root Busy', async () => {
const hooks = await createHooks([{ id: 'root' }, { id: 'child', parentID: 'root' }])
await hooks.event({ event: status('busy', 'root') })
await hooks.event({ event: attention('question.asked', 'question-child', 'child') })
await hooks.event({ event: status('idle', 'child') })
expect(names()).toEqual(['SessionBusy', 'AskUserQuestion', 'SessionBusy'])
expect(posts.at(-1)?.sessionID).toBe('root')
})
it('lets only matching unknown Idle retire attention across cyclic ancestry', async () => {
const list = vi.fn(async () => ({
data: [
{ id: 'child-a', parentID: 'child-b' },
{ id: 'child-b', parentID: 'child-a' }
]
}))
const hooks = await createHooks([], list)
await hooks.event({
event: attention('question.asked', 'cyclic-question', 'child-a')
})
await hooks.event({ event: status('idle', 'child-b') })
expect(names()).toEqual(['AskUserQuestion'])
await hooks.event({ event: status('idle', 'child-a') })
expect(names()).toEqual(['AskUserQuestion', 'SessionIdle'])
expect(posts[0]).toMatchObject({
id: 'cyclic-question',
sessionID: 'child-a'
})
expect(posts.at(-1)?.sessionID).toBe('child-a')
expect(list).toHaveBeenCalledTimes(6)
})
it('matches a child reply after its ancestry lookup fails', async () => {
let lookupFails = false
const list = vi.fn(async () => {
if (lookupFails) {
throw new Error('lookup unavailable')
}
return { data: [{ id: 'root' }] }
})
const hooks = await createHooks([], list)
await hooks.event({ event: status('busy', 'root') })
lookupFails = true
await hooks.event({
event: attention('permission.asked', 'permission-child', 'child')
})
await hooks.event({
event: resolution('permission.replied', 'permission-child', 'child')
})
expect(names()).toEqual(['SessionBusy', 'PermissionRequest', 'SessionBusy'])
expect(posts.at(-1)?.sessionID).toBe('root')
})
it('clears timed-out child attention without repeating its ancestry lookup', async () => {
vi.useFakeTimers()
let lookupHangs = false
const list = vi.fn(
async (options?: { signal?: AbortSignal }): Promise<{ data: SessionFixture[] }> => {
if (!lookupHangs) {
return { data: [{ id: 'root' }] }
}
return new Promise((_resolve, reject) => {
options?.signal?.addEventListener('abort', () => reject(new Error('aborted')), {
once: true
})
})
}
)
const hooks = await createHooks([], list)
await hooks.event({ event: status('busy', 'root') })
lookupHangs = true
const asked = hooks.event({
event: attention('question.asked', 'question-child', 'child')
})
await vi.advanceTimersByTimeAsync(2_000)
await asked
const lookupCountAfterAsk = list.mock.calls.length
const replied = hooks.event({
event: resolution('question.replied', 'question-child', 'child')
})
await replied
expect(names()).toEqual(['SessionBusy', 'AskUserQuestion', 'SessionBusy'])
expect(posts.at(-1)?.sessionID).toBe('root')
expect(list).toHaveBeenCalledTimes(lookupCountAfterAsk)
})
it('clears timed-out child attention on Idle without making unknown Idle authoritative', async () => {
vi.useFakeTimers()
let lookupHangs = false
const list = vi.fn(
async (options?: { signal?: AbortSignal }): Promise<{ data: SessionFixture[] }> => {
if (!lookupHangs) {
return { data: [{ id: 'root' }] }
}
return new Promise((_resolve, reject) => {
options?.signal?.addEventListener('abort', () => reject(new Error('aborted')), {
once: true
})
})
}
)
const hooks = await createHooks([], list)
await hooks.event({ event: status('busy', 'root') })
lookupHangs = true
const asked = hooks.event({
event: attention('question.asked', 'question-child', 'child')
})
await vi.advanceTimersByTimeAsync(2_000)
await asked
const idle = hooks.event({ event: status('idle', 'child') })
await vi.advanceTimersByTimeAsync(2_000)
await idle
expect(names()).toEqual(['SessionBusy', 'AskUserQuestion', 'SessionBusy'])
expect(posts.at(-1)?.sessionID).toBe('root')
})
it('delivers same-id child blockers across factories when the older owner resolves first', async () => {
const first = await createHooks([{ id: 'root-a' }, { id: 'child-a', parentID: 'root-a' }])
const second = await createHooks([{ id: 'root-b' }, { id: 'child-b', parentID: 'root-b' }])
await first.event({ event: status('busy', 'root-a') })
await second.event({ event: status('busy', 'root-b') })
await first.event({ event: attention('question.asked', 'same-id', 'child-a') })
await second.event({ event: attention('question.asked', 'same-id', 'child-b') })
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'same-id',
sessionID: 'root-b'
})
const postsAfterSecondBlocker = posts.length
await first.event({
event: resolution('question.replied', 'same-id', 'child-a')
})
expect(posts).toHaveLength(postsAfterSecondBlocker)
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'same-id',
sessionID: 'root-b'
})
await second.event({
event: resolution('question.replied', 'same-id', 'child-b')
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'SessionBusy',
sessionID: 'root-b'
})
})
it('keeps same-id blockers from separate sessions in one factory independent', async () => {
const hooks = await createHooks([
{ id: 'root-a' },
{ id: 'child-a', parentID: 'root-a' },
{ id: 'root-b' },
{ id: 'child-b', parentID: 'root-b' }
])
await hooks.event({ event: status('busy', 'root-a') })
await hooks.event({ event: status('busy', 'root-b') })
await hooks.event({ event: attention('question.asked', 'same-id', 'child-a') })
await hooks.event({ event: attention('question.asked', 'same-id', 'child-b') })
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
sessionID: 'root-b'
})
await hooks.event({
event: resolution('question.replied', 'same-id', 'child-a')
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
sessionID: 'root-b'
})
})
it('keeps the oldest blocker waiting when 128 newer blockers resolve', async () => {
const hooks = await createHooks([])
// Cross the old 128-entry cap: live blocker ownership must survive ancestry-cache eviction.
for (let index = 1; index <= 129; index += 1) {
await hooks.event({
event: attention('question.asked', `question-${String(index)}`, `session-${String(index)}`)
})
}
for (let index = 2; index <= 129; index += 1) {
await hooks.event({
event: resolution(
'question.replied',
`question-${String(index)}`,
`session-${String(index)}`
)
})
}
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'question-1',
sessionID: 'session-1'
})
})
it('cleans only the disposed factory blocker', async () => {
const first = await createHooks([{ id: 'root-a' }, { id: 'child-a', parentID: 'root-a' }])
const second = await createHooks([{ id: 'root-b' }, { id: 'child-b', parentID: 'root-b' }])
await first.event({ event: status('busy', 'root-a') })
await second.event({ event: status('busy', 'root-b') })
await first.event({ event: attention('question.asked', 'first-id', 'child-a') })
await second.event({ event: attention('question.asked', 'second-id', 'child-b') })
await second.dispose?.()
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'AskUserQuestion',
id: 'first-id',
sessionID: 'root-a'
})
await first.event({
event: resolution('question.replied', 'first-id', 'child-a')
})
expect(posts.at(-1)).toMatchObject({
hook_event_name: 'SessionBusy',
sessionID: 'root-a'
})
})
it('keeps child lifecycle, deltas, and text previews from overriding root status', async () => {
const hooks = await createHooks([{ id: 'root' }, { id: 'child', parentID: 'root' }])
await hooks.event({ event: status('busy', 'root') })
await hooks.event({ event: status('busy', 'child') })
await hooks.event({ event: status('idle', 'child') })
await hooks.event({
event: {
type: 'message.part.delta',
properties: { sessionID: 'child', field: 'text', delta: 'child work' }
}
})
await hooks.event({
event: {
type: 'message.updated',
properties: {
sessionID: 'child',
info: { id: 'child-message', role: 'assistant' }
}
}
})
await hooks.event({
event: {
type: 'message.part.updated',
properties: {
sessionID: 'child',
part: {
type: 'text',
text: 'private child preview',
messageID: 'child-message'
}
}
}
})
expect(names()).toEqual(['SessionBusy'])
await hooks.event({ event: status('idle', 'root') })
expect(names()).toEqual(['SessionBusy', 'SessionIdle'])
})
it('does not let a delayed child Idle invalidate an in-flight parent preview', async () => {
let releaseRootLookup: (() => void) | undefined
const rootLookup = new Promise<void>((resolve) => {
releaseRootLookup = resolve
})
let notifyRootLookup: (() => void) | undefined
const rootLookupStarted = new Promise<void>((resolve) => {
notifyRootLookup = resolve
})
let releaseChildLookup: (() => void) | undefined
const childLookup = new Promise<void>((resolve) => {
releaseChildLookup = resolve
})
let notifyChildLookup: (() => void) | undefined
const childLookupStarted = new Promise<void>((resolve) => {
notifyChildLookup = resolve
})
let calls = 0
const sessions = [{ id: 'root' }, { id: 'child', parentID: 'root' }]
const list = vi.fn(async () => {
calls += 1
if (calls === 1) {
notifyRootLookup?.()
await rootLookup
} else if (calls === 2) {
notifyChildLookup?.()
await childLookup
}
return { data: sessions }
})
const hooks = await createHooks([], list)
const seedRole = hooks.event({
event: {
type: 'message.updated',
properties: {
sessionID: 'root',
info: { id: 'parent-message', role: 'assistant' }
}
}
})
await rootLookupStarted
const preview = hooks.event({
event: {
type: 'message.part.updated',
properties: {
sessionID: 'root',
part: { type: 'text', text: 'parent preview', messageID: 'parent-message' }
}
}
})
const childIdle = hooks.event({ event: status('idle', 'child') })
try {
releaseRootLookup?.()
await childLookupStarted
await vi.waitFor(() => expect(names()).toEqual(['MessagePart']))
} finally {
releaseChildLookup?.()
}
await Promise.all([seedRole, preview, childIdle])
expect(names()).toEqual(['MessagePart'])
})
})