mirror of
https://github.com/stablyai/orca.git
synced 2026-09-29 08:03:20 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
94 lines
3.5 KiB
TypeScript
94 lines
3.5 KiB
TypeScript
import type { MrStateFilter, SmartNameMode } from './mobile-composer-source-types'
|
|
|
|
// Icon each tab renders: lucide glyphs for the neutral modes, the inline brand
|
|
// SVGs (TaskProviderLogo) for the provider modes since lucide dropped its brand
|
|
// icons.
|
|
export type SmartModeIcon =
|
|
| { type: 'lucide'; name: 'sparkles' | 'git-branch' | 'case-sensitive' }
|
|
| { type: 'provider'; provider: 'github' | 'gitlab' | 'linear' }
|
|
|
|
export type SmartModeOption = {
|
|
id: SmartNameMode
|
|
label: string
|
|
icon: SmartModeIcon
|
|
}
|
|
|
|
// Order + labels + icons mirror desktop getSmartWorkspaceNameModes():
|
|
// Smart · GitHub · Linear · GitLab · Branch · Name.
|
|
export const SMART_MODE_OPTIONS: readonly SmartModeOption[] = [
|
|
{ id: 'smart', label: 'Smart', icon: { type: 'lucide', name: 'sparkles' } },
|
|
{ id: 'github', label: 'GitHub', icon: { type: 'provider', provider: 'github' } },
|
|
{ id: 'linear', label: 'Linear', icon: { type: 'provider', provider: 'linear' } },
|
|
{ id: 'gitlab', label: 'GitLab', icon: { type: 'provider', provider: 'gitlab' } },
|
|
{ id: 'branches', label: 'Branch', icon: { type: 'lucide', name: 'git-branch' } },
|
|
{ id: 'text', label: 'Name', icon: { type: 'lucide', name: 'case-sensitive' } }
|
|
]
|
|
|
|
export type SmartModeAvailabilityInput = {
|
|
textOnly: boolean
|
|
tasksSupported: boolean
|
|
hasRepo: boolean
|
|
githubAvailable: boolean
|
|
gitlabAvailable: boolean
|
|
linearAvailable: boolean
|
|
}
|
|
|
|
// Faithful port of the desktop availableModes filter. Non-git repos collapse to
|
|
// the Name tab; provider tabs gate on availability + a selected repo + the tasks
|
|
// RPC surface; branches only need a git repo (new-branch-by-name works without
|
|
// the search capability).
|
|
export function resolveAvailableSmartModes(input: SmartModeAvailabilityInput): SmartNameMode[] {
|
|
if (input.textOnly) {
|
|
return ['text']
|
|
}
|
|
return SMART_MODE_OPTIONS.filter((option) => {
|
|
switch (option.id) {
|
|
case 'smart':
|
|
return input.tasksSupported
|
|
case 'github':
|
|
return input.tasksSupported && input.hasRepo && input.githubAvailable
|
|
case 'gitlab':
|
|
return input.tasksSupported && input.hasRepo && input.gitlabAvailable
|
|
case 'linear':
|
|
return input.tasksSupported && input.linearAvailable
|
|
case 'branches':
|
|
return input.hasRepo
|
|
case 'text':
|
|
return true
|
|
}
|
|
}).map((option) => option.id)
|
|
}
|
|
|
|
// Default mode when the picker opens: 'smart' for a git repo when search is
|
|
// available, else the first available mode (branches for git without tasks,
|
|
// 'text' for non-git).
|
|
export function resolveDefaultSmartMode(input: SmartModeAvailabilityInput): SmartNameMode {
|
|
const available = resolveAvailableSmartModes(input)
|
|
if (available.includes('smart')) {
|
|
return 'smart'
|
|
}
|
|
return available[0] ?? 'text'
|
|
}
|
|
|
|
// Keeps a chosen mode valid as availability changes (e.g. the repo switches to a
|
|
// non-git folder), mirroring desktop's snap-to-available effect.
|
|
export function normalizeSmartMode(
|
|
mode: SmartNameMode,
|
|
input: SmartModeAvailabilityInput
|
|
): SmartNameMode {
|
|
const available = resolveAvailableSmartModes(input)
|
|
return available.includes(mode) ? mode : resolveDefaultSmartMode(input)
|
|
}
|
|
|
|
export type MrStateFilterOption = { id: MrStateFilter; label: string }
|
|
|
|
// Desktop getMrStateFilters(): Open · Merged · Closed · All, default 'opened'.
|
|
export const MR_STATE_FILTER_OPTIONS: readonly MrStateFilterOption[] = [
|
|
{ id: 'opened', label: 'Open' },
|
|
{ id: 'merged', label: 'Merged' },
|
|
{ id: 'closed', label: 'Closed' },
|
|
{ id: 'all', label: 'All' }
|
|
]
|
|
|
|
export const DEFAULT_MR_STATE_FILTER: MrStateFilter = 'opened'
|