mirror of
https://github.com/stablyai/orca.git
synced 2026-10-26 00:03:55 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
90 lines
3.1 KiB
TypeScript
90 lines
3.1 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import type { TerminalQuickCommand } from '../../../src/shared/terminal-quick-command-types'
|
|
import {
|
|
buildMobileQuickCommandLaunch,
|
|
getQuickCommandDisplayPreview,
|
|
getQuickCommandPreview,
|
|
supportsMobileQuickCommands
|
|
} from './quick-commands'
|
|
|
|
function command(overrides: Partial<TerminalQuickCommand> = {}): TerminalQuickCommand {
|
|
return {
|
|
id: 'command',
|
|
label: 'Command',
|
|
action: 'terminal-command',
|
|
command: 'pnpm test',
|
|
appendEnter: true,
|
|
scope: { type: 'global' },
|
|
...overrides
|
|
} as TerminalQuickCommand
|
|
}
|
|
|
|
describe('mobile quick-command launch', () => {
|
|
it('only exposes quick commands when the host advertises the complete contract', () => {
|
|
expect(supportsMobileQuickCommands(undefined)).toBe(false)
|
|
expect(supportsMobileQuickCommands([])).toBe(false)
|
|
expect(supportsMobileQuickCommands(['terminal.binary-stream.v1'])).toBe(false)
|
|
expect(supportsMobileQuickCommands(['terminal.quick-commands.v1'])).toBe(true)
|
|
})
|
|
|
|
it('joins multiline runnable commands with "; " to match desktop', () => {
|
|
// Parity with desktop flattenTerminalQuickCommand: the same saved command
|
|
// must run identically on desktop and mobile.
|
|
expect(
|
|
buildMobileQuickCommandLaunch(command({ command: 'cd app\nnpm install\nnpm test' }))
|
|
).toEqual({
|
|
options: {
|
|
startupCommand: 'cd app; npm install; npm test',
|
|
startupCommandDelivery: 'shell-ready'
|
|
}
|
|
})
|
|
})
|
|
|
|
it('forces shell-ready delivery for commands that resemble bare agent launches', () => {
|
|
expect(buildMobileQuickCommandLaunch(command({ command: 'codex exec --full-auto' }))).toEqual({
|
|
options: {
|
|
startupCommand: 'codex exec --full-auto',
|
|
startupCommandDelivery: 'shell-ready'
|
|
}
|
|
})
|
|
})
|
|
|
|
it('keeps append-enter-off commands as unsubmitted terminal input', () => {
|
|
const multiline = 'printf "first\\nsecond"\n# leave this unsubmitted'
|
|
expect(
|
|
buildMobileQuickCommandLaunch(command({ command: multiline, appendEnter: false }))
|
|
).toEqual({
|
|
options: { initialPrompt: multiline, enter: false, successToast: 'Command inserted' }
|
|
})
|
|
})
|
|
|
|
it('injects supported agent prompts into the host-built launch command', () => {
|
|
expect(
|
|
buildMobileQuickCommandLaunch(
|
|
command({
|
|
action: 'agent-prompt',
|
|
agent: 'codex',
|
|
prompt: 'Review this diff'
|
|
})
|
|
)
|
|
).toEqual({ agent: 'codex', options: { agentPrompt: 'Review this diff' } })
|
|
})
|
|
|
|
it('bounds native row text without truncating searchable or executable content', () => {
|
|
const longPrompt = `Review ${'x'.repeat(5993)}`
|
|
const agentCommand = command({
|
|
action: 'agent-prompt',
|
|
agent: 'codex',
|
|
prompt: longPrompt
|
|
})
|
|
|
|
expect(getQuickCommandDisplayPreview(agentCommand)).toHaveLength(240)
|
|
expect(getQuickCommandDisplayPreview(agentCommand)).toMatch(/^Codex: Review .*…$/)
|
|
expect(getQuickCommandPreview(agentCommand)).toBe(`Codex: ${longPrompt}`)
|
|
expect(buildMobileQuickCommandLaunch(agentCommand)).toEqual({
|
|
agent: 'codex',
|
|
options: { agentPrompt: longPrompt }
|
|
})
|
|
})
|
|
})
|