mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 00:03:20 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
94 lines
2.7 KiB
TypeScript
94 lines
2.7 KiB
TypeScript
import { execFile } from 'node:child_process'
|
|
import path from 'node:path'
|
|
import { promisify } from 'node:util'
|
|
import { buildLocalPreflightEnv } from './preflight-local-env'
|
|
import { runPreflightCommandInWsl } from './preflight-wsl-command'
|
|
import type { WslPreflightTarget } from './preflight-wsl-agent-detection'
|
|
|
|
const execFileAsync = promisify(execFile)
|
|
export const PREFLIGHT_COMMAND_TIMEOUT_MS = 5000
|
|
|
|
export type PreflightCommandResult = { stdout: string; stderr: string }
|
|
|
|
export function shellQuote(value: string): string {
|
|
return `'${value.replace(/'/g, "'\\''")}'`
|
|
}
|
|
|
|
async function withPreflightTimeout<T>(command: string, commandPromise: Promise<T>): Promise<T> {
|
|
let timeout: ReturnType<typeof setTimeout> | null = null
|
|
try {
|
|
return await Promise.race([
|
|
commandPromise,
|
|
new Promise<never>((_resolve, reject) => {
|
|
timeout = setTimeout(() => {
|
|
const error = Object.assign(new Error(`Timed out running ${command}`), {
|
|
code: 'ETIMEDOUT'
|
|
})
|
|
reject(error)
|
|
}, PREFLIGHT_COMMAND_TIMEOUT_MS)
|
|
if (typeof timeout.unref === 'function') {
|
|
timeout.unref()
|
|
}
|
|
})
|
|
])
|
|
} finally {
|
|
if (timeout) {
|
|
clearTimeout(timeout)
|
|
}
|
|
}
|
|
}
|
|
|
|
export async function execLocalPreflightCommand(
|
|
command: string,
|
|
args: string[]
|
|
): Promise<PreflightCommandResult> {
|
|
const env = buildLocalPreflightEnv()
|
|
const commandPromise = execFileAsync(command, args, {
|
|
encoding: 'utf-8',
|
|
timeout: PREFLIGHT_COMMAND_TIMEOUT_MS,
|
|
...(env ? { env } : {})
|
|
}) as Promise<PreflightCommandResult>
|
|
|
|
return withPreflightTimeout(command, commandPromise)
|
|
}
|
|
|
|
export async function execCommandInWsl(
|
|
target: WslPreflightTarget,
|
|
command: string
|
|
): Promise<PreflightCommandResult> {
|
|
const commandPromise = runPreflightCommandInWsl(target, command, PREFLIGHT_COMMAND_TIMEOUT_MS)
|
|
return withPreflightTimeout('wsl.exe', commandPromise)
|
|
}
|
|
|
|
export async function isCommandAvailable(
|
|
command: string,
|
|
wslTarget?: WslPreflightTarget
|
|
): Promise<boolean> {
|
|
try {
|
|
await (wslTarget
|
|
? execCommandInWsl(wslTarget, `${shellQuote(command)} --version`)
|
|
: execLocalPreflightCommand(command, ['--version']))
|
|
return true
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|
|
|
|
export async function isCommandOnPath(
|
|
command: string,
|
|
wslTarget?: WslPreflightTarget
|
|
): Promise<boolean> {
|
|
const finder = process.platform === 'win32' ? 'where' : 'which'
|
|
try {
|
|
const { stdout } = wslTarget
|
|
? await execCommandInWsl(wslTarget, `command -v ${shellQuote(command)}`)
|
|
: await execLocalPreflightCommand(finder, [command])
|
|
return stdout
|
|
.split(/\r?\n/)
|
|
.map((line) => line.trim())
|
|
.some((line) => path.isAbsolute(line))
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|