mirror of
https://github.com/stablyai/orca.git
synced 2026-09-24 16:02:41 +00:00
Jinwoo-H
20461e8e1f
The mode defaulted to 'request', the 500ms bounded wait, and two of four callers relied on that silently. NOWAIT never waits, so it can never be an edge in a wait-for cycle; the bounded wait can. `lockCellRows(transaction, [cellId])` is therefore the one call shape that reads as harmless at the site and creates the wait edge a cross-table cycle needs, and the planned conversion of releaseExpiredActivityLeases is written exactly like that. Drop the default and pass 'request' explicitly at :3291 and :7568, which is what they already resolved to. :685 threads the caller's mode and :6797 passes 'pool-default', so neither changes. No behaviour change at any of the four. The point is where the mistake is now caught. Writing the unsafe conversion used to produce a passing build and three silently passing policy tests; it is now `error TS2554: Expected 3 arguments, but got 2`. The census still carries its 'unset' handling, and a new test fails if a default is ever reintroduced, so the runtime ratchet and the compiler cannot drift apart. 771 pass against a fresh PostgreSQL.