mirror of
https://github.com/stablyai/orca.git
synced 2026-11-13 17:37:40 +00:00
* Chat UI leaves Experimental: each agent's Chat | CLI choice decides launches Remove the experimentalNativeChat switch and every gate on it. The Chat settings page, Default Agent Chat | CLI choice, + menu Chat/CLI rows, source-control surface choice, Antigravity chat section and orchestration chat-error switch are always present. What a new launch opens comes only from the per-agent choice (no saved choice opens a chat) plus the existing support checks. - One lookup, nativeChatPreferenceFor, keyed by agent id so host-registered agents read the same way; unreadable settings still open a terminal. - A relayed desktop stamp (nativeChatDefault) maps onto the launched agent; an explicit surface still wins. Old phones' createSupport keeps admitting by the host's per-agent choice. - settings.get stops publishing the retired switch keys; nothing in the repo reads them from a host. - Startup chat sync and hydration run when some agent can open as a chat or the machine already holds chats. - The retired key is stripped on load. The one-time upgrade tip from the chat upgrade is retired with its audience record; a new record, captured once from the raw profile, marks which existing profiles had Chat UI off. - The window-side AI-button tab path, which only ran with the switch off, is deleted. * Keep profiles that had Chat UI off on the terminal Existing users who never turned Chat UI on would otherwise see new agent launches open as chats, since an agent without a saved choice now opens as a chat. The one-time load step that records the new audience also sets every known agent to CLI for those profiles, in the same save and only when the record was absent, overwriting saved chat choices the old switch masked. Profiles that had Chat UI on and new profiles are untouched. Browser profiles keep their own settings, so the web client does the same once: a stored switch that is not on seeds CLI choices, and dropping the key marks the step done. Agents first seen after this step open as chats. * Agents without a saved Chat | CLI choice open as their CLI An agent with no saved choice now opens in the terminal for everyone, including fresh installs and agents first seen later. The one-time load step carries what launches opened while Chat UI was experimental: with the switch on, every known agent without a saved choice is saved as chat; with it off, chat choices the switch masked are saved as CLI. Existing profiles join the launch tip audience whether the switch was on or off. Browser profiles get the same carry from their saved key. The startup chat restore and host agent list now run only when some agent is saved as chat or the runtime holds chats. * Preserve owned terminal launches and local chat choices * Clarify chat and terminal support * Explain worker CLI integration timeout budget * Use checked annotations for chat graduation test fixtures * Store agent surface default separately from per-agent overrides * Preserve explicit Chat intent across default changes * Preserve current browser settings during host replies * Correct browser settings factory and regression types * Name exported launch fixture mock types and clarify agent defaults * Preserve settings fallbacks and complete launch test lifecycles * Check allocated tab identity before launch fixture interpolation * Register combined integration project for compiler parity probes * Use checked settings in the launch test fixture * Preserve retired Chat preference data privately * Align chat E2E fixtures and capture pane lifecycle evidence * Use typed raw settings in retention contracts * Consolidate transcript diagnostic imports * test: align chat fixtures with live pane and native menu contracts * test: capture relay tab selection loss diagnostics * test: wait for owned shells before synthetic chat fixtures * test: preserve all-host visibility in SSH observer * test: bind synthetic transcript fixtures before provider seeding * test: assert selected chat owner after narrow image preview * ci: allow fifth compiler project to complete comparison * Type the web-terminal fixture's chat map without an assertion * Right-click the selection itself in the chat copy spec
231 lines
7.9 KiB
TypeScript
231 lines
7.9 KiB
TypeScript
// Replay recorded fcitx4-sogou X11 events: pinyin keyups, plain selector/insertText for characters, Process/229 for phrases, no composition events.
|
|
|
|
import { randomUUID } from 'node:crypto'
|
|
import { mkdtempSync, writeFileSync } from 'node:fs'
|
|
import os from 'node:os'
|
|
import path from 'node:path'
|
|
import type { CDPSession, Locator } from '@stablyai/playwright-test'
|
|
import { test, expect } from './helpers/orca-app'
|
|
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
|
import {
|
|
waitForActivePaneHookDescriptor,
|
|
waitForActivePanePtyId,
|
|
waitForActiveTerminalManager,
|
|
waitForPaneIdentitySnapshot
|
|
} from './helpers/terminal'
|
|
import { waitForPtyShellEcho } from './terminal-pty-readiness'
|
|
|
|
type Key = { key: string; code: string; keyCode: number }
|
|
|
|
function claudeTranscript(sessionId: string): string {
|
|
const startedAt = Date.now() - 60_000
|
|
return `${[
|
|
['user', 'hello'],
|
|
['assistant', 'Ready for input.']
|
|
]
|
|
.map(([role, text], index) =>
|
|
JSON.stringify({
|
|
sessionId,
|
|
uuid: `${sessionId}-${index}`,
|
|
timestamp: new Date(startedAt + index * 1_000).toISOString(),
|
|
type: role,
|
|
message: {
|
|
role,
|
|
model: 'claude-opus-4',
|
|
content: [{ type: 'text', text }]
|
|
}
|
|
})
|
|
)
|
|
.join('\n')}\n`
|
|
}
|
|
|
|
function draft(composer: Locator): Promise<string> {
|
|
return composer.evaluate((element) =>
|
|
Array.from(element.querySelectorAll('p'), (line) => line.textContent ?? '').join('\n')
|
|
)
|
|
}
|
|
|
|
async function pinyinKeyUps(session: CDPSession, letters: string): Promise<void> {
|
|
// Why: the IME grabs each pinyin keydown; the page only sees its release.
|
|
for (const letter of letters) {
|
|
const keyCode = letter.toUpperCase().charCodeAt(0)
|
|
await session.send('Input.dispatchKeyEvent', {
|
|
type: 'keyUp',
|
|
key: letter,
|
|
code: `Key${letter.toUpperCase()}`,
|
|
windowsVirtualKeyCode: keyCode,
|
|
nativeVirtualKeyCode: keyCode
|
|
})
|
|
}
|
|
}
|
|
|
|
async function plainSelectorPick(
|
|
session: CDPSession,
|
|
selector: Key,
|
|
text: string,
|
|
// XIM reports the selector keydown as key NUL / keyCode 0; its keyup is the real key.
|
|
down: Pick<Key, 'key' | 'keyCode'> = selector
|
|
): Promise<void> {
|
|
// keyDown text produces the recorded selector → candidate keypress → insertText sequence.
|
|
await session.send('Input.dispatchKeyEvent', {
|
|
type: 'keyDown',
|
|
key: down.key,
|
|
code: selector.code,
|
|
windowsVirtualKeyCode: down.keyCode,
|
|
nativeVirtualKeyCode: down.keyCode,
|
|
text,
|
|
unmodifiedText: text
|
|
})
|
|
await session.send('Input.dispatchKeyEvent', {
|
|
type: 'keyUp',
|
|
key: selector.key,
|
|
code: selector.code,
|
|
windowsVirtualKeyCode: selector.keyCode,
|
|
nativeVirtualKeyCode: selector.keyCode
|
|
})
|
|
}
|
|
|
|
async function processPhrasePick(session: CDPSession, selector: Key, text: string): Promise<void> {
|
|
await session.send('Input.dispatchKeyEvent', {
|
|
type: 'rawKeyDown',
|
|
key: 'Process',
|
|
code: selector.code,
|
|
windowsVirtualKeyCode: 229,
|
|
nativeVirtualKeyCode: 229
|
|
})
|
|
await session.send('Input.insertText', { text })
|
|
await session.send('Input.dispatchKeyEvent', {
|
|
type: 'keyUp',
|
|
key: selector.key,
|
|
code: selector.code,
|
|
windowsVirtualKeyCode: selector.keyCode,
|
|
nativeVirtualKeyCode: selector.keyCode
|
|
})
|
|
}
|
|
|
|
test('Linux Sogou commits land in the native chat composer', async ({ orcaPage }) => {
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
await ensureTerminalVisible(orcaPage)
|
|
await waitForActiveTerminalManager(orcaPage, 30_000)
|
|
const boundPane = await waitForPaneIdentitySnapshot(orcaPage, 1)
|
|
const ptyId = await waitForActivePanePtyId(orcaPage)
|
|
await waitForPtyShellEcho(orcaPage, ptyId, 15_000)
|
|
const descriptor = await waitForActivePaneHookDescriptor(orcaPage)
|
|
expect(descriptor.paneKey).toBe(`${boundPane.tabId}:${boundPane.activeLeafId}`)
|
|
const [tabId] = descriptor.paneKey.split(':')
|
|
const sessionId = `e2e-sogou-composer-${randomUUID()}`
|
|
const transcriptPath = path.join(
|
|
mkdtempSync(path.join(os.tmpdir(), 'orca-e2e-sogou-composer-')),
|
|
`${sessionId}.jsonl`
|
|
)
|
|
writeFileSync(transcriptPath, claudeTranscript(sessionId))
|
|
|
|
await orcaPage.evaluate(
|
|
async ({ paneKey, worktreeId, tabId, sessionId, transcriptPath }) => {
|
|
const settings = await window.api.settings.set({
|
|
nativeChatProviders: { claude: true, codex: true }
|
|
})
|
|
const store = window.__store
|
|
if (!store) {
|
|
throw new Error('Store unavailable')
|
|
}
|
|
store.setState({ settings })
|
|
const state = store.getState()
|
|
state.setAgentStatus(
|
|
paneKey,
|
|
{ state: 'done', prompt: 'e2e sogou composer', agentType: 'claude' },
|
|
'Claude',
|
|
undefined,
|
|
{ worktreeId },
|
|
{
|
|
providerSession: { key: 'session_id', id: sessionId, transcriptPath }
|
|
}
|
|
)
|
|
const tab = (state.unifiedTabsByWorktree[worktreeId] ?? []).find(
|
|
(candidate) => candidate.contentType === 'terminal' && candidate.entityId === tabId
|
|
)
|
|
if (!tab) {
|
|
throw new Error('Terminal tab unavailable')
|
|
}
|
|
state.toggleTabViewMode(tab.id)
|
|
},
|
|
{ ...descriptor, tabId, sessionId, transcriptPath }
|
|
)
|
|
|
|
const chat = orcaPage.locator('[data-native-chat-root="true"]')
|
|
await expect(chat.getByText('Ready for input.')).toBeVisible()
|
|
const composer = chat.getByRole('textbox')
|
|
await composer.click()
|
|
await expect(composer).toBeFocused()
|
|
const session = await orcaPage.context().newCDPSession(orcaPage)
|
|
await composer.evaluate((element) => {
|
|
const log: string[] = []
|
|
for (const type of ['keydown', 'keypress', 'keyup', 'beforeinput', 'compositionstart']) {
|
|
element.addEventListener(
|
|
type,
|
|
(event) => {
|
|
const detail =
|
|
event instanceof KeyboardEvent
|
|
? `${event.key}/${event.keyCode}/${event.charCode}`
|
|
: event instanceof InputEvent
|
|
? `${event.inputType}/${event.data}`
|
|
: ''
|
|
log.push(`${type}:${detail}`)
|
|
document.documentElement.dataset.sogouEventLog = JSON.stringify(log)
|
|
},
|
|
true
|
|
)
|
|
}
|
|
})
|
|
|
|
await pinyinKeyUps(session, 'ni')
|
|
await plainSelectorPick(session, { key: ' ', code: 'Space', keyCode: 32 }, '你')
|
|
await expect.poll(() => draft(composer)).toBe('你')
|
|
// Guards the replay itself: it must match the recorded fixture shape.
|
|
expect(
|
|
await orcaPage.evaluate((): unknown =>
|
|
JSON.parse(document.documentElement.dataset.sogouEventLog ?? '[]')
|
|
)
|
|
).toEqual([
|
|
'keyup:n/78/0',
|
|
'keyup:i/73/0',
|
|
'keydown: /32/0',
|
|
`keypress: /20320/20320`,
|
|
'beforeinput:insertText/你',
|
|
'keyup: /32/0'
|
|
])
|
|
|
|
await pinyinKeyUps(session, 'hao')
|
|
await plainSelectorPick(session, { key: '3', code: 'Digit3', keyCode: 51 }, '浩')
|
|
await expect.poll(() => draft(composer)).toBe('你浩')
|
|
|
|
await pinyinKeyUps(session, 'nihao')
|
|
await processPhrasePick(session, { key: ' ', code: 'Space', keyCode: 32 }, '你好')
|
|
await expect.poll(() => draft(composer)).toBe('你浩你好')
|
|
|
|
await pinyinKeyUps(session, 'ni')
|
|
await plainSelectorPick(session, { key: ' ', code: 'Space', keyCode: 32 }, '你', {
|
|
key: '\u0000',
|
|
keyCode: 0
|
|
})
|
|
await expect.poll(() => draft(composer)).toBe('你浩你好你')
|
|
|
|
// Client-preedit engines compose instead; the commit must land the same way.
|
|
await session.send('Input.imeSetComposition', {
|
|
text: '好',
|
|
selectionStart: 1,
|
|
selectionEnd: 1
|
|
})
|
|
await session.send('Input.insertText', { text: '好' })
|
|
await expect.poll(() => draft(composer)).toBe('你浩你好你好')
|
|
|
|
await composer.pressSequentially(' ok')
|
|
await expect.poll(() => draft(composer)).toBe('你浩你好你好 ok')
|
|
const finalPane = await waitForPaneIdentitySnapshot(orcaPage, 1)
|
|
expect(finalPane.tabId).toBe(boundPane.tabId)
|
|
expect(finalPane.activeLeafId).toBe(boundPane.activeLeafId)
|
|
expect(finalPane.ptyIdsByLeafId).toEqual(boundPane.ptyIdsByLeafId)
|
|
await expect(chat).toBeVisible()
|
|
})
|