mirror of
https://github.com/stablyai/orca.git
synced 2026-11-13 17:37:40 +00:00
Neil
d47ed1c468
* fix(agent-status): skipping a Codex async question clears it on SSH panes too An SSH pane's Codex hooks are normalized by orcad on the host, so the desktop's own hook server had no row to apply the skip keystroke to. The renderer now sends a remote pane's skip to the owning runtime through a new terminal.inferCodexQuestionSkip RPC, which applies it to the host's tracker. * test(e2e): skipping a Codex async question clears a managed SSH terminal's row
78 lines
3.2 KiB
TypeScript
78 lines
3.2 KiB
TypeScript
// A Codex async question skipped (Ctrl+]) in a managed SSH terminal clears on the desktop: orcad on
|
|
// the host tracks the question, so the desktop must hand the keystroke to it.
|
|
import { expect, test } from './helpers/orca-app'
|
|
import {
|
|
echoMarker,
|
|
launchManagedWorkspace,
|
|
openTerminalTab,
|
|
skipUnlessManagedDockerHost,
|
|
typeInTerminal,
|
|
withManagedHost
|
|
} from './helpers/orcad-managed-workspace'
|
|
import { quotePosixShell } from '../../src/shared/shell/launch/shell-argument-quoting'
|
|
|
|
skipUnlessManagedDockerHost()
|
|
test.skip(process.platform === 'win32', 'The Docker SSH host uses POSIX tooling')
|
|
|
|
function postCodexHook(payload: Record<string, unknown>): string {
|
|
return [
|
|
'curl -sS -X POST "http://127.0.0.1:${ORCA_AGENT_HOOK_PORT}/hook/codex"',
|
|
'-H "X-Orca-Agent-Hook-Token: ${ORCA_AGENT_HOOK_TOKEN}"',
|
|
'--data-urlencode "paneKey=${ORCA_PANE_KEY}" --data-urlencode "tabId=${ORCA_TAB_ID}"',
|
|
'--data-urlencode "worktreeId=${ORCA_WORKTREE_ID}" --data-urlencode "env=${ORCA_AGENT_HOOK_ENV}"',
|
|
'--data-urlencode "version=${ORCA_AGENT_HOOK_VERSION}"',
|
|
`--data-urlencode ${quotePosixShell(`payload=${JSON.stringify(payload)}`)} >>/tmp/orca-hook.log 2>&1`
|
|
].join(' ')
|
|
}
|
|
|
|
test('skipping a Codex async question in a managed SSH terminal clears its waiting row', async (// oxlint-disable-next-line no-empty-pattern -- Owns its app launch through a restart session.
|
|
{}, testInfo) => {
|
|
// Provisions a Docker SSH host and deploys orcad before the app launches.
|
|
test.setTimeout(10 * 60_000)
|
|
await withManagedHost(testInfo, async (fixture) => {
|
|
const { page, seeded } = await launchManagedWorkspace(fixture)
|
|
const tabId = await openTerminalTab(page, seeded.worktreeId)
|
|
await echoMarker(page, tabId, 'SKIP_READY')
|
|
const prompt = `orca codex skip ${Date.now()}`
|
|
const ask = {
|
|
hook_event_name: 'PreToolUse',
|
|
turn_id: 'turn-1',
|
|
tool_name: 'request_user_input_async',
|
|
tool_use_id: 'call_1',
|
|
tool_input: { questions: [{ title: 'Which database?', options: ['Postgres', 'SQLite'] }] }
|
|
}
|
|
// Backgrounded: a foreground post ends the shell command, which rightly clears the turn.
|
|
await typeInTerminal(
|
|
page,
|
|
tabId,
|
|
`( sleep 0.2; ${[
|
|
postCodexHook({ hook_event_name: 'UserPromptSubmit', turn_id: 'turn-1', prompt }),
|
|
postCodexHook(ask),
|
|
postCodexHook({
|
|
...ask,
|
|
hook_event_name: 'PostToolUse',
|
|
tool_response: '{"accepted":true}'
|
|
})
|
|
].join('; ')} ) &`
|
|
)
|
|
const rowState = () =>
|
|
page.evaluate(
|
|
(prompt) =>
|
|
Object.values(window.__store?.getState().agentStatusByPaneKey ?? {}).find(
|
|
(entry) => entry.prompt === prompt && entry.agentType === 'codex'
|
|
)?.state ?? null,
|
|
prompt
|
|
)
|
|
await expect
|
|
.poll(rowState, { timeout: 30_000, message: 'the open question never reached the desktop' })
|
|
.toBe('waiting')
|
|
|
|
// Codex's TUI drops the question on Ctrl+] and reports nothing; only the keystroke tells.
|
|
await page.keyboard.press('Control+BracketRight')
|
|
await expect
|
|
.poll(rowState, { timeout: 30_000, message: 'the skipped question stayed pending' })
|
|
.toBe('working')
|
|
await page.screenshot({ path: testInfo.outputPath('codex-question-skipped.png') })
|
|
})
|
|
})
|