Files
orca/src/main/gitea
e4f5e1ddf1 fix(gitea): treat HTTP 404 as no-PR in the hosted-review branch lookup (#10411)
* fix(gitea): treat HTTP 404 as no-PR in throwing hosted-review lookup

hostedReview:forBranch always uses the throwing Gitea lookup variant, and
requestJsonAtBase threw on any non-OK status. A 404 (PR deleted, repo absent
on the forge, or Gitea masking a private repo) rejected the IPC handler and
spammed the main-process log on every refresh for every unaffiliated branch.

404 means the resource is absent — an accepted "no PR", not a transport or
auth failure. Map it to null even with throwOnFailure; 401/403/5xx/network
errors still throw so creation eligibility keeps reporting 'unavailable'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(gitea): scope the 404 no-PR exemption to the linked-PR fetch

A blanket status !== 404 exemption in the shared request helper also
covered the repo-level /pulls scan, where a 404 means a wrong API base
URL, a repo absent from the forge, or a token without scope. Collapsing
that to "no PR" would make a misconfigured Gitea host look permanently
PR-less instead of surfacing reviewLookupOutcome: 'unavailable'.

Gate the exemption on an explicit allowNotFound request option, set only
on the single-resource /pulls/{n} fetch.

Co-authored-by: Orca <help@stably.ai>

* test(gitea): pin the 200-with-empty-list no-PR shape alongside the 404 case

Co-authored-by: Orca <help@stably.ai>

* fix(gitea): preserve deleted linked pull request absence handling

Refresh the original Donach PR and its prior maintainer correction on current main, keeping the HTTP404 exemption limited to the linked pull resource.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
Co-authored-by: Orca <help@stably.ai>
2026-10-23 19:20:13 -07:00
..