Files
orca/src/shared/remote-runtime-shared-control-subscriptions.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

122 lines
4.0 KiB
TypeScript

import { randomUUID } from 'node:crypto'
import type { RuntimeRpcResponse } from './runtime-rpc-envelope'
import { getCleanupRequest, getSubscriptionId } from './remote-runtime-shared-control-protocol'
import {
finishSharedControlSubscription,
handleSharedControlSubscriptionResponse
} from './remote-runtime-shared-control-state'
import type {
SharedControlLogicalSubscription,
SharedControlSubscriptionCallbacks
} from './remote-runtime-shared-control-types'
export function createSharedControlSubscription<TResult>(args: {
requestId: string
method: string
params: unknown
callbacks: SharedControlSubscriptionCallbacks<TResult>
}): SharedControlLogicalSubscription<TResult> {
return {
requestId: args.requestId,
method: args.method,
params: args.params,
callbacks: args.callbacks,
sent: false,
closed: false,
closeAfterReady: false,
remoteSubscriptionId: null
}
}
export function handleSharedControlLogicalResponse(args: {
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
subscription: SharedControlLogicalSubscription<unknown>
response: RuntimeRpcResponse<unknown>
request: (method: string, params: unknown) => void
}): void {
if (!args.subscription.closeAfterReady) {
handleSharedControlSubscriptionResponse(args.subscriptions, args.subscription, args.response)
return
}
if (args.response.ok) {
const subscriptionId = getSubscriptionId(args.response.result)
if (subscriptionId) {
args.subscription.remoteSubscriptionId = subscriptionId
}
const cleanup = getCleanupRequest(args.subscription)
if (cleanup) {
args.request(cleanup.method, cleanup.params)
}
}
finishSharedControlSubscription(args.subscriptions, args.subscription, false)
}
export function closeSharedControlLogicalSubscription(args: {
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
subscription: SharedControlLogicalSubscription<unknown>
request: (method: string, params: unknown) => void
}): void {
const cleanup = getCleanupRequest(args.subscription)
if (cleanup) {
finishSharedControlSubscription(args.subscriptions, args.subscription, false)
args.request(cleanup.method, cleanup.params)
return
}
if (args.subscription.sent && cleanupNeedsRemoteSubscriptionId(args.subscription.method)) {
// Why: id-scoped server subscriptions can only be cleaned up after the
// server returns its concrete subscription id in the ready response.
args.subscription.closeAfterReady = true
return
}
finishSharedControlSubscription(args.subscriptions, args.subscription, false)
}
export function sendSharedControlCleanupRequest(args: {
deviceToken: string
method: string
params: unknown
send: (payload: unknown) => boolean
}): void {
// Why: cleanup is best-effort and often runs during teardown; send it
// synchronously so close() cannot race the async request path.
args.send({
id: randomUUID(),
deviceToken: args.deviceToken,
method: args.method,
params: args.params
})
}
export function replaySharedControlSubscriptions(args: {
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
send: (subscription: SharedControlLogicalSubscription<unknown>) => void
}): void {
for (const subscription of args.subscriptions.values()) {
if (subscription.closeAfterReady) {
continue
}
subscription.sent = false
subscription.remoteSubscriptionId = null
args.send(subscription)
}
}
export function finishCloseAfterReadySubscriptions(
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
): void {
for (const subscription of Array.from(subscriptions.values())) {
if (subscription.closeAfterReady) {
finishSharedControlSubscription(subscriptions, subscription, false)
}
}
}
function cleanupNeedsRemoteSubscriptionId(method: string): boolean {
return (
method === 'accounts.subscribe' ||
method === 'notifications.subscribe' ||
method === 'runtime.clientEvents.subscribe' ||
method === 'files.watch'
)
}