Files
orca/config
Neil 8d5d1d548b fix(terminal): stop terminal search overflowing the stack on long wrapped lines
@xterm/addon-search's SearchEngine._findInLine rewound to the first row of a
wrapped line by calling itself once per wrapped row, so recursion depth equalled
the number of screen rows one logical line occupies. A single un-newlined line
(base64, a minified bundle, one huge log record) in a pane with Orca's scrollback
throws RangeError: Maximum call stack size exceeded out of TerminalSearch's
effect, which safeFind rethrows, tripping the terminal.workbench error boundary
and killing the whole terminal surface (crash report 012eb5be, Orca 1.4.194).

Patch the rewind into a loop, through the existing xterm patch harness: a source
patch under config/patches/xterm-src/ plus the generated dist patch, both emitted
by config/scripts/regenerate-xterm-patches.mjs from the pinned upstream commit.

Still present in @xterm/addon-search 0.17.0-beta.301; worth upstreaming.
2026-09-02 22:42:08 -07:00
..