mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 16:47:34 +00:00
* feat(ci): ratchet raw repo connectionId host reads; one drop-in resolver Codex review 6 class fix (#4/#6/#7): host decisions read off a repo row's legacy connectionId miss rows that name SSH only as executionHostId. - getRepoRoutingConnectionId (shared/execution-host.ts): drop-in for a raw repo.connectionId routing check that also finds executionHostId-only SSH. - check-repo-host-read-ratchet: per-file count of raw repo connectionId reads in src/main, src/shared, src/cli; counts may only shrink. - Migrated 66 cheap reads: runtime GitHub/GitLab commands, PR/MR head ref fetches, preserved-branch cleanup, ref queries, base-ref IPC, worktree preparation, trash sweep, scan cache TTL, usage metadata. * fix(ipc): PR base IPC routes executionHostId-only SSH rows; ratchet is a stated lower bound Review follow-up (Opus on #31096): - worktrees:resolvePrBase decided git/gh routing on the raw connectionId while its head-ref fetches already used the resolver; one resolved connectionId now drives all of it (test fails on main). - getRepoRoutingConnectionId's contract is stated exactly: never local when the raw field is set; on a contradictory ssh row executionHostId wins. - The ratchet regex no longer matches report.connectionId; header and docs say it is a lower bound. - Regression tests for a runtime GitHub and GitLab command site. * test(ci): pin the repo host-read ratchet step to the static phase * fix(ci): repo host-read ratchet skips verbatim field copies into projected rows A copy of connectionId into a projected row decides nothing; migrating it to the resolver would change what the projection publishes. The sidebar feed catalog's copy (added after the baseline) and two older projections no longer count; baseline pruned to 91.
119 lines
3.4 KiB
TypeScript
119 lines
3.4 KiB
TypeScript
import type { GitHubCreateIssueFields, GitHubIssueUpdate } from '../../shared/issue-mutation-types'
|
|
import type { GitHubOwnerRepo } from '../../shared/github/pull-request-types'
|
|
import type { GitHubPRReviewCommentInput } from '../../shared/github/comment-types'
|
|
import type { Repo } from '../../shared/repo-types'
|
|
import type { LocalProjectGhExecOptions } from '../project-runtime-git-options'
|
|
import {
|
|
addIssueComment,
|
|
addPRReviewComment,
|
|
addPRReviewCommentReply,
|
|
createIssue,
|
|
updateIssue
|
|
} from '../github/client'
|
|
import { getRepoRoutingConnectionId } from '../../shared/execution-host'
|
|
|
|
type LocalGitArgs = [] | [LocalProjectGhExecOptions]
|
|
|
|
type RuntimeGitHubIssueCommentCommandsDeps = {
|
|
resolveRepo: (selector: string) => Promise<Repo>
|
|
getLocalGitArgs: (repo: Repo) => LocalGitArgs
|
|
}
|
|
|
|
export class RuntimeGitHubIssueCommentCommands {
|
|
constructor(private readonly deps: RuntimeGitHubIssueCommentCommandsDeps) {}
|
|
|
|
async createRepoIssue(
|
|
repoSelector: string,
|
|
title: string,
|
|
body: string,
|
|
fields?: GitHubCreateIssueFields
|
|
): Promise<Awaited<ReturnType<typeof createIssue>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return createIssue(
|
|
repo.path,
|
|
title,
|
|
body,
|
|
repo.issueSourcePreference,
|
|
getRepoRoutingConnectionId(repo),
|
|
fields,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async updateRepoIssue(
|
|
repoSelector: string,
|
|
number: number,
|
|
updates: GitHubIssueUpdate
|
|
): Promise<Awaited<ReturnType<typeof updateIssue>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return updateIssue(
|
|
repo.path,
|
|
number,
|
|
updates,
|
|
getRepoRoutingConnectionId(repo),
|
|
this.deps.getLocalGitArgs(repo)[0],
|
|
repo.issueSourcePreference
|
|
)
|
|
}
|
|
|
|
async addRepoIssueComment(
|
|
repoSelector: string,
|
|
number: number,
|
|
body: string,
|
|
prRepo?: GitHubOwnerRepo | null,
|
|
type?: 'issue' | 'pr'
|
|
): Promise<Awaited<ReturnType<typeof addIssueComment>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addIssueComment(
|
|
repo.path,
|
|
number,
|
|
body,
|
|
getRepoRoutingConnectionId(repo),
|
|
prRepo ?? null,
|
|
this.deps.getLocalGitArgs(repo)[0],
|
|
// Why: the issue source selector only scopes issues; PR comments keep their resolution.
|
|
type === 'pr' ? undefined : repo.issueSourcePreference
|
|
)
|
|
}
|
|
|
|
async addRepoPRReviewComment(
|
|
repoSelector: string,
|
|
args: Omit<GitHubPRReviewCommentInput, 'repoPath'>
|
|
): Promise<Awaited<ReturnType<typeof addPRReviewComment>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addPRReviewComment({
|
|
repoPath: repo.path,
|
|
connectionId: getRepoRoutingConnectionId(repo),
|
|
localGitOptions: this.deps.getLocalGitArgs(repo)[0],
|
|
...args
|
|
})
|
|
}
|
|
|
|
async addRepoPRReviewCommentReply(
|
|
repoSelector: string,
|
|
args: {
|
|
prNumber: number
|
|
commentId: number
|
|
body: string
|
|
threadId?: string
|
|
path?: string
|
|
line?: number
|
|
prRepo?: GitHubOwnerRepo | null
|
|
}
|
|
): Promise<Awaited<ReturnType<typeof addPRReviewCommentReply>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addPRReviewCommentReply(
|
|
repo.path,
|
|
args.prNumber,
|
|
args.commentId,
|
|
args.body,
|
|
args.threadId,
|
|
args.path,
|
|
args.line,
|
|
getRepoRoutingConnectionId(repo),
|
|
args.prRepo ?? null,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
}
|