mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 16:47:34 +00:00
* ci: ratchet synchronous child-process launches in main and shared code
The Electron main process freezes every window while a synchronous child
process runs, and on Windows each launch is slow because antivirus scans
it. Nothing stopped new synchronous launches from landing in main-process
code, and the spawn observer behind ORCA_MAIN_THREAD_DIAGNOSTICS only saw
async spawns, so the worst blocks were invisible to it.
Ratchet: check:main-sync-spawn-ratchet parses production src/main and
src/shared files (test-only paths excluded) and fails when a file not in
config/main-sync-spawn-baseline.txt reaches execFileSync, spawnSync or
execSync from child_process, runProcessSync from @orca/process-host, or
one of the synchronous secure-file writers (they run icacls on Windows).
Named, aliased, namespace, default, require() and import() forms count.
A baseline entry whose file no longer launches synchronously fails as
stale, so the list can only shrink. It runs in lint and in the PR
static-analysis job next to the process-host import check.
Observer: runProcessSync now reports to the spawn observer, timing the
whole call (that is how long the thread was stuck) and reporting from a
finally so failing, throwing and timed-out children are counted too.
Runtime behavior is unchanged except that the diagnostics observer now
sees synchronous launches; with no observer registered the sync path
pays one extra branch.
* ci: count sync launches per file and gate the repo's sync wrappers
The sync-spawn ratchet only tracked which files launched synchronously, so a
file already on the list (wsl.ts, win32-utils.ts, git-exec-file.ts) could add
more launches unnoticed, and new callers of the repo's own synchronous
wrappers passed CI.
The baseline now stores a per-file count of uses, in the same format as the
focus-read ratchet: a rise or a new file fails, a lower or zero count fails
until `pnpm check:main-sync-spawn-ratchet --prune` lowers it, and --prune
never raises an entry. Every value reference to a gated function counts
(call, hand-off, alias and its uses, re-export); imports alone count nothing.
Gated wrappers: gitExecFileSync (and the git/runner re-export),
restrictWindowsPathSync, hardenSecurePath when called with sync: true,
grantDirAcl, getWslHome, listWslDistros, wslUncDirectoryExists,
isWslAvailable (and the wsl.ts re-export), isPwshAvailable. Their 18
current caller files join the baseline.
Failure messages now give advice per family: the async process-host API for
child-process launches, the async twin for wrappers, and for the secure
writers a note that no async secure writer exists yet, so the sync one stays
and must never become a plain write (that drops the Windows ACL hardening).
Also refresh two stale blockMs descriptions and drop a no-op line from the
spawn-observer "stays silent" test.
* ci: count hardenSecurePath unless visibly async, and tighten ratchet tests
hardenSecurePath was counted only when `{ sync: true }` was written inline,
so moving the options into a variable or a spread dropped the count and the
check then asked for a prune. It now counts every use except a call with no
options or a spread-free object literal whose `sync` is absent or false.
Also: resolve backslash paths in the importing file as well as the
specifier; still visit heritage and instantiation expressions
(`extends mixin(fn)`, `fn<T>`); state the reference-only counting limit;
and point the secure-writer advice at raising this file's baseline count.
Tests cover the hardenSecurePath shapes, the alias chains that need the
fixpoint loop, and a prune that must not raise a grown row.
* test(ci): pin the main sync-spawn ratchet background step
* fix: count secure hardening calls with spread arguments
226 lines
9.4 KiB
TypeScript
226 lines
9.4 KiB
TypeScript
/**
|
|
* Diagnostic-only measurement: how much of main's event loop does git
|
|
* subprocess orchestration actually consume, and which phase dominates?
|
|
*
|
|
* Why a separate spec from terminal-multi-workspace-typing-latency: that bench
|
|
* measures typing latency UNDER churn, so its numbers mix PTY relay, renderer
|
|
* paint and git. This one runs git churn alone against a hidden window and
|
|
* takes a V8 CPU profile OF THE MAIN PROCESS for each phase, which is the only
|
|
* way to split spawn initiation from stdout drain from porcelain parsing — the
|
|
* churn probe reports spawn initiation only (the whole run for synchronous launches).
|
|
*
|
|
* Run: ORCA_GIT_COST_BENCH=1 ORCA_BACKGROUND_LAUNCH=1 \
|
|
* npx playwright test tests/e2e/main-thread-git-cost.spec.ts \
|
|
* --config tests/playwright.config.ts --project electron-headless --workers=1
|
|
*/
|
|
import { expect, test } from './helpers/orca-app'
|
|
import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import path from 'node:path'
|
|
import {
|
|
createGitChurnRepos,
|
|
registerGitChurnRepos,
|
|
startGitChurnLoad,
|
|
stopGitChurnLoad,
|
|
type GitChurnStats
|
|
} from './git-churn-load'
|
|
|
|
type MainThreadReport = {
|
|
t: number
|
|
maxGapMs?: number
|
|
gapsOver50Ms?: number
|
|
gapsOver250Ms?: number
|
|
spawnCount?: number
|
|
spawns?: Record<string, { count: number; blockMsTotal: number; blockMsMax: number }>
|
|
marker?: string
|
|
wallMs: number
|
|
}
|
|
|
|
type Phase = { label: string; repos: number; concurrency: number; seconds: number }
|
|
|
|
const FILES_PER_REPO = Number(process.env.ORCA_GIT_COST_FILES ?? 400)
|
|
const PHASE_SECONDS = Number(process.env.ORCA_GIT_COST_PHASE_SECONDS ?? 20)
|
|
const MAX_REPOS = Number(process.env.ORCA_GIT_COST_REPOS ?? 24)
|
|
|
|
const PHASES: Phase[] = [
|
|
{ label: 'idle', repos: 0, concurrency: 0, seconds: PHASE_SECONDS },
|
|
{ label: 'c1', repos: MAX_REPOS, concurrency: 1, seconds: PHASE_SECONDS },
|
|
{ label: 'c4', repos: MAX_REPOS, concurrency: 4, seconds: PHASE_SECONDS },
|
|
{ label: 'c8', repos: MAX_REPOS, concurrency: 8, seconds: PHASE_SECONDS },
|
|
{ label: 'c16', repos: MAX_REPOS, concurrency: 16, seconds: PHASE_SECONDS },
|
|
{ label: 'c32', repos: MAX_REPOS, concurrency: 32, seconds: PHASE_SECONDS }
|
|
]
|
|
|
|
test.use({
|
|
orcaAppExtraEnv: { ORCA_MAIN_THREAD_DIAGNOSTICS: '1', ORCA_BACKGROUND_LAUNCH: '1' }
|
|
})
|
|
|
|
test.describe('main-thread git orchestration cost', () => {
|
|
test.skip(
|
|
process.env.ORCA_GIT_COST_BENCH !== '1',
|
|
'Diagnostic bench; set ORCA_GIT_COST_BENCH=1 to run'
|
|
)
|
|
test.setTimeout((PHASES.reduce((sum, phase) => sum + phase.seconds, 0) + 600) * 1000)
|
|
|
|
test('measures spawn / drain / parse split under git churn', async ({
|
|
orcaPage,
|
|
electronApp
|
|
}, testInfo) => {
|
|
const reports: MainThreadReport[] = []
|
|
const stderr = electronApp.process().stderr
|
|
expect(stderr, 'electron stderr must be piped for the churn probe').toBeTruthy()
|
|
let buffer = ''
|
|
stderr?.setEncoding('utf-8')
|
|
stderr?.on('data', (chunk: string) => {
|
|
buffer += chunk
|
|
let index = buffer.indexOf('\n')
|
|
while (index !== -1) {
|
|
const line = buffer.slice(0, index).trimEnd()
|
|
buffer = buffer.slice(index + 1)
|
|
index = buffer.indexOf('\n')
|
|
const match = /^\[main-thread\] (\{.*\})$/.exec(line)
|
|
if (!match) {
|
|
continue
|
|
}
|
|
try {
|
|
reports.push({ ...JSON.parse(match[1]), wallMs: Date.now() })
|
|
} catch {
|
|
// ignore malformed probe line
|
|
}
|
|
}
|
|
})
|
|
|
|
const churnRoot = mkdtempSync(path.join(tmpdir(), 'orca-git-cost-'))
|
|
const profileDir = path.join(testInfo.outputDir, 'main-profiles')
|
|
mkdirSync(profileDir, { recursive: true })
|
|
const results: Record<string, unknown>[] = []
|
|
try {
|
|
const repos = createGitChurnRepos(churnRoot, MAX_REPOS, FILES_PER_REPO)
|
|
const registration = await registerGitChurnRepos(
|
|
orcaPage,
|
|
repos.map((repo) => repo.path)
|
|
)
|
|
expect(
|
|
registration,
|
|
`churn repos were not registered: ${registration.failures.join('; ')}`
|
|
).toMatchObject({ registered: repos.length })
|
|
|
|
for (const phase of PHASES) {
|
|
const profilePath = path.join(profileDir, `main-${phase.label}.cpuprofile`)
|
|
await startMainProfiler(electronApp)
|
|
const startedAt = Date.now()
|
|
if (phase.concurrency > 0) {
|
|
await startGitChurnLoad(
|
|
orcaPage,
|
|
repos.slice(0, phase.repos).map((repo) => repo.path),
|
|
{ concurrency: phase.concurrency, admissionTier: 'status' }
|
|
)
|
|
}
|
|
await new Promise((resolve) => setTimeout(resolve, phase.seconds * 1000))
|
|
const churn: GitChurnStats | null =
|
|
phase.concurrency > 0 ? await stopGitChurnLoad(orcaPage) : null
|
|
const endedAt = Date.now()
|
|
const wallMs = await stopMainProfiler(electronApp, profilePath)
|
|
// Skip the first window: it straddles the previous phase's tail.
|
|
const phaseReports = reports.filter(
|
|
(report) =>
|
|
!report.marker && report.wallMs >= startedAt + 5_000 && report.wallMs <= endedAt + 1_000
|
|
)
|
|
results.push({
|
|
phase: phase.label,
|
|
repos: phase.repos,
|
|
concurrency: phase.concurrency,
|
|
windowMs: endedAt - startedAt,
|
|
profileWallMs: wallMs,
|
|
reportCount: phaseReports.length,
|
|
maxGapMs: Math.max(0, ...phaseReports.map((report) => report.maxGapMs ?? 0)),
|
|
gapsOver50Ms: sum(phaseReports.map((report) => report.gapsOver50Ms ?? 0)),
|
|
gapsOver250Ms: sum(phaseReports.map((report) => report.gapsOver250Ms ?? 0)),
|
|
spawnCount: sum(phaseReports.map((report) => report.spawnCount ?? 0)),
|
|
spawns: mergeSpawns(phaseReports),
|
|
churn,
|
|
profilePath
|
|
})
|
|
console.log(`[git-cost] ${JSON.stringify(results.at(-1))}`)
|
|
}
|
|
} finally {
|
|
await stopGitChurnLoad(orcaPage).catch(() => null)
|
|
rmSync(churnRoot, { recursive: true, force: true })
|
|
}
|
|
const summaryPath = path.join(profileDir, 'summary.json')
|
|
writeFileSync(summaryPath, JSON.stringify({ filesPerRepo: FILES_PER_REPO, results }, null, 2))
|
|
console.log(`[git-cost] summary=${summaryPath}`)
|
|
expect(readFileSync(summaryPath, 'utf8').length).toBeGreaterThan(0)
|
|
})
|
|
})
|
|
|
|
function sum(values: number[]): number {
|
|
return values.reduce((total, value) => total + value, 0)
|
|
}
|
|
|
|
function mergeSpawns(
|
|
reports: MainThreadReport[]
|
|
): Record<string, { count: number; blockMsTotal: number; blockMsMax: number }> {
|
|
const merged: Record<string, { count: number; blockMsTotal: number; blockMsMax: number }> = {}
|
|
for (const report of reports) {
|
|
for (const [key, stats] of Object.entries(report.spawns ?? {})) {
|
|
const entry = (merged[key] ??= { count: 0, blockMsTotal: 0, blockMsMax: 0 })
|
|
entry.count += stats.count
|
|
entry.blockMsTotal = Math.round((entry.blockMsTotal + stats.blockMsTotal) * 100) / 100
|
|
entry.blockMsMax = Math.max(entry.blockMsMax, stats.blockMsMax)
|
|
}
|
|
}
|
|
return merged
|
|
}
|
|
|
|
/** V8 CPU profile of the MAIN process, taken from inside main via node:inspector. */
|
|
async function startMainProfiler(electronApp: {
|
|
evaluate: <R, A>(fn: (electron: unknown, arg: A) => R | Promise<R>, arg: A) => Promise<R>
|
|
}): Promise<void> {
|
|
await electronApp.evaluate(async (_electron, intervalUs: number) => {
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: diagnostic-only scratch globals owned by this bench.
|
|
const scope = globalThis as unknown as Record<string, unknown>
|
|
const inspector = process.getBuiltinModule('node:inspector')
|
|
const session = new inspector.Session()
|
|
session.connect()
|
|
type InspectorParams = { interval?: number }
|
|
const post = (method: string, params?: InspectorParams): Promise<Record<string, unknown>> =>
|
|
new Promise((resolve, reject) => {
|
|
session.post(method, params, (error, result) =>
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: node:inspector types the callback payload as unknown; every Profiler reply is an object.
|
|
error ? reject(error) : resolve(result as Record<string, unknown>)
|
|
)
|
|
})
|
|
await post('Profiler.enable')
|
|
await post('Profiler.setSamplingInterval', { interval: intervalUs })
|
|
await post('Profiler.start')
|
|
scope.__orcaGitCostProfiler = { session, post, startedAt: Date.now() }
|
|
}, 500)
|
|
}
|
|
|
|
async function stopMainProfiler(
|
|
electronApp: {
|
|
evaluate: <R, A>(fn: (electron: unknown, arg: A) => R | Promise<R>, arg: A) => Promise<R>
|
|
},
|
|
outPath: string
|
|
): Promise<number> {
|
|
return electronApp.evaluate(async (_electron, target: string) => {
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: same bench-owned global installed above.
|
|
const scope = globalThis as unknown as Record<string, unknown>
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the shape startMainProfiler stored on this same global, in this same process.
|
|
const handle = scope.__orcaGitCostProfiler as {
|
|
session: { disconnect: () => void }
|
|
post: (method: string, params?: { interval?: number }) => Promise<Record<string, unknown>>
|
|
startedAt: number
|
|
}
|
|
const { profile } = await handle.post('Profiler.stop')
|
|
const wallMs = Date.now() - handle.startedAt
|
|
process
|
|
.getBuiltinModule('node:fs')
|
|
.writeFileSync(target, JSON.stringify(profile), { mode: 0o600 })
|
|
handle.session.disconnect()
|
|
delete scope.__orcaGitCostProfiler
|
|
return wallMs
|
|
}, outPath)
|
|
}
|