mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
Jinjing
126009d4c5
Older requested refs predate the security addon builder, so the desktop template CI job failed trying to run a script that isn't there. Gate the build, keep, and collect steps on that script existing in the checkout. Add a test that pins the gating for both cases. Also drop an unused getAppEnvironment import in orcad-entry.ts.
104 lines
3.9 KiB
JavaScript
104 lines
3.9 KiB
JavaScript
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { dirname, join } from 'node:path'
|
|
import { runInNewContext } from 'node:vm'
|
|
import { afterEach, expect, it, vi } from 'vitest'
|
|
import { parse } from 'yaml'
|
|
import { windowsSecurityAddonOutput } from './build-windows-security-addon.mjs'
|
|
import { stageOrcadWindowsSecurity } from './orcad-windows-security.mjs'
|
|
|
|
const roots = []
|
|
afterEach(() => roots.splice(0).forEach((root) => rmSync(root, { recursive: true, force: true })))
|
|
|
|
function peBytes(machine) {
|
|
const bytes = Buffer.alloc(0x90)
|
|
bytes.write('MZ')
|
|
bytes.writeUInt32LE(0x80, 0x3c)
|
|
bytes.write('PE\0\0', 0x80)
|
|
bytes.writeUInt16LE(machine, 0x84)
|
|
return bytes
|
|
}
|
|
|
|
function fixture() {
|
|
const root = mkdtempSync(join(tmpdir(), 'orcad-windows-security-'))
|
|
roots.push(root)
|
|
const output = join(root, 'output')
|
|
mkdirSync(output)
|
|
const write = (arch, machine) => {
|
|
const source = windowsSecurityAddonOutput(root, arch)
|
|
mkdirSync(dirname(source), { recursive: true })
|
|
writeFileSync(source, peBytes(machine))
|
|
return source
|
|
}
|
|
return { root, output, write }
|
|
}
|
|
|
|
it('stages the addon for each Windows architecture after checking its machine', () => {
|
|
const { root, output, write } = fixture()
|
|
const x64 = write('x64', 0x8664)
|
|
stageOrcadWindowsSecurity(root, output, 'win32-x64')
|
|
expect(readFileSync(join(output, 'windows-security.node'))).toEqual(readFileSync(x64))
|
|
|
|
const arm64 = write('arm64', 0xaa64)
|
|
stageOrcadWindowsSecurity(root, output, 'win32-arm64')
|
|
expect(readFileSync(join(output, 'windows-security.node'))).toEqual(readFileSync(arm64))
|
|
})
|
|
|
|
it('rejects a binary built for the wrong architecture', () => {
|
|
const { root, output, write } = fixture()
|
|
write('arm64', 0x8664)
|
|
expect(() => stageOrcadWindowsSecurity(root, output, 'win32-arm64')).toThrow('machine 0x8664')
|
|
expect(existsSync(join(output, 'windows-security.node'))).toBe(false)
|
|
})
|
|
|
|
it('fails the build off Windows when the addon was never built, and compiles it on Windows', () => {
|
|
const { root, output, write } = fixture()
|
|
expect(() => stageOrcadWindowsSecurity(root, output, 'win32-x64', { platform: 'linux' })).toThrow(
|
|
'build-windows-security-addon.mjs --arch=x64'
|
|
)
|
|
|
|
const compile = vi.fn((compileRoot, arch) => write(arch, 0x8664))
|
|
stageOrcadWindowsSecurity(root, output, 'win32-x64', { platform: 'win32' }, compile)
|
|
expect(compile).toHaveBeenCalledWith(root, 'x64')
|
|
expect(existsSync(join(output, 'windows-security.node'))).toBe(true)
|
|
})
|
|
|
|
it('stages nothing for non-Windows slots', () => {
|
|
const { root, output } = fixture()
|
|
stageOrcadWindowsSecurity(root, output, 'linux-x64-glibc', { platform: 'linux' })
|
|
stageOrcadWindowsSecurity(root, output, 'darwin-arm64', { platform: 'darwin' })
|
|
expect(existsSync(join(output, 'windows-security.node'))).toBe(false)
|
|
})
|
|
|
|
it.each([
|
|
['older', false],
|
|
['current', true]
|
|
])('builds and collects security addons only when the %s source ships them', (_source, ships) => {
|
|
const workflow = parse(readFileSync('.github/workflows/node-server-tests.yml', 'utf8'))
|
|
const steps = [
|
|
...workflow.jobs.persistence.steps.filter((step) =>
|
|
['Build', 'Keep'].some((verb) => step.name?.startsWith(`${verb} the Windows security addons`))
|
|
),
|
|
workflow.jobs.desktop_template.steps.find(
|
|
(step) => step.name === 'Collect the Windows security addons'
|
|
)
|
|
]
|
|
expect(steps).toHaveLength(3)
|
|
for (const step of steps) {
|
|
const hashFiles = vi.fn((path) => {
|
|
expect(path).toBe('config/scripts/build-windows-security-addon.mjs')
|
|
return ships ? 'source-hash' : ''
|
|
})
|
|
expect(
|
|
runInNewContext(step.if ?? 'true', {
|
|
inputs: { build_template: true },
|
|
matrix: { os: 'windows-2022' },
|
|
hashFiles
|
|
}),
|
|
step.name
|
|
).toBe(ships)
|
|
expect(hashFiles).toHaveBeenCalledOnce()
|
|
expect(step['continue-on-error']).toBeUndefined()
|
|
}
|
|
})
|