mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 18:17:36 +00:00
Neil
c0e5b189aa
Idle-app CPU profiling showed `titleHasAgentName` running 11,771x/sec and the legacy any-agent regex 4,399x/sec, roughly once per zustand subscriber notify. The regexes were already precompiled; the problem was call volume — every store write re-classified every unchanged pane title through the whole agent-name ladder. Every title classifier is pure in the title string, so memoize them on it (bounded FIFO, 1024 entries). A new title is a new key, so there is no staleness window. The same profile showed the sidebar lineage projection re-scanning all worktrees several times per pass; cache it on the identity pair of its two immutable inputs, mirroring store/worktree-repo-index.ts.
44 lines
1.7 KiB
TypeScript
44 lines
1.7 KiB
TypeScript
/**
|
|
* Bounded memo for pure `(title: string) => T` terminal-title classifiers.
|
|
*
|
|
* Why: the sidebar cards and tab strip re-derive agent identity/status from
|
|
* every pane title inside zustand selectors and render bodies, so an UNCHANGED
|
|
* title was re-tested against every agent-name regex on every store write —
|
|
* thousands of classifications per second while the app sat idle. Every
|
|
* classifier below depends on nothing but the title string, so the verdict is
|
|
* reusable until the title itself changes; a new title is simply a new key, so
|
|
* there is no staleness window and no invalidation signal to miss.
|
|
*/
|
|
|
|
/**
|
|
* Cap: comfortably above the live working set (one title per open pane plus
|
|
* retained rows) so steady-state hit rate stays ~100%, small enough that the
|
|
* map cannot grow with session length. Entries hold a reference to a string the
|
|
* store already retains, so the marginal cost is the map entry itself.
|
|
*/
|
|
const MAX_MEMOIZED_TITLES = 1024
|
|
|
|
export function memoizeTitleClassification<T>(
|
|
classify: (title: string) => T
|
|
): (title: string) => T {
|
|
// Boxed values so `undefined`/`null` verdicts are still cache hits.
|
|
const cache = new Map<string, { value: T }>()
|
|
return (title: string): T => {
|
|
const cached = cache.get(title)
|
|
if (cached) {
|
|
return cached.value
|
|
}
|
|
const value = classify(title)
|
|
// Insertion-ordered FIFO eviction: a pane's superseded title frames are the
|
|
// oldest keys and the least likely to be asked for again.
|
|
if (cache.size >= MAX_MEMOIZED_TITLES) {
|
|
const oldest = cache.keys().next()
|
|
if (!oldest.done) {
|
|
cache.delete(oldest.value)
|
|
}
|
|
}
|
|
cache.set(title, { value })
|
|
return value
|
|
}
|
|
}
|