mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 00:02:31 +00:00
Jinwoo Hong
3e4fd4a7af
* Shorten orchestration skill description under the Agent Skills 1024-char limit The folded description was 1038 chars, so spec-conforming installers such as SkillStar rejected the bundled orchestration skill. Drop the two clauses already covered elsewhere in the same description: "decomposing work across agents" (implied by "structured multi-agent coordination") and "automation of the browser embedded inside Orca" (restated by the locked `orca-cli` embedded-pages sentence). Every routing trigger asserted by orchestration-skill-guidance.test.mjs, the orca-cli handoff boundary, and the Computer Use boundary are unchanged. Result: 958 chars. Add config/scripts/skill-description-length.test.mjs, which parses every skills/*/SKILL.md frontmatter with `yaml` and fails on an empty or >1024 char description, so the regression cannot return. orca-cli sits at 1015 and is left as is. Fixes #17935 * Keep the embedded browser in the orchestration description's orca-cli routing Restores the word "browser" in the orca-cli sentence ("and the Orca embedded browser") so agents scanning for it still route embedded-browser control to orca-cli. Description is 985 chars, 39 under the spec limit.
40 lines
1.5 KiB
JavaScript
40 lines
1.5 KiB
JavaScript
import { readdirSync, readFileSync } from 'node:fs'
|
|
import { join, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { parse } from 'yaml'
|
|
|
|
const skillsDir = resolve(import.meta.dirname, '../../skills')
|
|
// Why: the Agent Skills spec caps `description` at 1024 chars and conforming installers
|
|
// reject the whole skill (#17935); the frontmatter is what the installer parses, so check it.
|
|
const MAX_DESCRIPTION_LENGTH = 1024
|
|
|
|
function readDescription(skillName) {
|
|
const skillMarkdown = readFileSync(join(skillsDir, skillName, 'SKILL.md'), 'utf8')
|
|
const frontmatter = /^---\r?\n([\s\S]*?)\r?\n---\r?\n/u.exec(skillMarkdown)?.[1]
|
|
|
|
expect(frontmatter, `${skillName}: missing frontmatter`).toBeDefined()
|
|
|
|
return parse(frontmatter ?? '').description
|
|
}
|
|
|
|
describe('bundled skill descriptions', () => {
|
|
const skillNames = readdirSync(skillsDir, { withFileTypes: true })
|
|
.filter((entry) => entry.isDirectory())
|
|
.map((entry) => entry.name)
|
|
|
|
it('discovers the bundled skills', () => {
|
|
expect(skillNames).toContain('orchestration')
|
|
})
|
|
|
|
it.each(skillNames)('%s keeps description within the Agent Skills spec limit', (name) => {
|
|
const description = readDescription(name)
|
|
|
|
expect(typeof description, `${name}: description must be a string`).toBe('string')
|
|
expect(description.trim().length, `${name}: description is empty`).toBeGreaterThan(0)
|
|
expect(
|
|
description.length,
|
|
`${name}: description is ${description.length} chars`
|
|
).toBeLessThanOrEqual(MAX_DESCRIPTION_LENGTH)
|
|
})
|
|
})
|