mirror of
https://github.com/stablyai/orca.git
synced 2026-09-25 08:02:31 +00:00
Neil
93a080112f
* fix(linear): stop the filter coverage warning firing on complete selections #17342 inferred transport-cap truncation from the bounded filter after the fact, with `atLimit = selectedIds.length >= max`. A row the cap could not fit leaves no trace in the surviving ids, so at exactly the cap a complete selection and a trimmed one are indistinguishable from the value alone, and the inference biased toward always warning. A workspace with 20 teams x 5 status names expands to exactly 100 ids: picking all 5 rows is provably untruncated, yet the menu read "100 selected · partial". Record the trim where it happens instead. `applyPickedFilter` holds both the pre-cap expansion and the bounded result, so it stores the surviving ids as a truncation record; the notice, section-menu summary, and pill consume that flag. Keying the record on the ids it describes is what keeps it fresh — the moment the facet carries anything else (row toggle, pill clear, Clear all, the prune effect, a workspace switch) the record no longer matches and the warning goes away, which matters because the prune effect only ever removes ids. `intended > applied` stays as the fallback for restored filters that carry no record, and `boundLinearIssueAttributeFilter` is still the last word on the cap. Also moves the section-menu partial marker out of the `max-w-[120px] truncate` summary span, where "100 selected · partial" could clip. Refs STA-5996 * test(linear): cover the untouched-facet truncation guard The guard that keeps a recorded trim alive across an unrelated facet click was untested — the first attempt sat where intended > applied, so the value-derived shortfall answered for it and removing the guard left every test green. Move the scenario onto the cap, where only the record can speak. Also stop an empty record matching an empty facet: a filter carrying nothing is never truncated. * test(linear): pin set equality, not subset, on a truncation record A facet that grew past its record has refetched underneath it; matching by subset would keep warning about a trim that no longer describes the filter. Found by mutation: the subset mutant survived the whole suite. * test(linear): fuzz that the coverage pill and the section notice agree They are the same claim rendered twice; a pill reading partial over a silent section is a lie either way round. 20k random topologies, zero divergence.