mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
Jinjing
cda2280d63
* Add all-host automations with scoped ownership and multi-authority suppo
Enable automations to run on multiple hosts (SSH targets and local) with
owner-fenced mutations, scoped list queries per host, and conflict
resolution. Introduces desktop and runtime authorities as distinct
automation storage owners, with per-host caching, invalidation, and
retry scheduling on the renderer. Captures registration generations for
SSH hosts to survive re-adoption. Adds CLI support for destination
selection and conflict recovery.
* Filter automation create projects by destination host
Only offer projects available on the selected destination, preventing
the mismatches that would fail at submit time. Auto-adjust the project
selection if it becomes unavailable when the destination changes.
* Add runtime storage authority support for automations
- Support both runtime and desktop as automation storage authorities
- Make owner preconditions optional for legacy-client compatibility
- Cache automation list projections to improve performance
- Add per-row repo/worktree resolution for cross-authority collisions
- Extend automation.list RPC to always include owner metadata
* Replace child_process.execFile with runProcess for external automations
- Migrate external-manager to use cross-platform runProcess wrapper per child-process safety policy
- Abstract electron app/ipcMain APIs in orca-runtime via environment accessors
- Install fake app environment in automation tests for consistent setup
- Reorganize imports to use specific module paths (ssh-target-registry, agent-detection, browser-error)
- Remove external-manager from child-process import allowlists (no longer violates direct import)
* Unify desktop automation CRUD onto the local runtime RPC surface
The desktop authority now speaks the same automation.* RPC contract as
remote runtimes, via callRuntimeRpc({kind:'local'}) -> runtime:call ->
the shared RpcDispatcher. The automations:list/listRuns/create/update/
delete/runNow IPC arms, their preload members, and every renderer
desktop-vs-runtime transport fork are retired; the runtime methods are
the single implementation of scoped lists, owner fencing, and change
publication for both transports (mobile clients already exercised them).
The desktop probe scheduler's priority lease survives the move as an
AutomationService hook the IPC registration installs and the runtime
methods take, so Orca's own automation traffic still parks queued
external-manager probes.
External-manager scope arms and dispatch-loop plumbing stay on IPC by
design; automation change events keep their existing channels (renderer
ingestion already converges them by authority).
* Remove automation ghost SSH tombstone scanning
This functionality for synthesizing tombstones for automation-referenced SSH
targets is no longer needed as part of the automation system refactoring.
* Refuse orphan automations at dispatch time, not migration time
Remove migration-time disabling of orphan automations and the `enabledDecidedBy` field. Dispatch now refuses orphans at runtime instead, simplifying state management and UI. Orphans are left unstamped and enabled; dispatch refuses to run them via `resolveAutomationRunTarget`.
* Show all automations in flat table with unified filter menu
- Replace host picker component with comprehensive Filters menu supporting status, last run, agent, and host filters
- Flatten automation list layout to single table instead of host-grouped sections
- Add Host column to display execution host for each automation
- Display active filters as removable pills below toolbar
- Delete unused AutomationHostPicker* components
* Add automation owner fencing and destination validation
- New AUTOMATION_OWNER_FENCING_RUNTIME_CAPABILITY for owner preconditions; legacy clients get owner metadata snapshotted at RPC boundary for compatibility
- Editor captures and revalidates automation destination before save, preventing silent retargeting if SSH infrastructure changes mid-edit
- SSH target types now isolate renderer-authored fields; generation is server-owned and stripped by IPC handlers
* Route automation recovery actions to the origin host
When an automation action fails due to owner fencing, recovery verbs
("Update server", "Reconnect") must run on the host where the refusal
originated: the row's captured owner for row operations, or the
destination the create dialog captured, not the list's filtered host.
* Remove external manager scope limitation notices
Consolidate create destination eligibility checks with a unified predicate
and fix the bug where desktop repo IDs could be sent to runtime hosts where
they cannot resolve.
* Persist only store-derived automation contexts, not client-perspective o
Store contexts must never be based on client-provided runContext or sourceContext
values—clients speak a different perspective (e.g., 'runtime:<id>' for host IDs
they assign), and persisting those makes the store projection orphan automations
it actually owns. Derived contexts now take precedence in create and update paths,
with explicit null still honored to clear a value. Tests verify this by simulating
drift after storage and confirming that moves re-derive while toggles preserve.
63 lines
1.9 KiB
TypeScript
63 lines
1.9 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { normalizeFolderWorkspaces } from './folder-workspaces'
|
|
import type { ProjectGroup } from './project-group-types'
|
|
|
|
const folderGroup = {
|
|
id: 'group-1',
|
|
name: 'Projects',
|
|
parentPath: '/tmp/projects',
|
|
connectionId: null
|
|
} as unknown as ProjectGroup
|
|
|
|
describe('normalizeFolderWorkspaces host attribution', () => {
|
|
it('drops a stored executionHostId instead of round-tripping it', () => {
|
|
const [workspace] = normalizeFolderWorkspaces(
|
|
[
|
|
{
|
|
id: 'ws-1',
|
|
projectGroupId: 'group-1',
|
|
name: 'Nightly',
|
|
folderPath: '/tmp/projects/nightly',
|
|
connectionId: null,
|
|
executionHostId: 'runtime:env-7'
|
|
}
|
|
],
|
|
[folderGroup]
|
|
)
|
|
|
|
// A runtime-scoped stamp names an authority the desktop store does not own, and it
|
|
// carries no generation to fence on — persisting it would recreate the divergence #12 fixed.
|
|
expect(workspace).toBeDefined()
|
|
expect(workspace.executionHostId).toBeUndefined()
|
|
expect(Object.keys(workspace)).not.toContain('executionHostId')
|
|
})
|
|
|
|
it('keeps connectionId as the durable host pin', () => {
|
|
const [pinned] = normalizeFolderWorkspaces(
|
|
[
|
|
{
|
|
id: 'ws-2',
|
|
projectGroupId: 'group-1',
|
|
name: 'Pinned',
|
|
folderPath: '/tmp/projects/pinned',
|
|
connectionId: 'ssh-box',
|
|
executionHostId: 'local'
|
|
}
|
|
],
|
|
[folderGroup]
|
|
)
|
|
|
|
expect(pinned.connectionId).toBe('ssh-box')
|
|
expect(pinned.executionHostId).toBeUndefined()
|
|
})
|
|
|
|
it('inherits the group connection when the workspace omits one', () => {
|
|
const [inherited] = normalizeFolderWorkspaces(
|
|
[{ id: 'ws-3', projectGroupId: 'group-1', name: 'Inherited' }],
|
|
[{ ...folderGroup, connectionId: 'ssh-group' } as ProjectGroup]
|
|
)
|
|
|
|
expect(inherited.connectionId).toBe('ssh-group')
|
|
})
|
|
})
|