mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
* chore(dead-code): drop 2k lines of unreachable exports and orphan modules Ran knip across every build entry (main, preload, renderer, popout, web, cli, relay, workers, forked sidecars, config scripts) and removed what no entry graph can reach. - 11 orphan modules nothing imported, plus one test that only covered them - 159 unused exports/types, with their now-dead helpers, imports and tests Each candidate was verified against dynamic references before deletion. 42 knip hits were false positives and are kept: shared modules consumed by the mobile/ workspace, the src/shared/plugins/** public API, vendored shadcn primitives, and relay wire-protocol constants held for compatibility. Adds knip.json + `pnpm audit:dead-code` so this stays measurable. Verified: pnpm typecheck, pnpm lint, and 2081 tests across the 73 affected test files all pass. * chore(dead-code): move knip config under config/ Root-level additions are blocked by the root directory guard. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
93 lines
2.9 KiB
TypeScript
93 lines
2.9 KiB
TypeScript
import { isBehindOnlyUpstream, shouldForcePushWithLeaseForUpstream } from './git-upstream-status'
|
|
import type { HostedReviewCreationEligibility } from './hosted-review'
|
|
import { supportsHostedReviewCreation } from './hosted-review-creation-providers'
|
|
import type { GitUpstreamStatus } from './git-status-types'
|
|
|
|
export type CreateReviewIntentKind =
|
|
| 'dirty'
|
|
| 'message_required'
|
|
| 'no_upstream'
|
|
| 'needs_push'
|
|
| 'needs_sync'
|
|
| 'force_push'
|
|
|
|
export type CreateReviewIntentEligibility = {
|
|
eligible: boolean
|
|
kind: CreateReviewIntentKind | null
|
|
}
|
|
|
|
export function resolveCreateReviewIntentEligibility({
|
|
stagedCount,
|
|
hasStageableChanges,
|
|
hasMessage,
|
|
hasUnresolvedConflicts,
|
|
upstreamStatus,
|
|
hostedReviewCreation,
|
|
branchCommitsAhead,
|
|
hasCurrentBranch = true
|
|
}: {
|
|
stagedCount: number
|
|
hasStageableChanges: boolean
|
|
hasMessage: boolean
|
|
hasUnresolvedConflicts: boolean
|
|
upstreamStatus: GitUpstreamStatus | undefined
|
|
hostedReviewCreation?: HostedReviewCreationEligibility | null
|
|
branchCommitsAhead?: number
|
|
hasCurrentBranch?: boolean
|
|
}): CreateReviewIntentEligibility {
|
|
if (
|
|
hasUnresolvedConflicts ||
|
|
!hasCurrentBranch ||
|
|
!hostedReviewCreation ||
|
|
hostedReviewCreation.canCreate ||
|
|
!supportsHostedReviewCreation(hostedReviewCreation.provider)
|
|
) {
|
|
return { eligible: false, kind: null }
|
|
}
|
|
|
|
if (
|
|
hostedReviewCreation.reviewLookupOutcome === 'unavailable' &&
|
|
!hostedReviewCreation.defaultBaseRef?.trim()
|
|
) {
|
|
return { eligible: false, kind: null }
|
|
}
|
|
|
|
// Why: safe branch preparation can continue without lookup authority; the
|
|
// main create preflight still fails closed before creating a duplicate.
|
|
if (hostedReviewCreation.blockedReason === 'dirty') {
|
|
if (stagedCount > 0 && !hasMessage) {
|
|
return { eligible: true, kind: 'message_required' }
|
|
}
|
|
return { eligible: stagedCount > 0 || hasStageableChanges, kind: 'dirty' }
|
|
}
|
|
|
|
if (hostedReviewCreation.blockedReason === 'no_upstream') {
|
|
const hasPublishableCommits = branchCommitsAhead === undefined ? false : branchCommitsAhead > 0
|
|
return {
|
|
eligible: hasPublishableCommits || stagedCount > 0 || hasStageableChanges,
|
|
kind: 'no_upstream'
|
|
}
|
|
}
|
|
|
|
if (hostedReviewCreation.blockedReason === 'needs_push') {
|
|
return { eligible: true, kind: 'needs_push' }
|
|
}
|
|
|
|
if (
|
|
hostedReviewCreation.blockedReason === 'needs_sync' &&
|
|
shouldForcePushWithLeaseForUpstream(upstreamStatus)
|
|
) {
|
|
return { eligible: true, kind: 'force_push' }
|
|
}
|
|
|
|
// Why: a behind-only branch is safe to prepare with `git pull --ff-only`, so
|
|
// the intent flow can handle it in one click. A genuinely diverged branch
|
|
// stays ineligible — auto-merging would reconcile without consent, so the
|
|
// user keeps the explicit sync-first step.
|
|
if (hostedReviewCreation.blockedReason === 'needs_sync' && isBehindOnlyUpstream(upstreamStatus)) {
|
|
return { eligible: true, kind: 'needs_sync' }
|
|
}
|
|
|
|
return { eligible: false, kind: null }
|
|
}
|