mirror of
https://github.com/stablyai/orca.git
synced 2026-09-21 16:02:20 +00:00
Neil
20794ee785
The compatibility gate started the pinned 2.25.5 source build inside the same step that runs the three measured lanes, so `make -j$(nproc)` competed with two container lanes whose wall clock is container starts, not Git. A boundary case that costs ~1.5s stretched past Vitest's 30s timeout and failed the job. Build the binary in its own step before the matrix, and pull both images before any lane starts so a lazy pull cannot stall whichever test its sibling is timing.
65 lines
3.0 KiB
JavaScript
65 lines
3.0 KiB
JavaScript
import { readFileSync } from 'node:fs'
|
|
import { parse } from 'yaml'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
const BASELINE_DIR = '~/.cache/orca-git-compat/git-2.25.5'
|
|
|
|
const gateSteps = () =>
|
|
parse(readFileSync('.github/workflows/pr.yml', 'utf8')).jobs.git_compatibility.steps
|
|
|
|
const stepNamed = (name) => gateSteps().find((step) => step.name === name)
|
|
|
|
describe('Git binary compatibility PR gate', () => {
|
|
it('runs the real-binary contract at each compatibility boundary', () => {
|
|
const run = stepNamed('Verify Git binary compatibility matrix')?.run
|
|
|
|
expect(run).toContain('ORCA_GIT_COMPAT_BINARY="$HOME/.cache/orca-git-compat/git-2.25.5/git"')
|
|
expect(run).toContain('alpine/git:edge-2.38.1|2.38.1')
|
|
expect(run).toContain('alpine/git:v2.49.1|2.49.1')
|
|
expect(run).toContain('ORCA_GIT_COMPAT_IMAGE="$image"')
|
|
expect(run).toContain('src/shared/git-binary-compatibility.test.ts')
|
|
expect(run).toContain('pids+=("$!")')
|
|
expect(run).toContain('wait "$pid" || status=1')
|
|
})
|
|
|
|
it('builds the pinned baseline tarball into the cached directory', () => {
|
|
const run = stepNamed('Build the baseline Git binary')?.run
|
|
|
|
expect(run).toContain('git-2.25.5.tar.gz')
|
|
// Why asserted: the sha256 check only runs on the build path, so a cached binary
|
|
// must come from a key that pins the same version the tarball line declares.
|
|
expect(run).toContain('if [ -x "$source/git" ]; then')
|
|
expect(run).toContain('41662c52fc16fec4963bfc41075e71f8ead6b5e386797eb6f9a1111ff95a8ddf')
|
|
expect(run).toContain('-j"$(nproc)"')
|
|
// The cached path and the build path must be the same directory or the guard
|
|
// above would rebuild on every run while still reporting a cache hit.
|
|
expect(run).toContain('source="$HOME/.cache/orca-git-compat/git-2.25.5"')
|
|
})
|
|
|
|
it('finishes the baseline build before the timed lanes start', () => {
|
|
const steps = gateSteps()
|
|
const names = steps.map((step) => step.name)
|
|
const cacheIndex = names.indexOf('Cache baseline Git build')
|
|
const buildIndex = names.indexOf('Build the baseline Git binary')
|
|
const matrixIndex = names.indexOf('Verify Git binary compatibility matrix')
|
|
|
|
expect(cacheIndex).toBeGreaterThanOrEqual(0)
|
|
expect(cacheIndex).toBeLessThan(buildIndex)
|
|
expect(buildIndex).toBeLessThan(matrixIndex)
|
|
// Why asserted: each lane is bounded by Vitest's per-test timeout while it waits on
|
|
// container starts, so a `make -j$(nproc)` sharing the runner shows up as a timeout
|
|
// in whichever boundary case is running rather than as a slow build.
|
|
expect(steps[matrixIndex].run).not.toContain('make -C')
|
|
expect(steps[cacheIndex].with.path).toBe(BASELINE_DIR)
|
|
expect(steps[cacheIndex].with.key).toContain('2.25.5')
|
|
})
|
|
|
|
it('pulls every matrix image before any lane runs', () => {
|
|
const run = stepNamed('Verify Git binary compatibility matrix')?.run
|
|
// A lazy pull inside one lane stalls whatever test the sibling lane is timing.
|
|
const [beforeLanes] = run.split('pids=()')
|
|
|
|
expect(beforeLanes).toContain('docker pull --quiet "${spec%%|*}"')
|
|
})
|
|
})
|