mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 08:03:22 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
124 lines
4.2 KiB
TypeScript
124 lines
4.2 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
|
|
import { execFileSync } from 'node:child_process'
|
|
import { existsSync, mkdtempSync, writeFileSync } from 'node:fs'
|
|
import * as fs from 'node:fs/promises'
|
|
import * as path from 'node:path'
|
|
import { tmpdir } from 'node:os'
|
|
import { RelayContext } from './context'
|
|
import { GitHandler } from './git-handler'
|
|
import {
|
|
createMockDispatcher,
|
|
type MockDispatcher,
|
|
type RelayDispatcher
|
|
} from './git-handler-test-setup'
|
|
|
|
describe('GitHandler pull reconciliation', () => {
|
|
let dispatcher: MockDispatcher
|
|
let tmpDir: string
|
|
let gitEnv: NodeJS.ProcessEnv
|
|
let previousGitConfigGlobal: string | undefined
|
|
let previousGitConfigNosystem: string | undefined
|
|
|
|
beforeEach(() => {
|
|
tmpDir = mkdtempSync(path.join(tmpdir(), 'relay-git-pull-reconciliation-'))
|
|
const globalGitConfigPath = path.join(tmpDir, 'global-gitconfig')
|
|
writeFileSync(globalGitConfigPath, '')
|
|
previousGitConfigGlobal = process.env.GIT_CONFIG_GLOBAL
|
|
previousGitConfigNosystem = process.env.GIT_CONFIG_NOSYSTEM
|
|
process.env.GIT_CONFIG_GLOBAL = globalGitConfigPath
|
|
process.env.GIT_CONFIG_NOSYSTEM = '1'
|
|
gitEnv = {
|
|
...process.env,
|
|
GIT_CONFIG_GLOBAL: globalGitConfigPath,
|
|
GIT_CONFIG_NOSYSTEM: '1'
|
|
}
|
|
dispatcher = createMockDispatcher()
|
|
const ctx = new RelayContext()
|
|
new GitHandler(dispatcher as unknown as RelayDispatcher, ctx)
|
|
})
|
|
|
|
afterEach(async () => {
|
|
restoreGitEnv('GIT_CONFIG_GLOBAL', previousGitConfigGlobal)
|
|
restoreGitEnv('GIT_CONFIG_NOSYSTEM', previousGitConfigNosystem)
|
|
await fs.rm(tmpDir, { recursive: true, force: true })
|
|
})
|
|
|
|
function execGit(cwd: string, args: string[]): string {
|
|
return execFileSync('git', args, {
|
|
cwd,
|
|
encoding: 'utf-8',
|
|
env: gitEnv,
|
|
stdio: 'pipe'
|
|
})
|
|
}
|
|
|
|
function configureIdentity(cwd: string): void {
|
|
execGit(cwd, ['config', 'user.email', 'test@test.com'])
|
|
execGit(cwd, ['config', 'user.name', 'Test'])
|
|
}
|
|
|
|
function commitAll(cwd: string, message: string): void {
|
|
execGit(cwd, ['add', '.'])
|
|
execGit(cwd, ['commit', '-m', message])
|
|
}
|
|
|
|
function createDivergentFixture(): string {
|
|
const bareDir = path.join(tmpDir, 'origin.git')
|
|
const consumerDir = path.join(tmpDir, 'consumer')
|
|
const producerDir = path.join(tmpDir, 'producer')
|
|
|
|
execGit(tmpDir, ['init', '--bare', bareDir])
|
|
execGit(tmpDir, ['clone', bareDir, consumerDir])
|
|
configureIdentity(consumerDir)
|
|
writeFileSync(path.join(consumerDir, 'base.txt'), 'base\n')
|
|
commitAll(consumerDir, 'initial')
|
|
execGit(consumerDir, ['push', '--set-upstream', 'origin', 'HEAD'])
|
|
|
|
execGit(tmpDir, ['clone', bareDir, producerDir])
|
|
configureIdentity(producerDir)
|
|
writeFileSync(path.join(producerDir, 'remote.txt'), 'remote\n')
|
|
commitAll(producerDir, 'remote')
|
|
execGit(producerDir, ['push'])
|
|
|
|
writeFileSync(path.join(consumerDir, 'local.txt'), 'local\n')
|
|
commitAll(consumerDir, 'local')
|
|
|
|
return consumerDir
|
|
}
|
|
|
|
it('explains how to configure a pull policy when divergent branches have no strategy', async () => {
|
|
const consumerDir = createDivergentFixture()
|
|
|
|
await expect(dispatcher.callRequest('git.pull', { worktreePath: consumerDir })).rejects.toThrow(
|
|
'Pull needs a Git pull policy for divergent branches. Configure one for this repository'
|
|
)
|
|
|
|
expect(execGit(consumerDir, ['status', '--short'])).toBe('')
|
|
}, 15_000)
|
|
|
|
it('preserves configured rebase pull semantics', async () => {
|
|
const consumerDir = createDivergentFixture()
|
|
execGit(consumerDir, ['config', 'pull.rebase', 'true'])
|
|
|
|
await expect(
|
|
dispatcher.callRequest('git.pull', { worktreePath: consumerDir })
|
|
).resolves.not.toThrow()
|
|
|
|
const parentRefs = execGit(consumerDir, ['log', '-1', '--pretty=%P']).trim().split(/\s+/)
|
|
expect(parentRefs).toHaveLength(1)
|
|
expect(existsSync(path.join(consumerDir, 'remote.txt'))).toBe(true)
|
|
expect(execGit(consumerDir, ['status', '--short'])).toBe('')
|
|
}, 15_000)
|
|
})
|
|
|
|
function restoreGitEnv(
|
|
name: 'GIT_CONFIG_GLOBAL' | 'GIT_CONFIG_NOSYSTEM',
|
|
value: string | undefined
|
|
): void {
|
|
if (value === undefined) {
|
|
delete process.env[name]
|
|
return
|
|
}
|
|
process.env[name] = value
|
|
}
|