Files
orca/src/main/codex/codex-state-db.test.ts
T
Jinwoo Hong a8ee94d0ac fix(codex): skip the hook trust RPC when Codex's session index is unreadable (#24604)
An unreadable state DB was read as 'not busy', so the trust grant ran a
short app-server RPC that can refresh an abandoned backfill lease. A
tri-state pending check lets the trust grant take its fallback, while other
callers keep their existing boolean behaviour.
2026-10-02 19:00:31 -04:00

139 lines
4.7 KiB
TypeScript

import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { afterEach, describe, expect, it, vi } from 'vitest'
import SyncDatabase from '../sqlite/sync-database'
import {
findNewestCodexStateDbPath,
isCodexStateDbBackfillPending,
readCodexStateDbBackfillPendingState,
readCodexStateDbBackfillStatus,
readIndexedCodexThreadIds
} from './codex-state-db'
const temporaryHomes: string[] = []
async function createHome(): Promise<string> {
const home = await mkdtemp(join(tmpdir(), 'orca-codex-state-db-'))
temporaryHomes.push(home)
return home
}
function createBackfillDb(home: string, version: number, status: string): string {
const path = join(home, `state_${version}.sqlite`)
const db = new SyncDatabase(path)
db.exec(
'CREATE TABLE backfill_state (id INTEGER PRIMARY KEY, status TEXT NOT NULL); ' +
`INSERT INTO backfill_state (id, status) VALUES (1, '${status}')`
)
db.close()
return path
}
afterEach(async () => {
await Promise.all(
temporaryHomes.splice(0).map((home) => rm(home, { recursive: true, force: true }))
)
})
describe('Codex state DB backfill status', () => {
it('reads the newest schema DB without mutating an incomplete row', async () => {
const home = await createHome()
createBackfillDb(home, 4, 'complete')
const newest = createBackfillDb(home, 5, 'running')
expect(findNewestCodexStateDbPath(home)).toBe(newest)
expect(readCodexStateDbBackfillStatus(home)).toEqual({
kind: 'incomplete',
stateDbPath: newest,
status: 'running'
})
const db = new SyncDatabase(newest, { readonly: true, fileMustExist: true })
expect(db.prepare('SELECT status FROM backfill_state WHERE id = 1').get()).toEqual({
status: 'running'
})
db.close()
})
it('treats a large unindexed rollout history as pending', async () => {
const home = await createHome()
const sessions = join(home, 'sessions', '2026', '08', '04')
await mkdir(sessions, { recursive: true })
await Promise.all(
Array.from({ length: 100 }, (_, index) =>
writeFile(join(sessions, `rollout-${index}.jsonl`), '{}\n')
)
)
expect(isCodexStateDbBackfillPending(home)).toBe(true)
})
it('counts compressed rollouts, which Codex also backfills', async () => {
const home = await createHome()
const sessions = join(home, 'sessions', '2026', '08', '04')
await mkdir(sessions, { recursive: true })
await Promise.all(
Array.from({ length: 100 }, (_, index) =>
writeFile(join(sessions, `rollout-${index}.jsonl.zst`), '')
)
)
expect(isCodexStateDbBackfillPending(home)).toBe(true)
})
it('does not call a complete backfill pending', async () => {
const home = await createHome()
createBackfillDb(home, 5, 'complete')
expect(isCodexStateDbBackfillPending(home)).toBe(false)
})
})
describe('readCodexStateDbBackfillPendingState', () => {
it('reports an unreadable index separately while the boolean stays not-pending', async () => {
const home = await createHome()
await writeFile(join(home, 'state_5.sqlite'), 'not a sqlite database')
expect(readCodexStateDbBackfillStatus(home).kind).toBe('unreadable')
expect(readCodexStateDbBackfillPendingState(home)).toBe('unreadable')
expect(isCodexStateDbBackfillPending(home)).toBe(false)
})
it('maps incomplete, complete and small unindexed homes', async () => {
const running = await createHome()
createBackfillDb(running, 5, 'running')
const complete = await createHome()
createBackfillDb(complete, 5, 'complete')
const empty = await createHome()
expect(readCodexStateDbBackfillPendingState(running)).toBe('pending')
expect(readCodexStateDbBackfillPendingState(complete)).toBe('not-pending')
expect(readCodexStateDbBackfillPendingState(empty)).toBe('not-pending')
})
})
describe('readIndexedCodexThreadIds', () => {
it('returns lower-cased thread ids from the newest state DB', async () => {
const home = await createHome()
const path = createBackfillDb(home, 5, 'complete')
const db = new SyncDatabase(path)
db.exec(
"CREATE TABLE threads (id TEXT PRIMARY KEY); INSERT INTO threads (id) VALUES ('ABC'), ('def')"
)
db.close()
expect(readIndexedCodexThreadIds(home)).toEqual(new Set(['abc', 'def']))
})
it('returns null when there is no state DB or no threads table', async () => {
const home = await createHome()
expect(readIndexedCodexThreadIds(home)).toBeNull()
createBackfillDb(home, 5, 'complete')
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
expect(readIndexedCodexThreadIds(home)).toBeNull()
warn.mockRestore()
})
})