mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
Jinjing
999e3a3a6d
* feat(sidebar): link Linear issues from Edit Worktree Details The Issue field only accepted GitHub numbers, so a workspace tracking a Linear issue had no way to say so from the dialog — the link could only be set at creation time or through `orca worktree set --linear-issue`. Replaces the field with one provider-aware row: a chip suffix inside the input selects GitHub or Linear, and pasting a URL flips the chip to match. A bare key never steers the provider — Linear and Jira issue keys are byte-identical in shape, so shape alone cannot decide one. One issue per workspace. A changed field displaces the other provider's slot and the row names what Save is about to unlink. GitLab and Jira links are left alone: the row cannot display them, and nothing else in the UI could restore one it dropped. - Folder workspaces read-only (their link is creation-time only) - Remote runtimes assert the capability before writing or clearing, since `worktree.set` parses in strip mode and would silently drop the keys - `updateWorktreeMeta` now reports failure so the dialog can stay open instead of closing over a save that refetch reverted - Parses are length-bounded — `matchGitHubItemPath` strips trailing slashes with an unanchored regex that is quadratic on a large paste * fix(sidebar): respect one-issue-per-workspace rule conditionally Only clear displaced issue links when they actually existed, preventing unnecessary Linear keys in GitHub-only workspaces. Skip comment updates when unchanged to avoid workspace reordering. Add accessibility to displacement messages and improve folder workspace error handling. * fix(sidebar): resolve workspace ambiguity and improve Linear issue linki The same workspace ID can exist under multiple hosts — the owner index reports this as ambiguous rather than guessing. Dialog callers now pass their repoId so lookups are unambiguous. Linear identifiers without an org key are resolved across all workspaces (not just the active organization). Added race-condition protection for async issue lookups and better change detection to avoid clearing work-item titles when re-saving an identifier in different spelling.
119 lines
4.2 KiB
TypeScript
119 lines
4.2 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { getIssueLinkProviderFromUrl, parseIssueLinkInput } from './issue-link-input'
|
|
|
|
describe('getIssueLinkProviderFromUrl', () => {
|
|
it('detects GitHub issue URLs', () => {
|
|
expect(getIssueLinkProviderFromUrl('https://github.com/o/r/issues/12')).toBe('github')
|
|
})
|
|
|
|
it('does not flip the provider for a GitHub pull URL', () => {
|
|
expect(getIssueLinkProviderFromUrl('https://github.com/o/r/pull/12')).toBeNull()
|
|
})
|
|
|
|
it('detects Linear issue URLs with and without a slug', () => {
|
|
expect(getIssueLinkProviderFromUrl('https://linear.app/acme/issue/STA-335')).toBe('linear')
|
|
expect(getIssueLinkProviderFromUrl('https://linear.app/acme/issue/STA-335/some-slug')).toBe(
|
|
'linear'
|
|
)
|
|
})
|
|
|
|
it('ignores non-issue paths on the Linear host', () => {
|
|
expect(getIssueLinkProviderFromUrl('https://linear.app/acme/team/ENG/all')).toBeNull()
|
|
})
|
|
|
|
it('rejects hosts that merely contain linear.app', () => {
|
|
expect(getIssueLinkProviderFromUrl('https://linear.app.evil.com/acme/issue/STA-335')).toBeNull()
|
|
})
|
|
|
|
// Linear and Jira issue-key shapes are byte-identical, so a bare key must
|
|
// never override the user's explicit provider choice.
|
|
it('is not decisive for bare issue keys', () => {
|
|
expect(getIssueLinkProviderFromUrl('STA-335')).toBeNull()
|
|
expect(getIssueLinkProviderFromUrl(' STA-335 ')).toBeNull()
|
|
})
|
|
|
|
it('is not decisive for bare numbers', () => {
|
|
expect(getIssueLinkProviderFromUrl('1234')).toBeNull()
|
|
expect(getIssueLinkProviderFromUrl('#1234')).toBeNull()
|
|
})
|
|
|
|
it('returns null for empty input', () => {
|
|
expect(getIssueLinkProviderFromUrl('')).toBeNull()
|
|
expect(getIssueLinkProviderFromUrl(' ')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('parseIssueLinkInput', () => {
|
|
describe('github provider', () => {
|
|
it('accepts bare and hash-prefixed numbers', () => {
|
|
expect(parseIssueLinkInput('12', 'github')).toEqual({ provider: 'github', number: 12 })
|
|
expect(parseIssueLinkInput('#12', 'github')).toEqual({ provider: 'github', number: 12 })
|
|
})
|
|
|
|
it('accepts issue URLs', () => {
|
|
expect(parseIssueLinkInput('https://github.com/o/r/issues/12', 'github')).toEqual({
|
|
provider: 'github',
|
|
number: 12
|
|
})
|
|
})
|
|
|
|
it('rejects pull URLs', () => {
|
|
expect(parseIssueLinkInput('https://github.com/o/r/pull/12', 'github')).toBeNull()
|
|
})
|
|
|
|
it('rejects non-positive numbers and junk', () => {
|
|
expect(parseIssueLinkInput('0', 'github')).toBeNull()
|
|
expect(parseIssueLinkInput('-1', 'github')).toBeNull()
|
|
expect(parseIssueLinkInput('not an issue', 'github')).toBeNull()
|
|
expect(parseIssueLinkInput(' ', 'github')).toBeNull()
|
|
})
|
|
|
|
it('rejects Linear identifiers', () => {
|
|
expect(parseIssueLinkInput('STA-335', 'github')).toBeNull()
|
|
})
|
|
|
|
// Past the safe-integer range every digit string parses to the same float,
|
|
// so an unbounded parse would link an arbitrary issue number.
|
|
it('rejects numbers beyond the safe-integer range', () => {
|
|
expect(parseIssueLinkInput('9'.repeat(400), 'github')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('linear provider', () => {
|
|
it('accepts bare identifiers and normalizes case', () => {
|
|
expect(parseIssueLinkInput('STA-335', 'linear')).toEqual({
|
|
provider: 'linear',
|
|
identifier: 'STA-335'
|
|
})
|
|
expect(parseIssueLinkInput('sta-335', 'linear')).toEqual({
|
|
provider: 'linear',
|
|
identifier: 'STA-335'
|
|
})
|
|
})
|
|
|
|
it('omits the organization key for bare identifiers', () => {
|
|
expect(parseIssueLinkInput('STA-335', 'linear')).not.toHaveProperty('organizationUrlKey')
|
|
})
|
|
|
|
it('accepts issue URLs and returns the organization key', () => {
|
|
expect(
|
|
parseIssueLinkInput('https://linear.app/acme/issue/STA-335/some-slug', 'linear')
|
|
).toEqual({
|
|
provider: 'linear',
|
|
identifier: 'STA-335',
|
|
organizationUrlKey: 'acme'
|
|
})
|
|
})
|
|
|
|
it('rejects GitHub URLs', () => {
|
|
expect(parseIssueLinkInput('https://github.com/o/r/issues/12', 'linear')).toBeNull()
|
|
})
|
|
|
|
it('rejects junk and empty input', () => {
|
|
expect(parseIssueLinkInput('not an issue', 'linear')).toBeNull()
|
|
expect(parseIssueLinkInput(' ', 'linear')).toBeNull()
|
|
})
|
|
})
|
|
})
|