mirror of
https://github.com/stablyai/orca.git
synced 2026-10-23 08:03:39 +00:00
* fix(checks): rank successful checks above skipped and neutral Checks were ordered with `skipped` (4) and `neutral` (3) ahead of `success` (5), so a PR with a long tail of skipped jobs pushed every passing check below the fold — you scroll past a wall of "Skipped" to find out whether anything actually ran. Rank the no-signal conclusions last (`success` 3, `neutral` 4, `skipped` 5) and pull the order out of its three duplicated copies (checks-panel-content, PullRequestPage, GitHubItemDialog) into `src/shared/pr-check-severity-order.ts`. Unknown conclusions now sink to the bottom instead of silently ranking as `neutral`. * fix(checks): look up check ranks through a Map, not an object literal An object-literal rank table resolves `constructor`, `toString`, and `__proto__` off Object.prototype, so those keys returned a function instead of falling through to UNKNOWN_CHECK_RANK — the comparator then subtracted functions, went NaN, and left the list in arbitrary order. Conclusions come from provider payloads, so keep the lookup on a Map and cover prototype property names in the test. * test(checks): cover provider-neutral ordering states * fix(checks): preserve actionable provider states * fix(checks): preserve unresolved provider rollups * fix(checks): keep unknown GitLab rollups neutral * fix: preserve neutral review check summaries * fix: complete provider-neutral check ordering remediation * fix: use provider-neutral mobile review status input * fix: hydrate GitLab mobile review status * fix: type mobile GitLab review hydration --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
149 lines
4.1 KiB
TypeScript
149 lines
4.1 KiB
TypeScript
import type { PRInfo, IssueInfo, CheckStatus, PRCheckDetail } from '../../shared/types'
|
|
import { derivePRCheckStatusFromRollup } from '../../shared/pr-check-status'
|
|
|
|
// ── REST API check-runs mapping ───────────────────────────────────────
|
|
// The REST check-runs endpoint returns separate status + conclusion fields
|
|
// (unlike gh pr checks which merges them into a single "state" string).
|
|
|
|
export function mapCheckRunRESTStatus(status: string): PRCheckDetail['status'] {
|
|
const s = status?.toLowerCase()
|
|
if (s === 'queued') {
|
|
return 'queued'
|
|
}
|
|
if (s === 'in_progress') {
|
|
return 'in_progress'
|
|
}
|
|
return 'completed'
|
|
}
|
|
|
|
const conclusionMap: Record<string, PRCheckDetail['conclusion']> = {
|
|
success: 'success',
|
|
failure: 'failure',
|
|
cancelled: 'cancelled',
|
|
timed_out: 'timed_out',
|
|
skipped: 'skipped',
|
|
neutral: 'neutral',
|
|
action_required: 'action_required',
|
|
stale: 'failure',
|
|
startup_failure: 'failure'
|
|
}
|
|
|
|
export function mapCheckRunRESTConclusion(
|
|
status: string,
|
|
conclusion: string | null
|
|
): PRCheckDetail['conclusion'] {
|
|
if (status?.toLowerCase() !== 'completed') {
|
|
return 'pending'
|
|
}
|
|
if (!conclusion) {
|
|
return null
|
|
}
|
|
return conclusionMap[conclusion.toLowerCase()] ?? null
|
|
}
|
|
|
|
// ── REST API commit status mapping ──────────────────────────────────────
|
|
// Legacy Jenkins/Prow integrations report commit statuses, not check runs.
|
|
|
|
export function mapCommitStatusRESTStatus(state: string): PRCheckDetail['status'] {
|
|
const s = state?.toLowerCase()
|
|
return s === 'pending' ? 'queued' : 'completed'
|
|
}
|
|
|
|
export function mapCommitStatusRESTConclusion(state: string): PRCheckDetail['conclusion'] {
|
|
const s = state?.toLowerCase()
|
|
if (s === 'success') {
|
|
return 'success'
|
|
}
|
|
if (s === 'failure' || s === 'error') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'pending') {
|
|
return 'pending'
|
|
}
|
|
return null
|
|
}
|
|
|
|
// ── gh pr checks mapping (single "state" string) ─────────────────────
|
|
|
|
export function mapCheckStatus(state: string): PRCheckDetail['status'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'PENDING' || s === 'QUEUED') {
|
|
return 'queued'
|
|
}
|
|
if (s === 'IN_PROGRESS') {
|
|
return 'in_progress'
|
|
}
|
|
return 'completed'
|
|
}
|
|
|
|
export function mapCheckConclusion(state: string): PRCheckDetail['conclusion'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'SUCCESS' || s === 'PASS') {
|
|
return 'success'
|
|
}
|
|
if (s === 'FAILURE' || s === 'FAIL') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'ACTION_REQUIRED') {
|
|
return 'action_required'
|
|
}
|
|
if (s === 'STALE' || s === 'STARTUP_FAILURE') {
|
|
return 'failure'
|
|
}
|
|
if (s === 'CANCELLED') {
|
|
return 'cancelled'
|
|
}
|
|
if (s === 'TIMED_OUT') {
|
|
return 'timed_out'
|
|
}
|
|
if (s === 'SKIPPED') {
|
|
return 'skipped'
|
|
}
|
|
if (s === 'PENDING' || s === 'QUEUED' || s === 'IN_PROGRESS') {
|
|
return 'pending'
|
|
}
|
|
if (s === 'NEUTRAL') {
|
|
return 'neutral'
|
|
}
|
|
return null
|
|
}
|
|
|
|
export function mapPRState(state: string, isDraft?: boolean): PRInfo['state'] {
|
|
const s = state?.toUpperCase()
|
|
if (s === 'MERGED') {
|
|
return 'merged'
|
|
}
|
|
if (s === 'CLOSED') {
|
|
return 'closed'
|
|
}
|
|
if (isDraft) {
|
|
return 'draft'
|
|
}
|
|
return 'open'
|
|
}
|
|
|
|
// ── Issue mapping ────────────────────────────────────────────────────
|
|
// REST API returns html_url + lowercase state; gh issue view returns url + mixed-case state.
|
|
// This helper normalises both shapes into IssueInfo.
|
|
|
|
export function mapIssueInfo(data: {
|
|
number: number
|
|
title: string
|
|
state: string
|
|
url?: string
|
|
html_url?: string
|
|
labels?: { name: string }[]
|
|
}): IssueInfo {
|
|
return {
|
|
number: data.number,
|
|
title: data.title,
|
|
state: data.state?.toLowerCase() === 'open' ? 'open' : 'closed',
|
|
url: data.html_url ?? data.url ?? '',
|
|
labels: (data.labels || []).map((l) => l.name)
|
|
}
|
|
}
|
|
|
|
export function deriveCheckStatus(rollup: unknown[] | null | undefined): CheckStatus {
|
|
return derivePRCheckStatusFromRollup(rollup)
|
|
}
|