mirror of
https://github.com/stablyai/orca.git
synced 2026-10-22 00:03:47 +00:00
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
120 lines
4.4 KiB
TypeScript
120 lines
4.4 KiB
TypeScript
import { ActivityIndicator, ScrollView, Text, View } from 'react-native'
|
|
import { colors } from '../../theme/mobile-theme'
|
|
import type { PRCheckRunDetails } from '../../../../src/shared/github/check-types'
|
|
import { presentCheckDetail, type CheckDetailJob } from './pr-check-detail-content'
|
|
import { mobilePrSidebarStyles as styles } from './mobile-pr-sidebar-styles'
|
|
|
|
// Per-check lazily-fetched detail. `loading`/`error` track the in-flight fetch;
|
|
// `details` (once set) is the cache so collapse/re-expand never re-fetches.
|
|
export type DetailEntry =
|
|
| { status: 'loading' }
|
|
| { status: 'error'; message: string }
|
|
| { status: 'loaded'; details: PRCheckRunDetails | null }
|
|
|
|
// Renders the expanded detail for one check: conclusion/title/summary, plus the
|
|
// annotations and failed-job/step summary from the github.prCheckDetails payload
|
|
// (parity with the desktop ChecksPanel detail). Muted/monochrome and scrollable
|
|
// so long CI output never breaks the sidebar layout.
|
|
export function PRCheckDetailView({ entry }: { entry: DetailEntry | undefined }) {
|
|
if (!entry || entry.status === 'loading') {
|
|
return (
|
|
<View style={styles.checkDetailArea}>
|
|
<ActivityIndicator color={colors.textSecondary} />
|
|
</View>
|
|
)
|
|
}
|
|
if (entry.status === 'error') {
|
|
return (
|
|
<View style={styles.checkDetailArea}>
|
|
<Text style={styles.checkDetailText}>{entry.message}</Text>
|
|
</View>
|
|
)
|
|
}
|
|
if (!entry.details) {
|
|
return (
|
|
<View style={styles.checkDetailArea}>
|
|
<Text style={styles.checkDetailText}>No details available.</Text>
|
|
</View>
|
|
)
|
|
}
|
|
|
|
const content = presentCheckDetail(entry.details)
|
|
const isEmpty =
|
|
content.summaryLines.length === 0 &&
|
|
content.annotations.length === 0 &&
|
|
content.jobs.length === 0
|
|
|
|
return (
|
|
<View style={styles.checkDetailArea}>
|
|
{isEmpty ? (
|
|
<Text style={styles.checkDetailText}>No details available.</Text>
|
|
) : (
|
|
<>
|
|
{content.summaryLines.map((line, index) => (
|
|
<Text key={index} style={styles.checkDetailText}>
|
|
{line}
|
|
</Text>
|
|
))}
|
|
{content.annotations.length > 0 ? (
|
|
<View style={styles.checkDetailGroup}>
|
|
<Text style={styles.checkDetailGroupLabel}>Annotations</Text>
|
|
{content.annotations.map((annotation, index) => (
|
|
<View key={index}>
|
|
<Text style={styles.checkDetailLocator} numberOfLines={1}>
|
|
{annotation.locator}
|
|
{annotation.level ? ` · ${annotation.level}` : ''}
|
|
</Text>
|
|
{annotation.title ? (
|
|
<Text style={styles.checkDetailEmphasis}>{annotation.title}</Text>
|
|
) : null}
|
|
<Text style={styles.checkDetailText}>{annotation.message}</Text>
|
|
</View>
|
|
))}
|
|
{content.annotationsTruncated ? (
|
|
<Text style={styles.checkDetailText}>Showing first 20 annotations</Text>
|
|
) : null}
|
|
</View>
|
|
) : null}
|
|
{content.jobs.length > 0 ? (
|
|
<View style={styles.checkDetailGroup}>
|
|
<Text style={styles.checkDetailGroupLabel}>{content.jobsLabel}</Text>
|
|
{content.jobs.map((job, index) => (
|
|
<JobRow key={index} job={job} />
|
|
))}
|
|
{content.jobsTruncated ? (
|
|
<Text style={styles.checkDetailText}>Showing first 100 jobs</Text>
|
|
) : null}
|
|
</View>
|
|
) : null}
|
|
</>
|
|
)}
|
|
</View>
|
|
)
|
|
}
|
|
|
|
function JobRow({ job }: { job: CheckDetailJob }) {
|
|
return (
|
|
<View>
|
|
<View style={styles.checkDetailStepRow}>
|
|
<Text style={styles.checkDetailEmphasis} numberOfLines={1}>
|
|
{job.name}
|
|
</Text>
|
|
<Text style={styles.checkDetailText}>{job.state}</Text>
|
|
</View>
|
|
{job.failedSteps.map((step, index) => (
|
|
<View key={index} style={styles.checkDetailStepRow}>
|
|
<Text style={styles.checkDetailText} numberOfLines={1}>
|
|
{step.name}
|
|
</Text>
|
|
<Text style={styles.checkDetailText}>{step.state}</Text>
|
|
</View>
|
|
))}
|
|
{job.logTail ? (
|
|
<ScrollView style={styles.checkDetailLogScroll} nestedScrollEnabled>
|
|
<Text style={styles.checkDetailLogText}>{job.logTail}</Text>
|
|
</ScrollView>
|
|
) : null}
|
|
</View>
|
|
)
|
|
}
|