Files
orca/mobile/src/components/pr-sidebar/PRReviewersSection.tsx
T
Neil 77f23b013f refactor(shared): drop the shared/types barrel and import from the real modules (#14447)
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as
a re-export barrel so the import sites did not have to change. This removes
the barrel: every consumer now imports from the module that actually declares
the type, and `src/shared/types.ts` is deleted.

Barrels hide where a type lives, make every consumer look like it depends on
the whole domain, and let an unrelated edit invalidate a module that ~2,000
files transitively import.

2,323 import declarations across 2,321 files. Rewritten mechanically: each
specifier was resolved to an absolute path via the TypeScript AST and
recomputed, rather than string-substituted, so alias forms (`@/../../shared/
types`) and per-specifier `type` modifiers survive.

Four cases the mechanical pass had to handle, each found by a gate rather than
by reading the diff:

- Modules inside `src/shared` import the barrel as `./types`, not
  `shared/types`. A pre-filter on the latter string skipped 176 of them and
  left imports dangling at a deleted file, which surfaced as confusing
  `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>`
  errors rather than "module not found".
- The barrel RENAMED one type on the way through
  (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name
  in the owning module has to be re-aliased at each consumer.
- Three test files put `;(globalThis as ...)` on the line after the import.
  TypeScript parses that `;` as the import statement's terminator, so
  replacing through `statement.getEnd()` deletes it and breaks ASI. The
  rewrite now stops at the module specifier.
- A file that already imported directly from a module got a SECOND import
  from it, because the barrel re-exported those same names — which trips
  `import/no-duplicates` under `--deny-warnings`. A post-pass merges
  declarations sharing a specifier and type-only-ness; the `import type` plus
  `import` pair from one module is left alone, since that form is allowed.

Splitting one barrel import into several genuinely adds lines, which pushed
`terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character
import must wrap, and neither local type collapses onto one line (101 and 116
characters). Rather than contort a type declaration to fit a line budget,
`collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` —
they are pure structural operations on the layout tree and independent of PTY
ownership. `visible-worktrees.ts` similarly loses its own mini-barrel
re-export of `isDefaultBranchWorkspace`, with the four real consumers
repointed at the declaring module. No `max-lines` bypass added.

Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted
first — these projects are `composite: true` and reuse stale caches); the full
`pnpm lint` green, not just bare oxlint — the narrower local check is what let
the duplicate imports reach CI; max-lines ratchet OK at 344.
2026-08-13 22:48:24 -07:00

131 lines
5.2 KiB
TypeScript

import { useMemo, useState } from 'react'
import { ActivityIndicator, Pressable, Text, View } from 'react-native'
import { UserPlus, X } from 'lucide-react-native'
import { colors } from '../../theme/mobile-theme'
import type { GitHubWorkItemDetails } from '../../../../src/shared/github/work-item-types'
import type { RpcClient } from '../../transport/rpc-client'
import type { MobilePrActions } from '../../session/use-mobile-pr-actions'
import { isPrSidebarDetailsPlaceholder } from '../../session/mobile-pr-sidebar-state'
import { getPRReviewerRows } from './pr-checks-presentation'
import { ReviewerPickerDrawer } from './ReviewerPickerDrawer'
import { PRSection } from './PRSection'
import { mobilePrSidebarStyles as styles } from './mobile-pr-sidebar-styles'
type Props = {
details: GitHubWorkItemDetails | null
actions: MobilePrActions
client: RpcClient | null
worktreeId: string
}
// Requested reviewers + their latest review status, with a picker to request /
// remove (optimistic add/remove via the actions hook).
export function PRReviewersSection({ details, actions, client, worktreeId }: Props) {
// details === null means phase 2 (work-item payload) is still in flight — same
// signal Comments uses. Do not treat that as "no reviewers" or the section goes
// blank while checks (phase 1) already paint. A synthetic placeholder means
// phase 2 failed (no body/comments/reviews landed).
const loadingDetails = details === null
const detailsFailed = details != null && isPrSidebarDetailsPlaceholder(details)
const authoritativeRows = useMemo(
() =>
details?.item && !isPrSidebarDetailsPlaceholder(details)
? getPRReviewerRows(details.item)
: [],
[details]
)
const [pickerOpen, setPickerOpen] = useState(false)
// The authoritative requested-set drives optimistic resolution; an optimistic
// add can surface a login not yet in authoritativeRows.
const authoritativeRequested = useMemo(
() => new Set(authoritativeRows.map((r) => r.login.toLowerCase())),
[authoritativeRows]
)
const isRequested = (login: string): boolean =>
actions.resolveReviewerRequested(login, authoritativeRequested.has(login.toLowerCase()))
// Render rows = authoritative rows whose optimistic membership is still true.
// An optimistic add of a brand-new login surfaces in the row list only after
// refetch supplies it authoritatively; until then the picker's check reflects it.
const rows = authoritativeRows.filter((r) => isRequested(r.login))
const seededLogins = useMemo(() => {
const logins = authoritativeRows.map((r) => r.login)
const author = details?.item?.author
return author ? [author, ...logins] : logins
}, [authoritativeRows, details])
const addButton = (
<Pressable
style={styles.iconButton}
onPress={() => setPickerOpen(true)}
accessibilityRole="button"
accessibilityLabel="Add or remove reviewers"
>
<UserPlus size={16} color={colors.textSecondary} strokeWidth={2.2} />
</Pressable>
)
return (
<PRSection title="Reviewers" trailing={addButton}>
{loadingDetails ? (
<View style={styles.reviewersStatus}>
<ActivityIndicator color={colors.textSecondary} />
<Text style={styles.emptyText}>Loading reviewers…</Text>
</View>
) : detailsFailed ? (
<Text style={styles.emptyText}>Could not load reviewers. Tap refresh to try again.</Text>
) : rows.length === 0 ? (
<Text style={styles.emptyText}>No reviewers requested</Text>
) : (
rows.map((row) => {
const busy = actions.isBusy({ kind: 'reviewer', login: row.login })
return (
<View key={row.login} style={styles.row}>
<View style={styles.rowMain}>
<Text style={styles.rowTitle} numberOfLines={1}>
{row.name ? `${row.name} (${row.login})` : row.login}
</Text>
</View>
{/* Neutral gray like the desktop PR page (the label text carries the
state); keeps the sidebar mostly monochrome. */}
<Text style={[styles.rowStatus, { color: colors.textSecondary }]}>
{row.stateLabel}
</Text>
<Pressable
style={styles.rowTrailing}
onPress={() => actions.removeReviewer(row.login)}
disabled={busy}
accessibilityRole="button"
accessibilityLabel={`Remove ${row.login}`}
>
{busy ? (
<ActivityIndicator color={colors.textSecondary} />
) : (
<X size={14} color={colors.textSecondary} strokeWidth={2.2} />
)}
</Pressable>
</View>
)
})
)}
<ReviewerPickerDrawer
visible={pickerOpen}
onClose={() => setPickerOpen(false)}
client={client}
worktreeId={worktreeId}
seededLogins={seededLogins}
isRequested={isRequested}
onToggle={(login) => {
if (isRequested(login)) {
actions.removeReviewer(login)
} else {
actions.requestReviewer(login)
}
}}
/>
</PRSection>
)
}