mirror of
https://github.com/stablyai/orca.git
synced 2026-10-23 16:03:49 +00:00
Neil
532722d612
Round 10 concluded the tabGroups/tabGroupLayouts/activeGroupIdByWorktree folds were dead because short-circuiting them left the E2E green. That was true only of the E2E's shape — one group, one active tab, no split. Hydrating a real session both ways shows four things adoptGrouplessTabs cannot reconstruct: the multi-group split arrangement with its direction and ratio, the user's tabOrder (it degrades to sortOrder), which group and tab were focused, and the Ctrl+Tab MRU. And buildHydratedTabState takes the unified path only when tabGroups is present, so dropping the fold sends the upgrade cohort down the legacy hydration path entirely. The comment now says what they preserve instead of a rationale that was disproved. Also records the known asymmetry — tabGroups is whole-record local-wins while unifiedTabs is now per-tab — as a follow-up: same shape as the unified-ledger defect but with a soft landing (wrong group and order rather than invisible). And states plainly in the spec what it does NOT prove: 'every pane attached' covers only the ACTIVE tab, and a bare shell count cannot distinguish reuse from kill-and-respawn. A verified strengthening patch exists but its [data-tab-id] locator does not resolve in this tree; left as follow-up rather than landed red.