Files
orca/tests
24da434aff fix(sidebar): let a row click hand typing to the opened terminal again (#42806)
* fix(sidebar): let a row click hand typing to the opened terminal again

Since 1.4.259 a plain click on a workspace row parked keyboard focus on the
sidebar list and marked it as keyboard navigation, so terminal and chat focus
requests yielded and typing went nowhere until a second click (STA-15458).
The same stale mark also swallowed explicit focus requests such as
`orca terminal switch`, which reported success (STA-15415).

- Only a modifier click (multi-select) claims list focus; a plain click
  hands keys to the opened workspace's terminal or chat.
- Any pointer press ends list keyboard navigation again, so a click after
  arrow keys or a modifier click, and agent-row clicks, also hand focus off.
- The focus-list shortcut marks keyboard navigation so a terminal that
  finishes mounting afterwards cannot take the keys back.
- Explicit pane focus requests (CLI/notification focus, agent rows) end
  sidebar list navigation before focusing.

The delete shortcut still acts only on sidebar-selected rows while the list
has keyboard focus, and never on a hovered row.

Co-authored-by: Pr1p <48266347+Pr1p@users.noreply.github.com>
Co-authored-by: Pranav Tomar <43115768+Mystery01092000@users.noreply.github.com>

* test: give the sidebar focus fixture rows aria-selected

* fix(sidebar): re-clicking the open workspace row hands its terminal the keys

---------

Co-authored-by: Pr1p <48266347+Pr1p@users.noreply.github.com>
Co-authored-by: Pranav Tomar <43115768+Mystery01092000@users.noreply.github.com>
2026-11-15 16:52:43 -05:00
..