mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
Keeps a fork issue’s details, metadata and edits bound to the repository the user opened, including same-number issues in fork and upstream. Repairs selected-assignee leakage and delayed failed edits repainting another issue. Fixes #24378 Incorporates and cross-reviews contributor PR #24379, including its source-resolver correction and regression material. Covers the contributor PR’s Project-row identity and retained-dialog mutation findings. The final published head passes focused tests, hidden macOS rendering and current CI; the callback-timing bot thread has an evidence-based response. Co-authored-by: Katsuma Takehisa <k.takehisa@nissogr.com>
267 lines
8.1 KiB
TypeScript
267 lines
8.1 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const mocks = await vi.hoisted(async () => {
|
|
const { createGitHubIpcMocks } = await import('./github-ipc-module-mocks')
|
|
return createGitHubIpcMocks()
|
|
})
|
|
|
|
vi.mock('electron', () => mocks.electron)
|
|
vi.mock('../github/client', () => mocks.client)
|
|
vi.mock('../github/work-item-details', () => mocks.workItemDetails)
|
|
vi.mock('../github/pr-refresh-coordinator', () => mocks.prRefresh)
|
|
vi.mock('../telemetry/client', () => mocks.telemetry)
|
|
vi.mock('../telemetry/cohort-classifier', () => mocks.cohort)
|
|
vi.mock('./ui', () => mocks.ui)
|
|
|
|
import { registerGitHubHandlers } from './github'
|
|
import { createGitHubIpcHarness } from './github-ipc-test-harness'
|
|
|
|
const {
|
|
listIssues: listIssuesMock,
|
|
listWorkItems: listWorkItemsMock,
|
|
getWorkItem: getWorkItemMock
|
|
} = mocks.client
|
|
const { getWorkItemDetails: getWorkItemDetailsMock } = mocks.workItemDetails
|
|
|
|
describe('registerGitHubHandlers', () => {
|
|
const harness = createGitHubIpcHarness(mocks)
|
|
const { handlers, store, stats } = harness
|
|
|
|
beforeEach(harness.reset)
|
|
|
|
it('drops the error field from listIssues envelope at the IPC boundary', async () => {
|
|
// Why: src/main/ipc/github.ts intentionally unwraps the { items, error? }
|
|
// envelope to just `items` to preserve the pre-feature-1
|
|
// `Promise<IssueInfo[]>` contract for `gh:listIssues`. Feature 1's UI
|
|
// consumes the richer envelope through `gh:listWorkItems` instead. This
|
|
// test locks in that intentional drop so a future change that starts
|
|
// propagating the error through this channel (or that throws when an
|
|
// error is present) is caught.
|
|
listIssuesMock.mockResolvedValue({
|
|
items: [],
|
|
error: {
|
|
type: 'permission_denied',
|
|
message:
|
|
"You don't have permission to read issues for this repository. Check your GitHub token scopes."
|
|
}
|
|
})
|
|
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
const result = await handlers['gh:listIssues'](null, {
|
|
repoPath: '/workspace/repo',
|
|
limit: 5
|
|
})
|
|
|
|
expect(listIssuesMock).toHaveBeenCalledWith('/workspace/repo', 5, undefined, null)
|
|
expect(result).toEqual([])
|
|
})
|
|
|
|
it('threads issueSourcePreference through gh:listIssues', async () => {
|
|
// Why: repo.issueSourcePreference must reach listIssues so the upstream
|
|
// repo is queried when configured. A regression that drops the arg would
|
|
// pass the default-fixture tests (which assert `undefined`) silently, so
|
|
// this test pins the non-undefined preference-threading contract.
|
|
harness.repos[0].issueSourcePreference = 'upstream'
|
|
listIssuesMock.mockResolvedValue({ items: [] })
|
|
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
await handlers['gh:listIssues'](null, {
|
|
repoPath: '/workspace/repo',
|
|
limit: 5
|
|
})
|
|
|
|
expect(listIssuesMock).toHaveBeenCalledWith('/workspace/repo', 5, 'upstream', null)
|
|
})
|
|
|
|
it('threads issueSourcePreference through gh:listWorkItems', async () => {
|
|
// Why: gh:listWorkItems must also forward repo.issueSourcePreference
|
|
// (5th arg) so the work-items view honors the per-repo source selector.
|
|
harness.repos[0].issueSourcePreference = 'origin'
|
|
listWorkItemsMock.mockResolvedValue({ items: [] })
|
|
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
await handlers['gh:listWorkItems'](null, {
|
|
repoPath: '/workspace/repo',
|
|
limit: 10,
|
|
query: 'is:open',
|
|
page: 2,
|
|
noCache: true
|
|
})
|
|
|
|
expect(listWorkItemsMock).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
10,
|
|
'is:open',
|
|
2,
|
|
'origin',
|
|
null,
|
|
true
|
|
)
|
|
})
|
|
|
|
// Why: open-by-number must pin the same source the list uses, else a fork and
|
|
// its upstream sharing PR #42 open different PRs from the same click.
|
|
it('pins the repo origin source preference on work item and details IPC', async () => {
|
|
harness.repos = [
|
|
{
|
|
id: 'repo-1',
|
|
path: '/workspace/repo',
|
|
displayName: 'repo',
|
|
badgeColor: '#000',
|
|
addedAt: 0,
|
|
issueSourcePreference: 'origin'
|
|
}
|
|
]
|
|
getWorkItemMock.mockResolvedValue(null)
|
|
getWorkItemDetailsMock.mockResolvedValue(null)
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
await handlers['gh:workItem'](null, { repoPath: '/workspace/repo', number: 42, type: 'pr' })
|
|
await handlers['gh:workItemDetails'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 42,
|
|
type: 'pr'
|
|
})
|
|
|
|
expect(getWorkItemMock).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
42,
|
|
'pr',
|
|
null,
|
|
undefined,
|
|
'origin'
|
|
)
|
|
expect(getWorkItemDetailsMock).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
42,
|
|
'pr',
|
|
null,
|
|
undefined,
|
|
'origin'
|
|
)
|
|
})
|
|
|
|
it('passes the displayed repository ahead of the current source preference', async () => {
|
|
harness.repos[0].issueSourcePreference = 'upstream'
|
|
const ownerRepo = { owner: 'fork-owner', repo: 'widgets', host: 'github.com' }
|
|
mocks.client.updateIssue.mockResolvedValue({ ok: false, error: 'stub' })
|
|
getWorkItemDetailsMock.mockResolvedValue(null)
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: These fixtures implement the repo methods used by the handlers; unrelated handlers are only registered.
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
await handlers['gh:workItemDetails'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 12,
|
|
type: 'issue',
|
|
ownerRepo
|
|
})
|
|
await handlers['gh:updateIssue'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 12,
|
|
updates: { body: 'Origin edit' },
|
|
ownerRepo
|
|
})
|
|
await handlers['gh:listLabels'](null, { repoPath: '/workspace/repo', ownerRepo })
|
|
await handlers['gh:listAssignableUsers'](null, { repoPath: '/workspace/repo', ownerRepo })
|
|
|
|
expect(getWorkItemDetailsMock).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
12,
|
|
'issue',
|
|
null,
|
|
undefined,
|
|
'upstream',
|
|
ownerRepo
|
|
)
|
|
expect(mocks.client.updateIssue).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
12,
|
|
{ body: 'Origin edit' },
|
|
null,
|
|
undefined,
|
|
'upstream',
|
|
ownerRepo
|
|
)
|
|
expect(mocks.client.listLabels).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
'upstream',
|
|
null,
|
|
undefined,
|
|
ownerRepo
|
|
)
|
|
expect(mocks.client.listAssignableUsers).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
'upstream',
|
|
null,
|
|
undefined,
|
|
ownerRepo
|
|
)
|
|
})
|
|
|
|
it('pins the repo origin source preference on issue update and comment IPC', async () => {
|
|
harness.repos = [
|
|
{
|
|
id: 'repo-1',
|
|
path: '/workspace/repo',
|
|
displayName: 'repo',
|
|
badgeColor: '#000',
|
|
addedAt: 0,
|
|
issueSourcePreference: 'origin'
|
|
}
|
|
]
|
|
mocks.client.updateIssue.mockResolvedValue({ ok: false, error: 'stub' })
|
|
mocks.client.addIssueComment.mockResolvedValue({ ok: false, error: 'stub' })
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: These fixtures implement the repo methods used by the handlers; unrelated handlers are only registered.
|
|
registerGitHubHandlers(store as never, stats as never)
|
|
|
|
await handlers['gh:updateIssue'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 5,
|
|
updates: { body: 'Updated' }
|
|
})
|
|
await handlers['gh:addIssueComment'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 5,
|
|
body: 'Issue comment'
|
|
})
|
|
await handlers['gh:addIssueComment'](null, {
|
|
repoPath: '/workspace/repo',
|
|
number: 6,
|
|
body: 'PR comment',
|
|
type: 'pr'
|
|
})
|
|
|
|
expect(mocks.client.updateIssue).toHaveBeenCalledWith(
|
|
'/workspace/repo',
|
|
5,
|
|
{ body: 'Updated' },
|
|
null,
|
|
undefined,
|
|
'origin'
|
|
)
|
|
expect(mocks.client.addIssueComment).toHaveBeenNthCalledWith(
|
|
1,
|
|
'/workspace/repo',
|
|
5,
|
|
'Issue comment',
|
|
null,
|
|
null,
|
|
undefined,
|
|
'origin'
|
|
)
|
|
expect(mocks.client.addIssueComment).toHaveBeenNthCalledWith(
|
|
2,
|
|
'/workspace/repo',
|
|
6,
|
|
'PR comment',
|
|
null,
|
|
null,
|
|
undefined,
|
|
undefined
|
|
)
|
|
})
|
|
})
|