Files
orca/src/main/ipc/filesystem-git-commit-dispatch.test.ts
T
OrcaWinandm4air c5224f70d8 refactor(providers): delete the SSH git and filesystem providers and relay-only wiring (#27644)
* refactor(providers): delete the SSH git and filesystem providers and relay-only wiring

* refactor(ssh): drop relay-protocol exports only the deleted stream readers used

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
2026-10-11 17:48:43 -07:00

283 lines
9.6 KiB
TypeScript

import path from 'node:path'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import * as gitRunner from '../git/runner'
import {
handlers,
store,
WORKTREE_FEATURE_PATH,
commitChangesMock,
resolveCommitMessageSettingsMock,
generatePullRequestFieldsFromContextMock,
getPullRequestDraftContextMock,
resolveHostedReviewBodyForGenerationMock,
loadPullRequestLinkedIssueMock,
resetFilesystemIpcMocks
} from './filesystem-test-harness'
vi.mock('electron', async () => (await import('./filesystem-test-harness')).electronMock)
vi.mock('fs/promises', async () => (await import('./filesystem-test-harness')).fsPromisesMock)
vi.mock(
'../wsl-unc-delete',
async () => (await import('./filesystem-test-harness')).wslUncDeleteMock
)
vi.mock(
'../crash-reporting/crash-breadcrumb-store',
async () => (await import('./filesystem-test-harness')).crashBreadcrumbMock
)
vi.mock(
'../git/status',
async () => (await import('./filesystem-test-harness')).gitStatusModuleMock
)
vi.mock(
'../git/check-ignored-paths',
async () => (await import('./filesystem-test-harness')).gitIgnoredPathsMock
)
vi.mock('../git/worktree', async () => (await import('./filesystem-test-harness')).gitWorktreeMock)
vi.mock(
'../providers/ssh-filesystem-dispatch',
async () => (await import('./filesystem-test-harness')).sshFilesystemDispatchMock
)
vi.mock(
'../text-generation/commit-message-text-generation',
async () => (await import('./filesystem-test-harness')).textGenerationModuleMock
)
vi.mock(
'../text-generation/pull-request-context',
async () => (await import('./filesystem-test-harness')).pullRequestContextMock
)
vi.mock(
'../source-control/pull-request-template',
async () => (await import('./filesystem-test-harness')).pullRequestTemplateMock
)
vi.mock(
'../source-control/pull-request-linked-issue',
async () => (await import('./filesystem-test-harness')).pullRequestLinkedIssueMock
)
import { registerFilesystemHandlers } from './filesystem'
import { invalidateAuthorizedRootsCache } from './registered-worktree-roots-cache'
import { SSH_HOST_NOT_SERVED_MESSAGE } from '../providers/ssh-host-not-served-error'
describe('registerFilesystemHandlers', () => {
beforeEach(() => {
resetFilesystemIpcMocks()
// Reset module-level auth cache so each test starts with a fresh dirty
// flag — prevents stale worktree data from a prior test's cache rebuild.
invalidateAuthorizedRootsCache()
})
it('routes local git:commit through commitChanges and returns success', async () => {
commitChangesMock.mockResolvedValue({ success: true })
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:commit')!(null, {
worktreePath: WORKTREE_FEATURE_PATH,
message: 'feat: ship commit'
})
).resolves.toEqual({ success: true })
expect(commitChangesMock).toHaveBeenCalledWith(WORKTREE_FEATURE_PATH, 'feat: ship commit', {
admissionTier: 'interactive'
})
})
it('refuses ssh git:commit as not served instead of running local commitChanges', async () => {
const sshCommitMock = vi.fn().mockResolvedValue({ success: true })
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:commit')!(null, {
worktreePath: '/remote/repo',
message: 'feat: remote commit',
connectionId: 'conn-1'
})
).rejects.toThrow(
'Remote connection dropped. Click Reconnect on the SSH target before retrying.'
)
expect(sshCommitMock).not.toHaveBeenCalled()
expect(commitChangesMock).not.toHaveBeenCalled()
})
it('rejects git:remoteCommitUrl with a short hash before SSH dispatch', async () => {
const sshRemoteCommitUrlMock = vi.fn()
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:remoteCommitUrl')!(null, {
worktreePath: '/remote/repo',
sha: 'abc123',
connectionId: 'conn-1'
})
).rejects.toThrow('sha must be a full git object id')
expect(sshRemoteCommitUrlMock).not.toHaveBeenCalled()
})
it('rejects git:commit with whitespace-only message and does not call commitChanges', async () => {
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:commit')!(null, {
worktreePath: WORKTREE_FEATURE_PATH,
message: ' '
})
).rejects.toThrow('Commit message is required')
expect(commitChangesMock).not.toHaveBeenCalled()
})
it('rejects git:commit with whitespace-only message before SSH dispatch', async () => {
const sshCommitMock = vi.fn().mockResolvedValue({ success: true })
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:commit')!(null, {
worktreePath: '/remote/repo',
message: '\n',
connectionId: 'conn-1'
})
).rejects.toThrow('Commit message is required')
expect(sshCommitMock).not.toHaveBeenCalled()
})
})
describe('registerFilesystemHandlers pull request field generation', () => {
beforeEach(() => {
resetFilesystemIpcMocks()
// Reset module-level auth cache so each test starts with a fresh dirty
// flag — prevents stale worktree data from a prior test's cache rebuild.
invalidateAuthorizedRootsCache()
})
describe('git:generatePullRequestFields linked issue', () => {
const PULL_REQUEST_CONTEXT = {
base: 'main',
branch: 'feature/ai',
branchChangedByPreparation: false,
commitSummary: 'a1b2c3d Add generation',
changeSummary: 'README.md | 2 +-',
patch: '+hello',
currentTitle: '',
currentBody: '',
currentDraft: false
}
const PULL_REQUEST_ARGS = { base: 'main', title: '', body: '', draft: false }
const params = { agentId: 'codex', model: 'gpt-5.4-mini' }
beforeEach(() => {
resolveCommitMessageSettingsMock.mockReturnValue({ ok: true, params })
resolveHostedReviewBodyForGenerationMock.mockResolvedValue('')
getPullRequestDraftContextMock.mockResolvedValue(PULL_REQUEST_CONTEXT)
generatePullRequestFieldsFromContextMock.mockResolvedValue({ success: true, fields: {} })
})
it('enriches the local pull-request context with a validated worktree linked issue', async () => {
const worktreeId = `repo-1::${WORKTREE_FEATURE_PATH}`
const linkedIssueDetails = {
provider: 'github',
number: 123,
title: 'Improve PR generation',
description: 'Include issue context.'
}
loadPullRequestLinkedIssueMock.mockResolvedValue(linkedIssueDetails)
const linkedStore = {
...store,
getWorktreeMeta: (id: string) => (id === worktreeId ? { linkedIssue: 123 } : undefined)
}
registerFilesystemHandlers(linkedStore as never)
await handlers.get('git:generatePullRequestFields')!(null, {
...PULL_REQUEST_ARGS,
worktreePath: WORKTREE_FEATURE_PATH,
worktreeId,
provider: 'github'
})
expect(generatePullRequestFieldsFromContextMock).toHaveBeenCalledWith(
{
...PULL_REQUEST_CONTEXT,
linkedIssue: 123,
provider: 'github',
linkedIssueDetails
},
params,
expect.objectContaining({ kind: 'local' })
)
})
it('refuses SSH pull-request generation as not served without preparing a local branch', async () => {
registerFilesystemHandlers(store as never)
await expect(
handlers.get('git:generatePullRequestFields')!(null, {
...PULL_REQUEST_ARGS,
worktreePath: '/remote/repo',
connectionId: 'conn-1'
})
).resolves.toEqual({ success: false, error: SSH_HOST_NOT_SERVED_MESSAGE })
expect(getPullRequestDraftContextMock).not.toHaveBeenCalled()
expect(loadPullRequestLinkedIssueMock).not.toHaveBeenCalled()
})
it('ignores a pull-request worktree id that does not own the requested path', async () => {
const getWorktreeMeta = vi.fn(() => ({ linkedIssue: 123 }))
registerFilesystemHandlers({ ...store, getWorktreeMeta } as never)
await handlers.get('git:generatePullRequestFields')!(null, {
...PULL_REQUEST_ARGS,
worktreePath: WORKTREE_FEATURE_PATH,
worktreeId: `repo-1::${path.resolve('/workspace/repo-other')}`
})
expect(getWorktreeMeta).not.toHaveBeenCalled()
// Why: without the length guard the property assertion passes vacuously on `undefined`,
// so an unrelated early return would read as "enrichment correctly suppressed".
expect(generatePullRequestFieldsFromContextMock.mock.calls).toHaveLength(1)
expect(generatePullRequestFieldsFromContextMock.mock.calls[0]?.[0]).not.toHaveProperty(
'linkedIssue'
)
})
it('forwards PR-context command limits through the local adapter', async () => {
const localGitExec = vi
.spyOn(gitRunner, 'gitExecFileAsync')
.mockResolvedValue({ stdout: '', stderr: '' })
getPullRequestDraftContextMock.mockImplementation(async (execute) => {
await execute(['show-ref', '--verify'], { maxBuffer: 123, timeoutMs: 456 })
await execute(['legacy-probe'], { timeout: 789 })
return PULL_REQUEST_CONTEXT
})
try {
registerFilesystemHandlers(store as never)
await handlers.get('git:generatePullRequestFields')!(null, {
...PULL_REQUEST_ARGS,
worktreePath: WORKTREE_FEATURE_PATH
})
expect(localGitExec).toHaveBeenCalledWith(['show-ref', '--verify'], {
cwd: WORKTREE_FEATURE_PATH,
maxBuffer: 123,
timeout: 456
})
expect(localGitExec).toHaveBeenCalledWith(['legacy-probe'], {
cwd: WORKTREE_FEATURE_PATH,
timeout: 789
})
} finally {
localGitExec.mockRestore()
}
})
})
})