mirror of
https://github.com/stablyai/orca.git
synced 2026-10-22 16:03:47 +00:00
Neil
a74c124712
One conflict, and it was structural rather than textual: main split ssh-connection.test.ts from 2904 lines into seventeen files with a shared harness and fixtures (#14728), taking it off the max-lines suppression list, while this branch had added host key verification tests to the old monolith. Resolved by adopting main's split rather than reinstating the big file, since restoring it would put back the suppression the refactor just removed. The seven host key tests move to ssh-connection-host-key-verification.test.ts unchanged, including their comments — they are the reasoning, not decoration. The load-bearing piece was the ssh2 mock, which now lives in the shared harness and is therefore used by all seventeen files. It has to keep the callback form: ssh2 calls hostVerifier(key, verify) and only accepts synchronously when the return is not undefined, so the old single-argument mock would pass against a verifier that never decides — exactly the regression this work exists to prevent. It also has to abort on denial, or a refused key looks like a successful connect. Defaulting the presented key to a valid ed25519 blob keeps the other sixteen files unaffected, which the full run confirms: 1549 passed, 13 skipped, zero failures, typecheck clean. The one remaining caller of the old signature — the obsolete-generation fingerprint test — moved to real key blobs, because the verifier now identifies a key before recording a fingerprint and a placeholder string would be refused before reaching the generation check that test covers.