mirror of
https://github.com/stablyai/orca.git
synced 2026-09-26 16:02:43 +00:00
Jinwoo Hong
da1c322b00
* feat(mobile): one build-time constant decides native or OTA, default native EXPO_PUBLIC_MOBILE_SHELL is read in exactly one place, mobileShellBuildKind in preferences.ts. Expo's babel preset inlines a literal process.env member expression at build time, so a release bundle carries the answer as a constant and anything but the exact string 'ota' — unset, empty, a typo — is native. Every default build is therefore the native app, unchanged. mobileWebShellFlagCanBeOn now answers __DEV__ or an OTA build, so the ability to mount the page comes from the build and never from storage: a native binary installed over an OTA one, same bundle id and same data container, still refuses a stored 'true' without reading the key. An unset key reads on only in an OTA build; a development build keeps its opt-in, and a stored 'false' wins everywhere so the Troubleshoot toggle can switch an OTA build back to native. That toggle now mounts wherever the flag can be on, which is the only way back to the native screens in an OTA build, and its label names the build kind rather than saying "(dev)". The bundle probe row beside it stays development-only: it fetches. The flag census gains two rules — one module reads the switch, in the member form Expo inlines and not the bracket form, and one named function answers the build kind — and the build-kind fence now lists the Troubleshoot route that asks it. Docblocks that said a store build can never mount the shell now say it mounts only when built for OTA. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb * ci(mobile): one workflow input picks the shell, and no input means native Both release workflows gain a `shell` workflow_dispatch choice, options native and ota, default native, and hand it to the step that bundles the JavaScript as EXPO_PUBLIC_MOBILE_SHELL. That is the Gradle assembleRelease step on Android and the fastlane build_and_upload step on iOS; nothing else in either file sets it. A tag push and a schedule carry no inputs at all, so `inputs.shell || 'native'` yields native for them — the first OTA release is a dispatch with one field changed, and every other run is the app we ship today. Each build step prints the value it is about to build with, read back from the same variable rather than from a second copy of the expression, so a run's log cannot claim a shell the build did not use. The new contract test evaluates that expression rather than matching its text: absent, empty and 'native' all resolve to native, 'ota' to ota, and any expression shape it cannot evaluate is a failure rather than a pass. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb * build: the desktop packages the real page, and the placeholder is retired build:mobile-web now runs the app builder and app verifier, and both take their output root from MOBILE_WEB_BUNDLE_DIR in the packaging guard rather than each carrying a constant of their own — one definition of where the bundle lives, so a drift cannot leave electron-builder's beforePack looking at an empty directory while the builder reports a tree it wrote elsewhere. build:mobile-web:app is gone; it was the same two commands. src/mobile-web/ and its two scripts go with it. What the app builder shared with them is split into three modules named for what they hold rather than for the bundle that used to own them: mobile-web-bundle-manifest.mjs (content types, the canonical asset serialization, buildId, hashed assets, the protocol window and the manifest write), script-entry-detection.mjs (isDirectInvocation, whose two failure modes are Windows paths and symlinked entries), and mobile-web-source-line-endings.mjs (the CRLF guard, now with a required directory rather than a default pointing at the deleted tree). The two suites that only needed *a* valid tree on disk — the beforePack guard and the packaged-bundle guard — build one from mobile-web-bundle-fixture-tree instead of bundling the whole mobile graph. It goes through the same manifest writer the page does, so a manifest shape change still reaches them. Also retired: the placeholder's tsconfig project and its typecheck lane, its knip entry, its electron-builder exclusion and .gitattributes pins, and the app-bundle test that asserted the shims stayed out of a builder that no longer exists. pr.yml's page job builds the same bundle the package job ships. Inert for native phones: they never fetch it. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb * style(config): one import of node:fs/promises in the entry-detection suite The changed-code quality gate's focused plugins read the two as a duplicate import; the readFile line was left over from the split. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb * docs: the comments that still describe the retired placeholder bundle The web entry said it was built by `build:mobile-web:app` into out/mobile-web-app and shipped by nothing. That script, that directory and that fact are all gone: it is built by `build:mobile-web` into the packaged bundle dir, and a phone mounts it only when the binary was built with EXPO_PUBLIC_MOBILE_SHELL=ota. Two Windows cache keys explained themselves by naming src/mobile-web and "the two bundle builders"; config/** now covers the builder, the verifier and the manifest writer, and the spike's key no longer waits on a Phase C flip that has happened. The keys themselves are unchanged. Three scratch directories in the app-bundle suites and one in the verifier still spelled the retired output root. Renamed to mobile-web, which is what the build writes; they are temp subdirectory names and nothing reads them. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
87 lines
4.4 KiB
Plaintext
87 lines
4.4 KiB
Plaintext
# A shebang plus CRLF makes vite's SSR transform emit a literal `#!` mid-module,
|
|
# so any suite importing the script dies at load with a SyntaxError. Pin the whole
|
|
# directory rather than the scripts that happen to have a test today.
|
|
/config/scripts/**/*.mjs text eol=lf
|
|
/skill-guides/*.md text eol=lf
|
|
/skill-stubs/*.md text eol=lf
|
|
/skill-stubs/_shared/*.md text eol=lf
|
|
/skills/*/SKILL.md text eol=lf
|
|
/src/cli/bundled-skill-guides.ts text eol=lf
|
|
# Bundled plugin trees are byte-hashed; CRLF checkout would break the pinned hash.
|
|
/resources/plugins/** text eol=lf
|
|
# Relay assets are copied verbatim into the bundle and hashed byte-for-byte into
|
|
# .version, which names the immutable remote install dir. A CRLF checkout makes a
|
|
# Windows-built client disagree with a mac/Linux-built one on the same release,
|
|
# so one host ends up with two relay trees (#17886 review).
|
|
/config/relay-assets/** text eol=lf
|
|
# Pin the bytes so a patch reads and diffs identically on every host. It is NOT
|
|
# what makes the hash right: pnpm hashes a patch LF-normalized, so a CRLF checkout
|
|
# cannot change it. Believing otherwise put a hand-computed raw digest in the
|
|
# lockfile twice and broke every install (#17886).
|
|
# These files are stored LF, which is not always the encoding they were written
|
|
# against -- @vscode/windows-process-tree ships CRLF sources -- so any code that
|
|
# runs `git apply` on one must force `-c core.autocrlf=input` rather than trust
|
|
# the host's setting. See config/scripts/windows-process-tree-gyp-rebuild.mjs.
|
|
/config/patches/*.patch -text
|
|
# Same reason, and pnpm parses these too: a CRLF checkout makes the mobile
|
|
# patches unparseable, so Windows packaging dies on ERR_PNPM_INVALID_PATCH.
|
|
/mobile/patches/*.patch -text
|
|
# The xterm bundle hunks also make a diff nobody can read; review the hand-written
|
|
# source patch under xterm-src/ instead. The sibling patches stay diffable.
|
|
/config/patches/@xterm__xterm@*.patch -diff
|
|
/config/patches/xterm-src/*.patch text eol=lf
|
|
# pnpm parses these unified diffs during Windows installs; keep checkout bytes stable.
|
|
/mobile/patches/*.patch -text
|
|
# Generated wrapper fixtures: collapse them in the PR diff so they stop drowning
|
|
# the reviewable change, and pin LF because they are compared byte-for-byte.
|
|
# Not -diff: the shell diff is the review surface when a wrapper does change.
|
|
/src/main/__fixtures__/shell-wrapper-snapshots/*.txt linguist-generated=true text eol=lf
|
|
# Captured agent PTY transcripts. -text, not `text eol=lf` like the wrapper snapshots above:
|
|
# these carry real CR and CRLF bytes as the terminal emitted them, and line-ending
|
|
# normalisation on a Windows checkout would rewrite the evidence the fixture exists to be.
|
|
/src/main/runtime/__fixtures__/*.txt -text
|
|
# Generated runtime English subset: compared byte-for-byte by
|
|
# verify:localization-runtime-catalog, so a CRLF checkout would fail the gate.
|
|
/src/renderer/src/i18n/en-runtime-required.json linguist-generated=true text eol=lf
|
|
# Generated method->params catalog: compared byte-for-byte by
|
|
# verify:rpc-params-catalog, so a CRLF checkout would fail the gate.
|
|
/src/shared/rpc-contract/rpc-params-catalog.generated.ts linguist-generated=true text eol=lf
|
|
# Mobile web page source. Every text byte here is hashed into an asset digest and from
|
|
# there into buildId, so a CRLF Windows checkout would ship a different bundle id for
|
|
# identical source (91af2897 vs 9d78435e, measured on the bundle this replaced).
|
|
/mobile/src/** text eol=lf
|
|
/mobile/app/** text eol=lf
|
|
/mobile/web-entry/** text eol=lf
|
|
# The blanket pin above would mark a future binary as text; exempt the asset types an
|
|
# RN page actually carries.
|
|
/mobile/src/**/*.png -text
|
|
/mobile/src/**/*.jpg -text
|
|
/mobile/src/**/*.jpeg -text
|
|
/mobile/src/**/*.gif -text
|
|
/mobile/src/**/*.ico -text
|
|
/mobile/src/**/*.webp -text
|
|
/mobile/src/**/*.ttf -text
|
|
/mobile/src/**/*.otf -text
|
|
/mobile/src/**/*.woff -text
|
|
/mobile/src/**/*.woff2 -text
|
|
/mobile/app/**/*.png -text
|
|
/mobile/app/**/*.jpg -text
|
|
/mobile/app/**/*.jpeg -text
|
|
/mobile/app/**/*.gif -text
|
|
/mobile/app/**/*.ico -text
|
|
/mobile/app/**/*.webp -text
|
|
/mobile/app/**/*.ttf -text
|
|
/mobile/app/**/*.otf -text
|
|
/mobile/app/**/*.woff -text
|
|
/mobile/app/**/*.woff2 -text
|
|
/mobile/web-entry/**/*.png -text
|
|
/mobile/web-entry/**/*.jpg -text
|
|
/mobile/web-entry/**/*.jpeg -text
|
|
/mobile/web-entry/**/*.gif -text
|
|
/mobile/web-entry/**/*.ico -text
|
|
/mobile/web-entry/**/*.webp -text
|
|
/mobile/web-entry/**/*.ttf -text
|
|
/mobile/web-entry/**/*.otf -text
|
|
/mobile/web-entry/**/*.woff -text
|
|
/mobile/web-entry/**/*.woff2 -text
|