mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 16:03:17 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
63 lines
2.1 KiB
TypeScript
63 lines
2.1 KiB
TypeScript
import { basename } from 'node:path'
|
|
import type { Repo } from '../shared/types'
|
|
import { splitWorktreeId, splitWorktreeIdForFilesystem } from '../shared/worktree-id'
|
|
import { isFolderRepo } from '../shared/repo-kind'
|
|
import type { Store } from './persistence'
|
|
|
|
export type UsageWorktreeRef = {
|
|
worktreeId: string
|
|
path: string
|
|
displayName: string
|
|
}
|
|
|
|
function getDefaultUsageWorktreeLabel(pathValue: string): string {
|
|
return basename(pathValue)
|
|
}
|
|
|
|
export function loadKnownUsageWorktreesByRepo(
|
|
store: Pick<Store, 'getAllWorktreeMeta'>,
|
|
repos: Repo[]
|
|
): Map<string, UsageWorktreeRef[]> {
|
|
const localRepos = repos.filter((repo) => !repo.connectionId)
|
|
const repoIds = new Set(localRepos.map((repo) => repo.id))
|
|
const worktreesByRepo = new Map<string, UsageWorktreeRef[]>()
|
|
const seenPathsByRepo = new Map<string, Set<string>>()
|
|
|
|
for (const repo of localRepos) {
|
|
worktreesByRepo.set(repo.id, [
|
|
{
|
|
worktreeId: `${repo.id}::${repo.path}`,
|
|
path: repo.path,
|
|
displayName: repo.displayName || getDefaultUsageWorktreeLabel(repo.path)
|
|
}
|
|
])
|
|
seenPathsByRepo.set(repo.id, new Set([repo.path]))
|
|
}
|
|
|
|
// Why: usage scans are background/opt-in analytics. Do not spawn
|
|
// `git worktree list` here; it can re-touch macOS protected folders.
|
|
for (const [worktreeId, meta] of Object.entries(store.getAllWorktreeMeta())) {
|
|
const parsed = splitWorktreeId(worktreeId)
|
|
if (!parsed || !repoIds.has(parsed.repoId)) {
|
|
continue
|
|
}
|
|
const repo = localRepos.find((item) => item.id === parsed.repoId)
|
|
const worktreePath =
|
|
repo && isFolderRepo(repo)
|
|
? (splitWorktreeIdForFilesystem(worktreeId)?.worktreePath ?? parsed.worktreePath)
|
|
: parsed.worktreePath
|
|
const seenPaths = seenPathsByRepo.get(parsed.repoId)
|
|
if (seenPaths?.has(worktreePath)) {
|
|
continue
|
|
}
|
|
seenPaths?.add(worktreePath)
|
|
worktreesByRepo.get(parsed.repoId)?.push({
|
|
worktreeId,
|
|
path: worktreePath,
|
|
displayName: meta.displayName || getDefaultUsageWorktreeLabel(worktreePath)
|
|
})
|
|
}
|
|
|
|
return worktreesByRepo
|
|
}
|