mirror of
https://github.com/stablyai/orca.git
synced 2026-09-25 16:02:38 +00:00
The four agent hook services, the main hooks module, and the two relay modules each carried a file-level `eslint-disable max-lines` and ran 365-628 counted lines against a 300-line budget. AGENTS.md calls for splitting rather than suppressing, and config/max-lines-baseline.txt is a shrink-only ratchet, so this removes all seven suppressions and prunes their entries (341 -> 334). Pure move, no behavior change. Each hook service splits into its managed script source, its config/bundle serialization, and its remote-install path, keeping the per-agent integrations independent: copilot, amp, antigravity and hermes each retain their own getManagedScript rather than sharing one, because each emits a different script body for a different agent. Merging them by name would have been a behavior change, not a refactor. For antigravity the suppression's stated rationale -- that local install, Windows wrapper generation, status cleanup, and SSH remote install must share one event list and managed-command matcher so stale-hook cleanup cannot drift by platform -- is now enforced structurally instead: both install paths call buildInstalledConfig + createAntigravityManagedCommandMatcher over the single ANTIGRAVITY_EVENTS catalog, with the graph a strict DAG. Also registers the six new antigravity/ and copilot/ modules in config/tsconfig.cli.json. That project uses a curated `include` list rather than a glob, so an unlisted module fails `tsc -p config/tsconfig.tc.cli.json` with TS6307 even though the entire unit suite passes. Verified: oxlint clean, ratchet passes, typecheck clean, full unit suite green (remaining failures are pre-existing load flakes in untouched files, green when re-run serially), no new runtime import cycles, and no lint suppression added.
471 lines
16 KiB
TypeScript
471 lines
16 KiB
TypeScript
import type * as NodeChildProcess from 'node:child_process'
|
|
import type * as NodeFs from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
|
|
import type { Repo } from '../shared/repo-types'
|
|
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
const { execFileSyncMock } = vi.hoisted(() => ({
|
|
execFileSyncMock: vi.fn()
|
|
}))
|
|
|
|
vi.mock('fs', () => ({
|
|
readFileSync: vi.fn(),
|
|
existsSync: vi.fn(),
|
|
mkdirSync: vi.fn(),
|
|
writeFileSync: vi.fn(),
|
|
chmodSync: vi.fn()
|
|
}))
|
|
|
|
vi.mock('child_process', () => ({
|
|
exec: vi.fn(),
|
|
execFileSync: execFileSyncMock,
|
|
// runner.ts imports these from child_process; stubs prevent
|
|
// "missing export" errors when the mock is resolved transitively.
|
|
execFile: vi.fn(),
|
|
spawn: vi.fn()
|
|
}))
|
|
|
|
describe('createSetupRunnerScript', () => {
|
|
const makeRepo = () =>
|
|
({
|
|
id: 'test-id',
|
|
path: '/test/repo',
|
|
displayName: 'Test Repo',
|
|
badgeColor: '#000',
|
|
addedAt: Date.now()
|
|
}) as unknown as Repo
|
|
|
|
it('writes a fail-fast Windows runner that returns after batch commands', async () => {
|
|
const fs = await import('node:fs')
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.cmd')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'win32'
|
|
})
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(
|
|
makeRepo(),
|
|
'C:\\repo\\feature\\',
|
|
'pnpm install\npnpm build'
|
|
)
|
|
|
|
expect(result).toEqual({
|
|
runnerScriptPath: 'C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.cmd',
|
|
envVars: expect.objectContaining({
|
|
ORCA_ROOT_PATH: '/test/repo',
|
|
ORCA_WORKTREE_PATH: 'C:\\repo\\feature\\',
|
|
ORCA_WORKSPACE_NAME: 'feature'
|
|
}),
|
|
// Why: native Windows worktrees without a configured setup shell keep the cmd runner.
|
|
shell: { family: 'cmd' }
|
|
})
|
|
expect(vi.mocked(fs.writeFileSync)).toHaveBeenCalledWith(
|
|
'C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.cmd',
|
|
[
|
|
'@echo off',
|
|
'setlocal EnableExtensions DisableDelayedExpansion',
|
|
'call pnpm install',
|
|
'if errorlevel 1 exit /b %errorlevel%',
|
|
'call pnpm build',
|
|
'if errorlevel 1 exit /b %errorlevel%',
|
|
''
|
|
].join('\r\n'),
|
|
'utf-8'
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
|
|
it('converts path env vars to MSYS form for a native Windows Git Bash runner', async () => {
|
|
const fs = await import('node:fs')
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh')
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: 'win32' })
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(
|
|
{ ...makeRepo(), path: 'C:\\Users\\jinwo\\git\\orca' },
|
|
'C:\\repo\\feature',
|
|
'#!/usr/bin/env bash\npnpm install',
|
|
undefined,
|
|
{ family: 'posix' }
|
|
)
|
|
|
|
expect(result).toEqual({
|
|
runnerScriptPath: 'C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
envVars: expect.objectContaining({
|
|
ORCA_ROOT_PATH: '/c/Users/jinwo/git/orca',
|
|
ORCA_WORKTREE_PATH: '/c/repo/feature',
|
|
CONDUCTOR_ROOT_PATH: '/c/Users/jinwo/git/orca',
|
|
GHOSTX_ROOT_PATH: '/c/Users/jinwo/git/orca',
|
|
// Why: a display name, never a path — it must survive the conversion untouched.
|
|
ORCA_WORKSPACE_NAME: 'feature'
|
|
}),
|
|
shell: { family: 'posix' }
|
|
})
|
|
expect(vi.mocked(fs.writeFileSync)).toHaveBeenCalledWith(
|
|
'C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
'#!/usr/bin/env bash\nset -e\npnpm install\n',
|
|
'utf-8'
|
|
)
|
|
// Why: chmod over a native Windows path is meaningless; only the WSL branch sets the bit.
|
|
expect(vi.mocked(fs.chmodSync)).not.toHaveBeenCalledWith(
|
|
'C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
0o755
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: originalPlatform })
|
|
}
|
|
})
|
|
|
|
it('leaves non-path setup env values alone under a Git Bash runner', async () => {
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh')
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: 'win32' })
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const { TERMINAL_GIT_CREDENTIAL_GUARD_POLICY_ENV } =
|
|
await import('../shared/terminal-git-credential-guard')
|
|
const result = createSetupRunnerScript(
|
|
makeRepo(),
|
|
'C:\\repo\\feature',
|
|
'pnpm install',
|
|
undefined,
|
|
{ family: 'posix' }
|
|
)
|
|
|
|
expect(result.envVars[TERMINAL_GIT_CREDENTIAL_GUARD_POLICY_ENV]).toBe('guard')
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: originalPlatform })
|
|
}
|
|
})
|
|
|
|
it('keeps native Windows env vars in Windows form for the default cmd runner', async () => {
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('C:\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.cmd')
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: 'win32' })
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(
|
|
{ ...makeRepo(), path: 'C:\\Users\\jinwo\\git\\orca' },
|
|
'C:\\repo\\feature',
|
|
'pnpm install'
|
|
)
|
|
|
|
expect(result.envVars).toEqual(
|
|
expect.objectContaining({
|
|
ORCA_ROOT_PATH: 'C:\\Users\\jinwo\\git\\orca',
|
|
ORCA_WORKTREE_PATH: 'C:\\repo\\feature'
|
|
})
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', { configurable: true, value: originalPlatform })
|
|
}
|
|
})
|
|
|
|
it('preserves exclamation marks in Windows runner script lines', async () => {
|
|
const { buildWindowsRunnerScript } = await import('./setup-runner-script-text')
|
|
|
|
const runner = buildWindowsRunnerScript('echo hello!world!')
|
|
|
|
// Why: launchers invoke the runner under cmd /v:on, so the runner must disable delayed
|
|
// expansion itself or `!world!` is consumed as a variable reference.
|
|
expect(runner).toContain('setlocal EnableExtensions DisableDelayedExpansion')
|
|
expect(runner).toContain('call echo hello!world!')
|
|
})
|
|
|
|
it('refuses to run a shebang script as a batch command', async () => {
|
|
const { buildWindowsRunnerScript } = await import('./setup-runner-script-text')
|
|
|
|
// Regression: a POSIX script reaching the cmd runner (no Git Bash terminal, or an SSH
|
|
// Windows host) must not have its interpreter-agnostic prefix executed under cmd —
|
|
// `pnpm install` would run and only a later bash-only line would fail, leaving the
|
|
// worktree half set up.
|
|
const runner = buildWindowsRunnerScript('#!/usr/bin/env bash\npnpm install\nsource .env')
|
|
|
|
expect(runner).not.toContain('call pnpm install')
|
|
expect(runner).not.toContain('call source .env')
|
|
expect(runner).toContain('needs a POSIX shell')
|
|
expect(runner).toContain('exit /b 1')
|
|
})
|
|
|
|
it('keeps a `#` comment that is not an interpreter line', async () => {
|
|
const { buildWindowsRunnerScript } = await import('./setup-runner-script-text')
|
|
|
|
const runner = buildWindowsRunnerScript('# not a shebang\nrem still batch')
|
|
|
|
expect(runner).toContain('call # not a shebang')
|
|
expect(runner).toContain('call rem still batch')
|
|
})
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'runs a script whose shebang carries invocation-only bash flags',
|
|
async () => {
|
|
// Regression: `set` rejects `-l`/`-s`/`-i` with exit 2, and the runner's own `set -e` turns
|
|
// that into an aborted setup before the first user line.
|
|
const { buildPosixRunnerScript } = await import('./setup-runner-script-text')
|
|
const { mkdtempSync, rmSync, writeFileSync } = await vi.importActual<typeof NodeFs>('node:fs')
|
|
const { execFileSync } = await vi.importActual<typeof NodeChildProcess>('node:child_process')
|
|
|
|
const dir = mkdtempSync(join(tmpdir(), 'orca-posix-runner-'))
|
|
try {
|
|
const runnerPath = join(dir, 'setup-runner.sh')
|
|
writeFileSync(
|
|
runnerPath,
|
|
buildPosixRunnerScript('#!/bin/bash -l\necho SETUP_RAN\n'),
|
|
'utf-8'
|
|
)
|
|
|
|
expect(execFileSync('bash', [runnerPath], { encoding: 'utf-8' })).toContain('SETUP_RAN')
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true })
|
|
}
|
|
}
|
|
)
|
|
|
|
it('derives ORCA_WORKSPACE_NAME from a POSIX worktree path', async () => {
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('/test/repo/.git/worktrees/feature/orca/setup-runner.sh')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'linux'
|
|
})
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(makeRepo(), '/test/repo-feature', 'pnpm install')
|
|
|
|
expect(result.envVars).toEqual(
|
|
expect.objectContaining({
|
|
ORCA_WORKTREE_PATH: '/test/repo-feature',
|
|
ORCA_WORKSPACE_NAME: 'repo-feature'
|
|
})
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
|
|
it('translates WSL runner paths and env vars to Linux form on Windows', async () => {
|
|
const fs = await import('node:fs')
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('/home/jin/.git/worktrees/feature/orca/setup-runner.sh')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'win32'
|
|
})
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(
|
|
{
|
|
...makeRepo(),
|
|
path: 'C:\\Users\\jinwo\\git\\orca'
|
|
},
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\feature',
|
|
'pnpm install'
|
|
)
|
|
|
|
expect(result).toEqual({
|
|
runnerScriptPath:
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
envVars: expect.objectContaining({
|
|
ORCA_ROOT_PATH: '/mnt/c/Users/jinwo/git/orca',
|
|
ORCA_WORKTREE_PATH: '/home/jin/feature',
|
|
ORCA_WORKSPACE_NAME: 'feature',
|
|
CONDUCTOR_ROOT_PATH: '/mnt/c/Users/jinwo/git/orca',
|
|
GHOSTX_ROOT_PATH: '/mnt/c/Users/jinwo/git/orca'
|
|
})
|
|
})
|
|
expect(vi.mocked(fs.writeFileSync)).toHaveBeenCalledWith(
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
'#!/usr/bin/env bash\nset -e\npnpm install\n',
|
|
'utf-8'
|
|
)
|
|
expect(vi.mocked(fs.chmodSync)).toHaveBeenCalledWith(
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
0o755
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
|
|
it('translates WSL env vars to Linux paths when the worktree lives on a WSL UNC path', async () => {
|
|
const fs = await import('node:fs')
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('/home/jin/repo/.git/worktrees/feature/orca/setup-runner.sh')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'win32'
|
|
})
|
|
|
|
try {
|
|
const { createSetupRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createSetupRunnerScript(
|
|
makeRepo(),
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\repo\\feature',
|
|
'pnpm install'
|
|
)
|
|
|
|
expect(result).toEqual({
|
|
runnerScriptPath:
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
envVars: expect.objectContaining({
|
|
ORCA_ROOT_PATH: '/test/repo',
|
|
ORCA_WORKTREE_PATH: '/home/jin/repo/feature',
|
|
ORCA_WORKSPACE_NAME: 'feature',
|
|
CONDUCTOR_ROOT_PATH: '/test/repo',
|
|
GHOSTX_ROOT_PATH: '/test/repo'
|
|
})
|
|
})
|
|
expect(vi.mocked(fs.writeFileSync)).toHaveBeenCalledWith(
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
'#!/usr/bin/env bash\nset -e\npnpm install\n',
|
|
'utf-8'
|
|
)
|
|
expect(vi.mocked(fs.chmodSync)).toHaveBeenCalledWith(
|
|
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
|
0o755
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('createIssueCommandRunnerScript', () => {
|
|
const makeRepo = () =>
|
|
({
|
|
id: 'test-id',
|
|
path: '/test/repo',
|
|
displayName: 'Test Repo',
|
|
badgeColor: '#000',
|
|
addedAt: Date.now()
|
|
}) as unknown as Repo
|
|
|
|
it('writes a POSIX runner under the worktree git dir for long issue commands', async () => {
|
|
const fs = await import('node:fs')
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue(
|
|
'/test/repo/.git/worktrees/feature/orca/issue-command-runner.sh'
|
|
)
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'linux'
|
|
})
|
|
|
|
try {
|
|
const { createIssueCommandRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createIssueCommandRunnerScript(
|
|
makeRepo(),
|
|
'/test/repo-feature',
|
|
'codex exec "long command"\nclaude -p "review it"'
|
|
)
|
|
|
|
expect(result).toEqual({
|
|
runnerScriptPath: '/test/repo/.git/worktrees/feature/orca/issue-command-runner.sh',
|
|
envVars: expect.objectContaining({
|
|
ORCA_ROOT_PATH: '/test/repo',
|
|
ORCA_WORKTREE_PATH: '/test/repo-feature'
|
|
})
|
|
})
|
|
expect(vi.mocked(fs.writeFileSync)).toHaveBeenCalledWith(
|
|
'/test/repo/.git/worktrees/feature/orca/issue-command-runner.sh',
|
|
'#!/usr/bin/env bash\nset -e\ncodex exec "long command"\nclaude -p "review it"\n',
|
|
'utf-8'
|
|
)
|
|
expect(vi.mocked(fs.chmodSync)).toHaveBeenCalledWith(
|
|
'/test/repo/.git/worktrees/feature/orca/issue-command-runner.sh',
|
|
0o755
|
|
)
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
|
|
it('carries the WSL launch shell for a Windows-drive worktree routed through WSL', async () => {
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('/mnt/c/repo/.git/orca/issue-command-runner.sh')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'win32'
|
|
})
|
|
|
|
try {
|
|
const { createIssueCommandRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createIssueCommandRunnerScript(
|
|
makeRepo(),
|
|
'C:\\repo\\feature',
|
|
'codex exec "long command"',
|
|
{ wslDistro: 'Ubuntu' }
|
|
)
|
|
|
|
// Why: the runner path is written back in native Windows form, so the launch needs /mnt again.
|
|
expect(result.runnerScriptPath).toBe('C:\\repo\\.git\\orca\\issue-command-runner.sh')
|
|
expect(result.shell).toEqual({ family: 'posix', executable: 'wsl.exe' })
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
|
|
it('keeps native Windows issue runners on the cmd launch shell', async () => {
|
|
const originalPlatform = process.platform
|
|
|
|
execFileSyncMock.mockReturnValue('C:\\repo\\.git\\orca\\issue-command-runner.cmd')
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: 'win32'
|
|
})
|
|
|
|
try {
|
|
const { createIssueCommandRunnerScript } = await import('./worktree-runner-script')
|
|
const result = createIssueCommandRunnerScript(makeRepo(), 'C:\\repo\\feature', 'pnpm install')
|
|
|
|
expect(result.shell).toEqual({ family: 'cmd' })
|
|
} finally {
|
|
Object.defineProperty(process, 'platform', {
|
|
configurable: true,
|
|
value: originalPlatform
|
|
})
|
|
}
|
|
})
|
|
})
|