mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 00:27:39 +00:00
* perf(git-common): bound the fs-stat fan-out in the worktree pollers snapshotGitCommon and snapshotBase issued one fs op per candidate via Promise.all/a serial loop, unbounded by worktree count. At 973 live worktrees this queued ~6,800 concurrent stat calls (measured peak 6000 in a 1000-entry synthetic benchmark) onto libuv's 4-thread default pool, starving every other main-process fs operation for the scan's duration (~1s). Bound both to concurrency 8 via the existing forEachWithConcurrency helper, matching the precedent in exact-ref-probe.ts and worktree-head-identity-reader.ts. Peak concurrent stats dropped 6000 -> 48 in the benchmark; wall time was essentially unchanged (495ms -> 541ms), since the real bottleneck was never total scan time but pool starvation of unrelated work. Also make the no-native-watch and crash-fuse polling fallbacks in worktree-git-common-watch.ts / worktree-git-common-narrow-watch.ts self-calibrate their cadence: on platforms/paths where this poller is the sole change signal, a fixed 2s cadence at hundreds of worktrees approaches a permanent scan loop. Stretch the interval so a scan stays a bounded fraction (10%) of its own cadence, capped at 30s, floored at the configured base interval. Left the reconciliation backstop (fixed 30s cadence, already accepted) and checkPendingMarkers (bounded by concurrent-worktree-creation count, not total count) untouched. Fixes #17828 * perf(git-common): split the tripwire from the per-entry sweep cadence Review on #17839 found a real staleness trade-off: adaptiveCadence gated ALL detection (worktree add/remove, HEAD, dirty refs, AND per-entry commit signals) behind one stretched interval, so on the crash-fuse polling fallback the reviewer measured cadence sitting at 5.4-10s sustained and hitting the 30s cap once a single scan reached 3s at 973 worktrees -- worse than the pre-#17828 fixed ~2s+250ms baseline for signals users notice immediately (sidebar worktree list, branch labels). Split snapshotGitCommon into a cheap structural "tripwire" (readdir, worktreesDir signature, primary-file signatures, newly-appeared entries -- ~5-6 fs ops, O(1) in worktree count) that always runs on the fixed pollIntervalMs, and the O(n) per-entry sweep (commit/dirty detection) that alone is gated by the adaptive cadence via a nextSweepDueAt deadline. Existing, unchanged entries are carried over by reference on a tripwire-only tick (no re-stat), so diffing produces no spurious events; genuinely new entries are still stat'd immediately so worktree add remains real-time. This keeps everything on one ticking-flag-guarded loop (no new concurrency/race surface) -- scheduling stays fixed at pollIntervalMs; only nextSweepDueAt stretches. Also drop the adaptive-cadence seed heuristic entirely: nextSweepDueAt starts at 0, so the first regular tick after bootstrap sweeps unconditionally on its own schedule instead of guessing an initial interval from the bootstrap snapshot's duration (which could stretch the very first tick to 10-30s on a slow disk). Documented that worktree-git-common-watch.ts's adaptiveCadence call site is unreachable in production (Electron only ships darwin/linux/win32, both covered by NARROW_WATCH_PLATFORMS) rather than implying it protects real users. The reachable path is the narrow-watch crash-fuse fallback in worktree-git-common-narrow-watch.ts. Filed #17878 to track the real long-term fix: periodically retrying the upgrade back to the narrow watch after a crash-fuse trip, so the degraded/polling state doesn't need to be tuned at all once the underlying failure clears. * perf(git-common): gate per-entry structural stats on the entry-dir signature Every real git write inside a worktree admin entry (HEAD, index, config.worktree, locked) goes through a lock file + rename, which moves the entry directory's own mtime/ctime/size signature. Only `gitdir` (worktree move/repair) is rewritten in place, and that's already covered by the periodic ungated backstop (INDEX_BACKSTOP_TICKS). The previous comment claiming structural leaves "change in place every tick" was wrong; verified against git 2.55 across checkout, commit, amend, reset, ref updates, stash, worktree lock/unlock, config --worktree, and index writes. Gate all six per-entry stats behind the entry dir's own signature instead of stat-ing every leaf unconditionally every tick: an unchanged entry now costs one stat per tick instead of six, and a changed one still costs six (bounded by change rate, not worktree count). This also fixes the actual in-flight fan-out: forEachWithConcurrency(entries, 8) previously still issued 6 stats per in-flight entry (48 real concurrent ops); with the gate, warm ticks issue ~1 stat per entry, so true in-flight tracks the concurrency limit directly. This makes the follow-up adaptive-cadence machinery from the prior commit unnecessary: the crash-fuse and no-narrow-watch polling fallbacks no longer need to stretch their own cadence, since a warm sweep across hundreds of worktrees is now cheap regardless of interval. Revert both call sites to a fixed pollIntervalMs and delete the adaptive-cadence option, the split tripwire/sweep cadence, and the seed heuristic — none of it earns its complexity once the real per-entry cost is fixed at the source. Per-entry staleness on the crash-fuse path returns to a fixed 2s + 250ms debounce instead of the previous 5.4-30s adaptive stretch. Refs #17828
85 lines
2.9 KiB
TypeScript
85 lines
2.9 KiB
TypeScript
import { stat } from 'node:fs/promises'
|
|
import { join } from 'node:path'
|
|
|
|
const STRUCTURAL_METADATA_FILES = ['HEAD', 'gitdir', 'locked', 'config.worktree']
|
|
const INDEX_FILE = 'index'
|
|
const HEAD_LOG_FILE = join('logs', 'HEAD')
|
|
|
|
function statSignature(value: { mtimeMs: number; ctimeMs: number; ino: number }): string {
|
|
return `${value.mtimeMs}:${value.ctimeMs}:${value.ino}`
|
|
}
|
|
|
|
export async function gitCommonDirectorySignature(path: string): Promise<string> {
|
|
try {
|
|
const value = await stat(path)
|
|
return `${statSignature(value)}:${value.size}`
|
|
} catch {
|
|
return 'missing'
|
|
}
|
|
}
|
|
|
|
export async function gitCommonFileSignature(path: string): Promise<string | null> {
|
|
try {
|
|
const value = await stat(path)
|
|
return value.isFile() ? `${statSignature(value)}:${value.size}` : null
|
|
} catch {
|
|
return null
|
|
}
|
|
}
|
|
|
|
export type GitCommonEntrySnapshot = {
|
|
dirSignature: string
|
|
structuralSignatures: Map<string, string>
|
|
indexSignature: string | null
|
|
headLogSignature: string | null
|
|
}
|
|
|
|
export async function snapshotGitCommonEntry(
|
|
entryPath: string,
|
|
previous: GitCommonEntrySnapshot | undefined,
|
|
forceFullScan: boolean
|
|
): Promise<GitCommonEntrySnapshot> {
|
|
// Git writes HEAD/index/config.worktree/locked via a lock file + rename inside the
|
|
// entry dir, so the entry dir's own signature moves on every one of those writes
|
|
// (verified against git 2.55: checkout, commit, amend, reset, ref updates, stash,
|
|
// worktree lock/unlock, config --worktree, index writes all move it). The one
|
|
// in-place exception is `gitdir` (worktree move/repair), which the periodic
|
|
// forceFullScan backstop (INDEX_BACKSTOP_TICKS) below re-stats regardless of this
|
|
// gate. Gating all of these leaves on the entry-dir signature turns an unchanged
|
|
// entry into a single stat per tick instead of stat-ing every leaf every tick.
|
|
const nextDirSignature = await gitCommonDirectorySignature(entryPath)
|
|
if (nextDirSignature === 'missing') {
|
|
return (
|
|
previous ?? {
|
|
dirSignature: nextDirSignature,
|
|
structuralSignatures: new Map(),
|
|
indexSignature: null,
|
|
headLogSignature: null
|
|
}
|
|
)
|
|
}
|
|
const shouldRescan = forceFullScan || !previous || previous.dirSignature !== nextDirSignature
|
|
if (!shouldRescan) {
|
|
return previous
|
|
}
|
|
const structuralSignatures = new Map<string, string>()
|
|
const [headLogSignature, indexSignature] = await Promise.all([
|
|
gitCommonFileSignature(join(entryPath, HEAD_LOG_FILE)),
|
|
gitCommonFileSignature(join(entryPath, INDEX_FILE)),
|
|
Promise.all(
|
|
STRUCTURAL_METADATA_FILES.map(async (name) => {
|
|
const signature = await gitCommonFileSignature(join(entryPath, name))
|
|
if (signature !== null) {
|
|
structuralSignatures.set(name, signature)
|
|
}
|
|
})
|
|
)
|
|
])
|
|
return {
|
|
dirSignature: nextDirSignature,
|
|
structuralSignatures,
|
|
indexSignature,
|
|
headLogSignature
|
|
}
|
|
}
|