mirror of
https://github.com/stablyai/orca.git
synced 2026-10-24 08:03:58 +00:00
284 lines
10 KiB
TypeScript
284 lines
10 KiB
TypeScript
// listWorktrees scan sharing: in-flight coalescing and mutation-generation retirement.
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const {
|
|
gitExecFileAsyncMock,
|
|
gitExecFileSyncMock,
|
|
translateWslOutputPathsMock,
|
|
moveWorktreeDirectoryToTrashMock
|
|
} = vi.hoisted(() => ({
|
|
gitExecFileAsyncMock: vi.fn(),
|
|
gitExecFileSyncMock: vi.fn(),
|
|
translateWslOutputPathsMock: vi.fn((output: string) => output),
|
|
moveWorktreeDirectoryToTrashMock: vi.fn()
|
|
}))
|
|
|
|
vi.mock('./runner', () => ({
|
|
gitExecFileAsync: gitExecFileAsyncMock,
|
|
gitExecFileSync: gitExecFileSyncMock,
|
|
translateWslOutputPaths: translateWslOutputPathsMock
|
|
}))
|
|
|
|
// Default: the checkout cannot be renamed aside, so removal deletes it in place.
|
|
vi.mock('../worktree-trash', () => ({
|
|
moveWorktreeDirectoryToTrash: moveWorktreeDirectoryToTrashMock.mockResolvedValue(undefined),
|
|
restoreWorktreeDirectoryFromTrash: vi.fn().mockResolvedValue(true),
|
|
scheduleWorktreeTrashDeletion: vi.fn()
|
|
}))
|
|
|
|
import {
|
|
_getWorktreeScanCacheSizesForTests,
|
|
_resetWorktreeScanCacheForTests,
|
|
listWorktrees,
|
|
listWorktreesStrict,
|
|
moveWorktree,
|
|
removeWorktree,
|
|
WORKTREE_LIST_TIMEOUT_MS
|
|
} from './worktree'
|
|
import { registerWorktreeSuiteHooks } from './worktree-test-harness'
|
|
|
|
registerWorktreeSuiteHooks()
|
|
|
|
describe('listWorktrees in-flight sharing', () => {
|
|
beforeEach(async () => {
|
|
gitExecFileAsyncMock.mockReset()
|
|
_resetWorktreeScanCacheForTests()
|
|
// Why: capability discovery serializes same-host callers; warming it lets
|
|
// these tests isolate the scan-generation overlap they are exercising.
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: '' })
|
|
await listWorktrees('/capability-warmup')
|
|
gitExecFileAsyncMock.mockReset()
|
|
})
|
|
|
|
// Later describes in this file assume a pristine mock (no global reset).
|
|
afterEach(() => {
|
|
gitExecFileAsyncMock.mockReset()
|
|
})
|
|
|
|
it('shares one scan across concurrent calls for the same repo', async () => {
|
|
let resolveScan!: () => void
|
|
const scanOutput = 'worktree /repo\nHEAD abc123\nbranch refs/heads/main\n'
|
|
gitExecFileAsyncMock.mockImplementation(
|
|
() =>
|
|
new Promise((resolve) => {
|
|
resolveScan = () => resolve({ stdout: scanOutput })
|
|
})
|
|
)
|
|
|
|
const first = listWorktrees('/repo')
|
|
const second = listWorktrees('/repo')
|
|
resolveScan()
|
|
const [a, b] = await Promise.all([first, second])
|
|
|
|
expect(a).toEqual(b)
|
|
expect(a[0]?.path).toBe('/repo')
|
|
expect(gitExecFileAsyncMock).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('does not share scans across different timeout contracts', async () => {
|
|
const scanOutput = 'worktree /repo\nHEAD abc123\nbranch refs/heads/main\n'
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: scanOutput })
|
|
|
|
await Promise.all([listWorktrees('/repo'), listWorktrees('/repo', { timeout: 5_000 })])
|
|
|
|
expect(gitExecFileAsyncMock.mock.calls).toEqual([
|
|
[
|
|
['worktree', 'list', '--porcelain', '-z'],
|
|
{ cwd: '/repo', timeout: WORKTREE_LIST_TIMEOUT_MS }
|
|
],
|
|
[['worktree', 'list', '--porcelain', '-z'], { cwd: '/repo', timeout: 5_000 }]
|
|
])
|
|
})
|
|
|
|
it('runs a fresh scan once the shared one has settled', async () => {
|
|
const scanOutput = 'worktree /repo\nHEAD abc123\nbranch refs/heads/main\n'
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: scanOutput })
|
|
|
|
await listWorktrees('/repo')
|
|
await listWorktrees('/repo')
|
|
|
|
expect(gitExecFileAsyncMock).toHaveBeenCalledTimes(2)
|
|
})
|
|
|
|
it('runs a fresh scan after a timed-out shared scan settles', async () => {
|
|
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => undefined)
|
|
try {
|
|
gitExecFileAsyncMock
|
|
.mockRejectedValueOnce(new Error('git timed out.'))
|
|
.mockResolvedValueOnce({
|
|
stdout: 'worktree /repo\nHEAD abc123\nbranch refs/heads/main\n'
|
|
})
|
|
|
|
await expect(listWorktrees('/repo')).resolves.toEqual([])
|
|
await expect(listWorktrees('/repo')).resolves.toEqual([
|
|
expect.objectContaining({ path: '/repo', head: 'abc123' })
|
|
])
|
|
|
|
expect(gitExecFileAsyncMock).toHaveBeenCalledTimes(2)
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
} finally {
|
|
warnSpy.mockRestore()
|
|
}
|
|
})
|
|
|
|
it('distinguishes fail-soft empty results from strict scan failures', async () => {
|
|
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => undefined)
|
|
try {
|
|
const failure = new Error('git spawn timed out')
|
|
gitExecFileAsyncMock.mockRejectedValue(failure)
|
|
|
|
await expect(listWorktrees('/repo')).resolves.toEqual([])
|
|
await expect(listWorktreesStrict('/repo')).rejects.toBe(failure)
|
|
} finally {
|
|
warnSpy.mockRestore()
|
|
}
|
|
})
|
|
|
|
it('does not share scans across different repos', async () => {
|
|
gitExecFileAsyncMock.mockImplementation((_args: string[], options: { cwd: string }) =>
|
|
Promise.resolve({
|
|
stdout: `worktree ${options.cwd}\nHEAD abc123\nbranch refs/heads/main\n`
|
|
})
|
|
)
|
|
|
|
await Promise.all([listWorktrees('/repo-one'), listWorktrees('/repo-two')])
|
|
|
|
expect(gitExecFileAsyncMock).toHaveBeenCalledTimes(2)
|
|
})
|
|
|
|
it('does not retain scan generations after mutations without active scans', async () => {
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: '' })
|
|
|
|
await Promise.all(
|
|
Array.from({ length: 128 }, (_, index) =>
|
|
moveWorktree(`/repo-${index}`, `/repo-${index}-old`, `/repo-${index}-new`)
|
|
)
|
|
)
|
|
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
})
|
|
|
|
it('cleans mutation generations after stale scans settle and supports repo reuse', async () => {
|
|
const scanResolvers: ((stdout: string) => void)[] = []
|
|
let listCalls = 0
|
|
gitExecFileAsyncMock.mockImplementation((args: string[]) => {
|
|
if (args[0] === 'worktree' && args[1] === 'list') {
|
|
listCalls += 1
|
|
return new Promise((resolve) => {
|
|
scanResolvers.push((stdout) => resolve({ stdout }))
|
|
})
|
|
}
|
|
return Promise.resolve({ stdout: '' })
|
|
})
|
|
|
|
const staleScan = listWorktrees('/repo')
|
|
expect(scanResolvers).toHaveLength(1)
|
|
|
|
await moveWorktree('/repo', '/repo-old', '/repo-new')
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 1, generations: 1 })
|
|
|
|
const freshScan = listWorktrees('/repo')
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 2, generations: 1 })
|
|
|
|
scanResolvers[1]?.('worktree /repo-new\nHEAD fresh\nbranch refs/heads/main\n')
|
|
expect((await freshScan)[0]?.path).toBe('/repo-new')
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 1, generations: 1 })
|
|
|
|
scanResolvers[0]?.('worktree /repo\nHEAD stale\nbranch refs/heads/main\n')
|
|
expect((await staleScan)[0]?.path).toBe('/repo')
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
|
|
const firstReuse = listWorktrees('/repo')
|
|
const secondReuse = listWorktrees('/repo')
|
|
expect(listCalls).toBe(3)
|
|
|
|
scanResolvers[2]?.('worktree /repo-reused\nHEAD reused\nbranch refs/heads/main\n')
|
|
const [firstResult, secondResult] = await Promise.all([firstReuse, secondReuse])
|
|
expect(firstResult).toEqual(secondResult)
|
|
expect(firstResult[0]?.path).toBe('/repo-reused')
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
})
|
|
|
|
it('retires every overlapping scan generation across repeated mutations', async () => {
|
|
const scanResolvers: (() => void)[] = []
|
|
let listCalls = 0
|
|
gitExecFileAsyncMock.mockImplementation((args: string[]) => {
|
|
if (args[0] === 'worktree' && args[1] === 'list') {
|
|
listCalls += 1
|
|
return new Promise((resolve) => {
|
|
scanResolvers.push(() => resolve({ stdout: '' }))
|
|
})
|
|
}
|
|
return Promise.resolve({ stdout: '' })
|
|
})
|
|
|
|
const oldestScan = listWorktrees('/repo')
|
|
await moveWorktree('/repo', '/old-0', '/new-0')
|
|
const middleScan = listWorktrees('/repo')
|
|
await moveWorktree('/repo', '/old-1', '/new-1')
|
|
const newestScan = listWorktrees('/repo')
|
|
|
|
expect(listCalls).toBe(3)
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 3, generations: 1 })
|
|
|
|
scanResolvers[0]?.()
|
|
scanResolvers[2]?.()
|
|
scanResolvers[1]?.()
|
|
await Promise.all([oldestScan, middleScan, newestScan])
|
|
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
})
|
|
|
|
it('keeps WSL scans distinct while retiring both after a mutation', async () => {
|
|
const scanResolvers: (() => void)[] = []
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: '' })
|
|
await Promise.all([
|
|
listWorktrees('/capability-warmup', { wslDistro: 'Ubuntu' }),
|
|
listWorktrees('/capability-warmup', { wslDistro: 'Debian' })
|
|
])
|
|
gitExecFileAsyncMock.mockReset()
|
|
gitExecFileAsyncMock.mockImplementation((args: string[]) => {
|
|
if (args[0] === 'worktree' && args[1] === 'list') {
|
|
return new Promise((resolve) => {
|
|
scanResolvers.push(() => resolve({ stdout: '' }))
|
|
})
|
|
}
|
|
return Promise.resolve({ stdout: '' })
|
|
})
|
|
|
|
const staleUbuntu = listWorktrees('/repo', { wslDistro: 'Ubuntu' })
|
|
const staleDebian = listWorktrees('/repo', { wslDistro: 'Debian' })
|
|
expect(scanResolvers).toHaveLength(2)
|
|
|
|
await removeWorktree('/repo', '/worktree', false, {
|
|
knownRemovedWorktree: { branch: '', head: '' },
|
|
wslDistro: 'Ubuntu'
|
|
})
|
|
const freshUbuntu = listWorktrees('/repo', { wslDistro: 'Ubuntu' })
|
|
const freshDebian = listWorktrees('/repo', { wslDistro: 'Debian' })
|
|
expect(scanResolvers).toHaveLength(4)
|
|
|
|
for (const resolve of scanResolvers) {
|
|
resolve()
|
|
}
|
|
await Promise.all([staleUbuntu, staleDebian, freshUbuntu, freshDebian])
|
|
|
|
expect(_getWorktreeScanCacheSizesForTests()).toEqual({ inFlight: 0, generations: 0 })
|
|
})
|
|
|
|
it('does not share scans for callers with an AbortSignal', async () => {
|
|
const scanOutput = 'worktree /repo\nHEAD abc123\nbranch refs/heads/main\n'
|
|
gitExecFileAsyncMock.mockResolvedValue({ stdout: scanOutput })
|
|
const controller = new AbortController()
|
|
|
|
// Why: an aborted shared scan would reject for every caller, so signal
|
|
// callers must keep a private scan.
|
|
await Promise.all([
|
|
listWorktrees('/repo'),
|
|
listWorktrees('/repo', { signal: controller.signal })
|
|
])
|
|
|
|
expect(gitExecFileAsyncMock).toHaveBeenCalledTimes(2)
|
|
})
|
|
})
|