mirror of
https://github.com/stablyai/orca.git
synced 2026-10-24 08:03:58 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
77 lines
2.3 KiB
TypeScript
77 lines
2.3 KiB
TypeScript
import { Worker } from 'node:worker_threads'
|
|
import { app } from 'electron'
|
|
import { join } from 'node:path'
|
|
import type { ParsedWarpThemeResult, ParseWarpThemeOptions } from './parser'
|
|
|
|
export const WARP_THEME_PARSE_TIMEOUT_MS = 1_000
|
|
|
|
type ParseWarpThemeTimeoutOptions = {
|
|
timeoutMs?: number
|
|
}
|
|
|
|
function getParserWorkerPath(): string {
|
|
if (app.isPackaged) {
|
|
return join(process.resourcesPath, 'app.asar', 'out', 'main', 'warp-theme-parser-worker.js')
|
|
}
|
|
return join(__dirname, 'warp-theme-parser-worker.js')
|
|
}
|
|
|
|
function isParsedWarpThemeResult(value: unknown): value is ParsedWarpThemeResult {
|
|
if (!value || typeof value !== 'object') {
|
|
return false
|
|
}
|
|
const record = value as Record<string, unknown>
|
|
return record.ok === true || record.ok === false
|
|
}
|
|
|
|
export function parseWarpThemeYamlWithTimeout(
|
|
content: string,
|
|
fileLabel: string,
|
|
options: ParseWarpThemeOptions = {},
|
|
timeoutOptions: ParseWarpThemeTimeoutOptions = {}
|
|
): Promise<ParsedWarpThemeResult> {
|
|
return new Promise((resolve) => {
|
|
const worker = new Worker(getParserWorkerPath(), {
|
|
workerData: { content, fileLabel, options }
|
|
})
|
|
let settled = false
|
|
// Why: callers may shorten the parse timeout (preview budget) but never
|
|
// extend it past the default cap, keeping untrusted-input parse time bounded.
|
|
const timeoutMs = Math.max(
|
|
0,
|
|
Math.min(WARP_THEME_PARSE_TIMEOUT_MS, timeoutOptions.timeoutMs ?? WARP_THEME_PARSE_TIMEOUT_MS)
|
|
)
|
|
const timeout = setTimeout(() => {
|
|
settle({ ok: false, reason: 'Theme file took too long to parse.' })
|
|
void worker.terminate()
|
|
}, timeoutMs)
|
|
timeout.unref?.()
|
|
|
|
function settle(result: ParsedWarpThemeResult): void {
|
|
if (settled) {
|
|
return
|
|
}
|
|
settled = true
|
|
clearTimeout(timeout)
|
|
worker.removeAllListeners()
|
|
resolve(result)
|
|
}
|
|
|
|
worker.once('message', (message: unknown) => {
|
|
settle(
|
|
isParsedWarpThemeResult(message)
|
|
? message
|
|
: { ok: false, reason: 'Theme parser returned an invalid result.' }
|
|
)
|
|
})
|
|
worker.once('error', () => {
|
|
settle({ ok: false, reason: 'Invalid YAML' })
|
|
})
|
|
worker.once('exit', (code) => {
|
|
if (code !== 0) {
|
|
settle({ ok: false, reason: 'Theme parser exited before returning a result.' })
|
|
}
|
|
})
|
|
})
|
|
}
|