Files
orca/tests/e2e/helpers/workspace-layout-oracle.ts
T
OrcaWinandOrcaWin 7d6603aa17 [comment audit] Complete repository-wide comment cleanup (#33249)
* [comment audit] Align legacy failure-read counts with cached display

* [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci]

* [comment audit] Condense shared generation, path and preview comments [skip ci]

* [comment audit] Condense host, file and Git contract rationale [skip ci]

* [comment audit] Tighten Git lifecycle and provider contract comments [skip ci]

* [comment audit] Clarify shared host authority and launch isolation [skip ci]

* [comment audit] simplify local access mobile and native chat contracts [skip ci]

* [comment audit] simplify native chat presentation and state contracts [skip ci]

* [comment audit] simplify native runtime and provider contracts [skip ci]

* [comment audit] simplify migration and orchestration contracts [skip ci]

* [comment audit] simplify plugin trust and process capture rationale [skip ci]

* [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci]

* [comment audit] clarify remote recovery and launch wire rationale [skip ci]

* [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci]

* [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci]

* [comment audit] clarify sidebar, skill and SSH invariants [skip ci]

* [comment audit] condense structured chat delivery and timing rationale [skip ci]

* [comment audit] condense terminal replay and telemetry invariants [skip ci]

* [comment audit] clarify launch permission and terminal delivery rationale [skip ci]

* [comment audit] clarify workspace ownership and layout contracts [skip ci]

* [comment audit] wait for fitted and painted SSH terminal links

* [comment audit] clarify layout persistence and session ownership [skip ci]

* [comment audit] clarify host routing and workspace lifecycle contracts [skip ci]

* [comment audit] clarify startup persistence and app lifetime comments [skip ci]

* [comment audit] clarify recovery and activity boundaries [skip ci]

* [comment audit] condense activity and artifact invariants [skip ci]

* [comment audit] condense automation authority contracts [skip ci]

* [comment audit] simplify automation scheduling and history contracts [skip ci]

* [comment audit] clarify browser chrome and annotation lifecycles [skip ci]

* [comment audit] clarify browser routing and retained guest ownership [skip ci]

* [comment audit] clarify browser recovery and document ownership comments [skip ci]

* [comment audit] restore hosted runners required by native IME fixtures

* [comment audit] shorten preview, palette and dashboard invariants [skip ci]

* [comment audit] clarify terminal preview, dashboard and retention comments [skip ci]

* [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci]

* [comment audit] shorten rich-text and combined-diff ownership comments [skip ci]

* [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci]

* [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci]

* [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci]

* [comment audit] clarify rich Markdown source and selection safeguards [skip ci]

* [comment audit] clarify editor loading and emulator stream lifetimes [skip ci]

* [comment audit] trim emulator and feature tour narration [skip ci]

* [comment audit] clarify floating workspace and GitHub cache ownership [skip ci]

* [comment audit] trim provider controls and Linear filter explanations [skip ci]

* [comment audit] clarify pairing and chat resume lifetimes [skip ci]

* [comment audit] clarify chat delivery and transcript lifetimes [skip ci]

* [comment audit] clarify session options and host-owned status [skip ci]

* [comment audit] clarify draft durability and live-status precedence [skip ci]

* [comment audit] Trim chat send and model ownership explanations [skip ci]

* [comment audit] Shorten transcript ownership and send recovery comments [skip ci]

* [comment audit] Simplify native chat composer and transcript hook comments [skip ci]

* [comment audit] Shorten native chat scroll and structured session explanations [skip ci]

* [comment audit] Trim workspace picker and onboarding commentary [skip ci]

* [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci]

* [comment audit] Trim sidebar and session history explanations [skip ci]

* [comment audit] Condense session resume and review checks comments [skip ci]

* [comment audit] Shorten checks state and file explorer refresh comments [skip ci]

* [comment audit] Trim plugin bridge and source-control action rationale [skip ci]

* [comment audit] Trim source-control listing and review rationale [skip ci]

* [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci]

* [comment audit] Condense Settings account and appearance rationale [skip ci]

* [comment audit] Trim pairing and repository Settings explanations [skip ci]

* [comment audit] Condense Settings search SSH and terminal safeguards [skip ci]

* [comment audit] Shorten Settings voice and provider ownership comments [skip ci]

* [comment audit] Condense Settings draft persistence and host-state rationale [skip ci]

* [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci]

* [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci]

* [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci]

* [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci]

* [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci]

* [comment audit] Prune focus-read baseline after comment cleanup

* [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci]

* [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci]

* [comment audit] Clarify viewport geometry and skill update safeguards [skip ci]

* [comment audit] Tighten skill inventory, usage and host status comments [skip ci]

* [comment audit] Clarify usage ownership and resource kill safeguards [skip ci]

* [comment audit] Tighten tab selection, rename and search contracts [skip ci]

* [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci]

* [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci]

* [comment audit] Tighten provider loading and terminal recovery comments [skip ci]

* [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci]

* [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci]

* [comment audit] Tighten PTY startup and replay explanations [skip ci]

* [comment audit] Clarify PTY identity and delivery ownership [skip ci]

* [comment audit] Shorten remote reconnect and input replay rationale [skip ci]

* [comment audit] Condense terminal parking clipboard and file link comments [skip ci]

* [comment audit] Clarify IME ownership and trim trace history [skip ci]

* [comment audit] Shorten pane recovery and parked watcher explanations [skip ci]

* [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci]

* [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci]

* [comment audit] Trim renderer lifecycle and menu rationale [skip ci]

* [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci]

* [comment audit] Clarify renderer hook evidence and source ownership [skip ci]

* [comment audit] Tighten IPC ownership and reconnect explanations [skip ci]

* [comment audit] Trim renderer focus, paste and attention comments [skip ci]

* [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci]

* [comment audit] Trim agent launch, resume and ownership commentary [skip ci]

* [comment audit] Shorten account, browser and editor comments [skip ci]

* [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci]

* [comment audit] Condense launch recovery and editor tokenization comments [skip ci]

* [comment audit] Condense workspace selection and terminal pane rationale [skip ci]

* [comment audit] Condense terminal fitting and rendering recovery comments [skip ci]

* [comment audit] Condense terminal input and host routing explanations [skip ci]

* [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci]

* [comment audit] Condense structured launch and terminal link explanations [skip ci]

* [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci]

* [comment audit] Condense session persistence and workspace activation rationale [skip ci]

* [comment audit] Condense workspace routing and browser ownership rationale [skip ci]

* [comment audit] Condense mirror recovery and layout authority rationale [skip ci]

* [comment audit] Condense runtime transport and file safety rationale [skip ci]

* [comment audit] Condense runtime graph and structured session rationale [skip ci]

* [comment audit] Condense browser creation and remote tab recovery rationale [skip ci]

* [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci]

* [comment audit] Condense frame, startup and provider cache rationale [skip ci]

* [comment audit] Condense host twin and agent lifecycle rationale [skip ci]

* [comment audit] Condense browser authority and editor cleanup rationale [skip ci]

* [comment audit] Condense editor buffer identity and review cache rationale [skip ci]

* [comment audit] Condense provider lifetime and repository ownership rationale [skip ci]

* [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci]

* [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci]

* [comment audit] Condense cleanup ownership and listing admission rationale [skip ci]

* [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci]

* [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci]

* [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci]

* [comment audit] Condense cloud rollout and assignment safety rationale [skip ci]

* [comment audit] Condense relay session and database recovery rationale [skip ci]

* [comment audit] Condense relay placement and protocol compatibility rationale [skip ci]

* [comment audit] Condense build and packaging constraints [skip ci]

* [comment audit] Condense CI gates and validation isolation rationale [skip ci]

* [comment audit] Condense catalog identity and browser validation rationale [skip ci]

* [comment audit] Condense mobile browser and frame-budget rationale [skip ci]

* [comment audit] Shorten mobile route and browser test explanations [skip ci]

* [comment audit] Condense editor and session seam test rationale [skip ci]

* [comment audit] Trim session and terminal closure history [skip ci]

* [comment audit] Shorten terminal browser and census explanations [skip ci]

* [comment audit] Preserve root-only E2E diagnostic baseline

* [comment audit] Condense mobile seam and HTML preview test rationale [skip ci]

* [comment audit] Condense preview instrumentation and render harness rationale [skip ci]

* [comment audit] Condense bundle contracts and native-build constraints [skip ci]

* [comment audit] Shorten native packaging and CI routing rationale [skip ci]

* [comment audit] Condense release tooling and benchmark constraints [skip ci]

* [comment audit] Condense packaging and platform gate rationale [skip ci]

* [comment audit] Shorten mobile route and history rationale [skip ci]

* [comment audit] Condense mobile browser and component rationale [skip ci]

* [comment audit] Shorten drawer and workspace-form rationale [skip ci]

* [comment audit] Trim mobile review and editor-document explanations [skip ci]

* [comment audit] Condense editor lifecycle and Markdown explanations [skip ci]

* [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci]

* [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci]

* [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci]

* [comment audit] Condense bridge stream, native request and audio rationale [skip ci]

* [comment audit] Reduce bridge schema and page-client commentary [skip ci]

* [comment audit] Tighten mobile page bridge contracts [skip ci]

* [comment audit] Clarify mobile cache and session constraints [skip ci]

* [comment audit] Condense mobile route and lifecycle rationale [skip ci]

* [comment audit] Tighten mobile shell hook timing rationale [skip ci]

* [comment audit] Clarify route handoff and notification compatibility [skip ci]

* [comment audit] Clarify push registration and dictation cleanup constraints [skip ci]

* [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci]

* [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci]

* [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci]

* [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci]

* [comment audit] Tighten stream replay and queued session ownership rationale [skip ci]

* [comment audit] Condense mobile composer and reply-schema constraints [skip ci]

* [comment audit] Clarify mobile transcript recovery and session ownership [skip ci]

* [comment audit] Clarify mobile queue and source-control compatibility [skip ci]

* [comment audit] Condense storage and task launch constraints [skip ci]

* [comment audit] Clarify task schemas and terminal document ownership [skip ci]

* [comment audit] Tighten terminal input and viewport rationale [skip ci]

* [comment audit] Shorten terminal and RPC recorder contracts [skip ci]

* [comment audit] Condense recorder engine and connection contracts [skip ci]

* [comment audit] Shorten host credential and relay recovery comments [skip ci]

* [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci]

* [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci]

* [comment audit] Condense catalog and relay entry contracts [skip ci]

* [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci]

* [comment audit] Condense WSL relay and E2E regression rationale [skip ci]

* [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci]

* [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci]

* [comment audit] Shorten layout oracle and regression explanations [skip ci]

* [comment audit] Condense paired recovery and ownership regression contracts [skip ci]

* [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci]

* [comment audit] Condense terminal rendering and IME regression rationale [skip ci]

* [comment audit] Shorten terminal recovery and benchmark contracts [skip ci]

* [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci]

* [comment audit] Condense workflow routing and release rationale [skip ci]

* [comment audit] Condense mobile security and installer contracts [skip ci]

* [comment audit] Shorten native rationale and stylesheet workarounds [skip ci]

* [comment audit] Shorten Windows visibility probe rationale [skip ci]

* [comment audit] Condense embedded release and signing rationale [skip ci]

* [comment audit] Retain current main test behavior in final reconciliation [skip ci]

* [comment audit] Complete final comment review across current source inventory

* [comment audit] Handle consolidated audit reports before final CI

* [comment audit] Preserve credential storage census detail [skip ci]

* [comment audit] Scale broad changed E2E selections with verified timing shards

* [comment audit] Align E2E assertions with browser close and settled session metadata

* [comment audit] Match existing E2Es to current resource and windowing contracts

* [comment audit] Observe the shared server outage notice in reconnect coverage

* [comment audit] Make existing renderer probes measure settled tab and PTY work

* [comment audit] Align palette E2E selector with task search

* [comment audit] Refresh remaining palette search selectors

* [comment audit] Keep selector correction within selected audit specs

* [comment audit] Await emoji fixture settings inside renderer evaluation

* [comment audit] Cancel fixture fit retries between terminal tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-25 04:05:46 -07:00

311 lines
11 KiB
TypeScript

// Check every live frame for model-rule breaches and changed identities, including transient breaches.
// Settled steps also compare disk rules/roundtrip, drawn/client/expected/restarted layouts, marker echo and unexpected remounts.
import type { Page } from '@stablyai/playwright-test'
import type { RuntimeClient } from '../../../src/cli/runtime/client'
import type { WorkspaceLayoutModel } from '../../../src/shared/workspace-layout/workspace-layout-model'
import {
checkWorkspaceLayoutModelRules,
checkWorkspaceLayoutRules,
diffOracleLayouts,
formatViolations,
toOracleLayout,
type OracleLayout,
type WorkspaceLayoutPartition
} from './workspace-layout-oracle-model'
import {
liveLayoutModels,
type LiveLayoutFeed,
type LiveWorkspace
} from './workspace-layout-oracle-feed'
import { compareClientToRuntime, compareDrawnToRuntime } from './workspace-layout-oracle-compare'
import { readClientView, readDrawnLayout, type ClientView } from './workspace-layout-oracle-views'
import { expectedDifferences, type ExpectedLayout } from './workspace-layout-oracle-expected'
import { checkLayoutRoundTrip } from '../../../src/shared/workspace-layout/workspace-layout-round-trip-check'
import { checkPaneMarkers } from './workspace-layout-oracle-markers'
import { installRemountCounter, readRemountCounts } from './workspace-layout-oracle-watch'
import { unexpectedFindings } from '../workspace-layout-oracle-known-on-main'
export type OracleCheck =
| 'rules'
| 'view'
| 'client'
| 'expected'
| 'restart'
| 'marker'
| 'remount'
| 'roundTrip'
export type OracleFinding = {
check: OracleCheck
step: string
details: string[]
/** What each side held when the finding was recorded, for the report only. */
evidence?: unknown
}
export type OracleTarget = {
/** The window, when one is attached; a headless runtime has none. */
page?: Page
client: RuntimeClient
/** The runtime's live layout; the same feed across retargets of one run. */
feed: LiveLayoutFeed
/** The saved profile, read once a step settles for the disk-format rules and the round trip. */
readSavedPartitions: () => Promise<WorkspaceLayoutPartition[]>
/** Worktrees whose client view is compared; the scenario's own worktrees. */
worktreeIds: () => string[]
}
export type { ExpectedLayout }
const SETTLE_TIMEOUT_MS = Number(process.env.ORCA_LAYOUT_ORACLE_SETTLE_MS ?? 12_000)
// Views emit no convergence event; re-read after runtime frames until they agree.
const VIEW_CONVERGENCE_POLL_MS = 300
// Today's quiet window (three reads, ~600 ms): no frame across this many gaps between reads.
const QUIET_GAPS = 2
type ViewRead = { view: string[]; client: string[]; evidence: Record<string, unknown> }
function summarizeClientView(view: ClientView): unknown {
return {
worktreeId: view.worktreeId,
error: view.error,
publicationEpoch: view.tabs?.publicationEpoch,
groups: view.tabs?.tabGroups?.map((group) => [group.id, group.tabOrder]),
panes: view.tabs?.tabs.flatMap((tab) =>
tab.type === 'terminal' ? [[tab.parentTabId, tab.leafId, tab.ptyId ?? null, tab.title]] : []
),
terminals: view.terminals.map((terminal) => [
terminal.tabId,
terminal.leafId,
terminal.ptyId,
terminal.orphaned ?? false
])
}
}
function sleep(ms: number): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, ms))
}
export type StepOptions = {
/** The step may recreate existing panes' terminal views (relaunch, daemon restart). */
allowRemount?: true
}
/** A model-rule breach line → the step label current when a frame first showed it. */
type FrameBreaches = Map<string, string>
export class LayoutOracle {
readonly findings: OracleFinding[] = []
private previousModels: WorkspaceLayoutModel[] | null = null
private previousSaved: WorkspaceLayoutPartition[] | null = null
private previousLayout: OracleLayout | null = null
private snapshot: OracleLayout | null = null
private remountBaseline: Record<string, number> = {}
/** Terminal views created per pane in the current window, for the report (and a precondition). */
readonly viewCreations: Record<string, number>[] = []
private readonly frameBreaches: FrameBreaches = new Map()
private label = 'start'
constructor(
private target: OracleTarget,
/** The scenario id the known-on-main list is keyed by. */
private readonly scenarioId: string
) {}
/** The feed's frame callback: the model rules on every published frame. */
checkFrame(feed: LiveLayoutFeed): void {
for (const line of formatViolations(
checkWorkspaceLayoutModelRules(liveLayoutModels(feed.entries()))
)) {
if (!this.frameBreaches.has(line)) {
this.frameBreaches.set(line, this.label)
}
}
}
async start(): Promise<void> {
if (this.target.page) {
await installRemountCounter(this.target.page)
}
}
/** Breaches first seen on a frame while `label` was current, marked as reported. */
private takeFrameBreaches(label: string): string[] {
const lines = [...this.frameBreaches]
.filter(([, seenAt]) => seenAt === label)
.map(([line]) => line)
for (const line of lines) {
this.frameBreaches.set(line, `${label} (reported)`)
}
return lines
}
/** After a relaunch: new window, new renderer, so remounts count from zero again. */
async retarget(target: OracleTarget): Promise<void> {
this.target = target
this.remountBaseline = {}
if (target.page) {
await installRemountCounter(target.page)
}
}
private record(check: OracleCheck, step: string, details: string[], evidence?: unknown): void {
if (details.length > 0) {
this.findings.push({ check, step, details: [...new Set(details)], evidence })
}
}
private async readViews(entries: LiveWorkspace[]): Promise<ViewRead> {
const { page, client } = this.target
const clientViews = await Promise.all(
this.target.worktreeIds().map((worktreeId) => readClientView(client, worktreeId))
)
// A pane keeps its binding after its terminal exits or sleeps; the window then draws none.
const live = new Set(
clientViews.flatMap((view) => view.terminals.flatMap((terminal) => terminal.ptyId ?? []))
)
const drawn = page ? await readDrawnLayout(page) : null
const view = drawn ? compareDrawnToRuntime(entries, drawn, live) : []
if (drawn && drawn.strips.length === 0) {
view.push('the window draws no tab strip')
}
return {
view,
client: clientViews.flatMap((view) => compareClientToRuntime(entries, view)),
evidence: { drawn, clients: clientViews.map(summarizeClientView) }
}
}
// Wait for stable runtime layout and converged views; record only differences that outlive the wait.
async step(
label: string,
expected: ExpectedLayout | null,
options: StepOptions = {}
): Promise<OracleLayout> {
const { feed } = this.target
const deadline = Date.now() + SETTLE_TIMEOUT_MS
let stableReads = 0
let lastFrames = -1
let entries: LiveWorkspace[] = []
let differences: ViewRead = { view: [], client: [], evidence: {} }
for (;;) {
entries = feed.entries()
differences = await this.readViews(entries)
// Quiet only if no frame arrived since the previous read, including during the sleep.
stableReads = feed.ready && feed.frames === lastFrames ? stableReads + 1 : 0
lastFrames = feed.frames
// A difference main is known to keep never converges, so it does not hold the wait.
const agreed =
unexpectedFindings(this.scenarioId, [
{ check: 'view', step: label, details: differences.view },
{ check: 'client', step: label, details: differences.client }
]).length === 0
if ((agreed && stableReads >= QUIET_GAPS) || Date.now() > deadline) {
break
}
await sleep(VIEW_CONVERGENCE_POLL_MS)
}
if (!feed.ready) {
this.record('rules', label, [
`no live layout: ${feed.error ?? 'the stream sent no snapshot'}`
])
}
const models = liveLayoutModels(entries)
const settled = formatViolations(
checkWorkspaceLayoutModelRules(models, this.previousModels ?? undefined)
)
const saved = await this.target.readSavedPartitions()
const savedLines = formatViolations(
checkWorkspaceLayoutRules(saved, this.previousSaved ?? undefined)
).map((line) => line.replace(': ', ': saved profile: '))
this.record('rules', label, [...settled, ...savedLines])
this.record(
'roundTrip',
label,
saved.flatMap(({ hostId, session }) =>
checkLayoutRoundTrip(hostId, session).findings.map(
(finding) => `${hostId} ${JSON.stringify(finding)}`
)
)
)
this.record(
'rules',
`${label} (transient)`,
this.takeFrameBreaches(this.label).filter((line) => !settled.includes(line))
)
this.label = label
const layout = toOracleLayout(entries)
const evidence = { runtime: layout, ...differences.evidence }
this.record('view', label, differences.view, evidence)
this.record('client', label, differences.client, evidence)
if (expected) {
this.record(
'expected',
label,
expectedDifferences(layout, expected, this.previousLayout),
evidence
)
}
await this.checkRemounts(label, options)
this.previousModels = models
this.previousSaved = saved
this.previousLayout = layout
return layout
}
private async checkRemounts(label: string, options: StepOptions): Promise<void> {
const { page } = this.target
if (!page) {
return
}
const counts = await readRemountCounts(page)
const remounted = Object.entries(counts).filter(
([leafId, count]) =>
(this.remountBaseline[leafId] ?? 0) > 0 && count > this.remountBaseline[leafId]!
)
if (!options.allowRemount) {
this.record(
'remount',
label,
remounted.map(
([leafId, count]) => `pane ${leafId}'s terminal view was created ${count} times`
)
)
}
this.remountBaseline = counts
this.viewCreations.push(counts)
}
rememberForRestart(layout: OracleLayout): void {
this.snapshot = layout
}
compareRestart(
label: string,
layout: OracleLayout,
options: { maskPtyIds?: boolean } = {}
): void {
if (!this.snapshot) {
throw new Error('compareRestart called before rememberForRestart')
}
// No empty passes: an empty layout before the restart proves nothing about the restart.
if (Object.keys(this.snapshot).length === 0) {
this.record('restart', label, ['the layout before the restart was empty'])
return
}
this.record(
'restart',
label,
diffOracleLayouts(this.snapshot, layout, { ...options, label: 'after restart' })
)
}
async checkMarkers(label: string, worktreeId: string): Promise<void> {
const { page, client } = this.target
if (page) {
this.record('marker', label, await checkPaneMarkers(page, client, worktreeId))
}
}
}