mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 00:03:20 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
113 lines
3.2 KiB
TypeScript
113 lines
3.2 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
isSetupHookTrusted,
|
|
normalizeSetupHookTrust,
|
|
persistSetupHookTrustApproval,
|
|
trustedOrcaHooksWithSetupApproval,
|
|
wasSetupHookPreviouslyApproved
|
|
} from './setup-hook-trust'
|
|
import type { PersistedTrustedOrcaHooks } from '../../../src/shared/types'
|
|
import type { RpcClient } from '../transport/rpc-client'
|
|
|
|
describe('setup hook trust', () => {
|
|
it('trusts a setup script only when the approved hash matches', () => {
|
|
const trust: PersistedTrustedOrcaHooks = {
|
|
'repo-1': { setup: { contentHash: 'hash-1', approvedAt: 1000 } }
|
|
}
|
|
|
|
expect(isSetupHookTrusted(trust, 'repo-1', 'hash-1')).toBe(true)
|
|
expect(isSetupHookTrusted(trust, 'repo-1', 'hash-2')).toBe(false)
|
|
})
|
|
|
|
it('treats an always-trusted repo as trusted for changed setup scripts', () => {
|
|
const trust: PersistedTrustedOrcaHooks = {
|
|
'repo-1': { all: { approvedAt: 1000 } }
|
|
}
|
|
|
|
expect(isSetupHookTrusted(trust, 'repo-1', 'new-hash')).toBe(true)
|
|
})
|
|
|
|
it('preserves unrelated trust entries when approving setup', () => {
|
|
const trust: PersistedTrustedOrcaHooks = {
|
|
'repo-1': {
|
|
archive: { contentHash: 'archive-hash', approvedAt: 1000 }
|
|
}
|
|
}
|
|
|
|
expect(
|
|
trustedOrcaHooksWithSetupApproval({
|
|
trust,
|
|
repoId: 'repo-1',
|
|
contentHash: 'setup-hash',
|
|
alwaysTrust: false,
|
|
approvedAt: 2000
|
|
})
|
|
).toEqual({
|
|
'repo-1': {
|
|
archive: { contentHash: 'archive-hash', approvedAt: 1000 },
|
|
setup: { contentHash: 'setup-hash', approvedAt: 2000 }
|
|
}
|
|
})
|
|
})
|
|
|
|
it('records always-trust without dropping existing script approvals', () => {
|
|
const trust: PersistedTrustedOrcaHooks = {
|
|
'repo-1': {
|
|
setup: { contentHash: 'setup-hash', approvedAt: 1000 }
|
|
}
|
|
}
|
|
|
|
expect(
|
|
trustedOrcaHooksWithSetupApproval({
|
|
trust,
|
|
repoId: 'repo-1',
|
|
contentHash: 'ignored-for-all',
|
|
alwaysTrust: true,
|
|
approvedAt: 2000
|
|
})
|
|
).toEqual({
|
|
'repo-1': {
|
|
setup: { contentHash: 'setup-hash', approvedAt: 1000 },
|
|
all: { approvedAt: 2000 }
|
|
}
|
|
})
|
|
})
|
|
|
|
it('persists and returns the approved trust state', async () => {
|
|
let persisted: unknown
|
|
const client = {
|
|
sendRequest: async (_method: string, params: unknown) => {
|
|
persisted = params
|
|
return { ok: true, result: null }
|
|
}
|
|
} as unknown as RpcClient
|
|
|
|
const next = await persistSetupHookTrustApproval({
|
|
client,
|
|
trust: {},
|
|
repoId: 'repo-1',
|
|
contentHash: 'setup-hash',
|
|
alwaysTrust: false
|
|
})
|
|
|
|
expect(persisted).toEqual({ trustedOrcaHooks: next })
|
|
expect(isSetupHookTrusted(next, 'repo-1', 'setup-hash')).toBe(true)
|
|
})
|
|
|
|
it('detects previous setup approval and ignores incomplete trust payloads', () => {
|
|
expect(
|
|
wasSetupHookPreviouslyApproved(
|
|
{ 'repo-1': { setup: { contentHash: 'hash-1', approvedAt: 1000 } } },
|
|
'repo-1'
|
|
)
|
|
).toBe(true)
|
|
expect(normalizeSetupHookTrust({ contentHash: 'hash-1', scriptContent: '' })).toBe(null)
|
|
expect(
|
|
normalizeSetupHookTrust({ contentHash: 'hash-1', scriptContent: 'pnpm install' })
|
|
).toEqual({
|
|
contentHash: 'hash-1',
|
|
scriptContent: 'pnpm install'
|
|
})
|
|
})
|
|
})
|