mirror of
https://github.com/stablyai/orca.git
synced 2026-10-25 16:03:53 +00:00
Brennan Benson
38a892c980
* feat(mobile): native-chat model/session-option picker + shared slash catalog (STA-3332) Piece A — shared slash catalog + send classification: - Mobile composer now serves getVerifiedNativeChatCommands from the shared catalog (agent-aware, with description rows) instead of a hardcoded provider-agnostic list that advertised commands Claude does not have. - classifyNativeChatSend moves to src/shared/native-chat-slash-commands.ts (renderer re-exports keep desktop import paths stable); mobile's send seam now gates optimistic echoes on it, so slash sends no longer create a 'Queued' bubble that no transcript echo can ever retire, and the ack-lost hold only arms for chat sends. Piece B — mobile model/session-option pickers: - New per-tab session-option tracking (state/commands/labels modules) ported from the desktop live flow, reading the shared agent-session-option catalog for Claude AND Codex. - Composer pill row (model + options) opening an inline choice card in the proven Ask-card pattern; applies use catalog modelApply semantics (/model <value> via the existing send path), Codex-style agent-picker entries dispatch the picker command and flip the tab to the terminal view. - Current model seeds from the hook-reported provider model when derivable; typed /model-style commands update tracked state (recordOutgoingCommand parity); dispatched values render as sent-not-confirmed. * fix(mobile): keep session option sends scoped * fix(mobile): synchronize native chat refs after commit * refactor: share native chat session option logic * fix(mobile): keep the live tab's session-option record from eviction `getScopedRecord` returned an existing record without re-inserting it, so the per-tab record map evicted by insertion order rather than recency. A long-lived active tab is the oldest key, so crossing the 32-scope cap silently dropped its tracked model and reset the pill to "Model". Desktop's scope cache does delete-then-set for exactly this reason. Also moves the shared session-option tests to src/shared so the root suite runs them (they only exercised src/shared logic the Electron renderer consumes, but sat under mobile/ where only mobile's vitest project sees them), and restores two "why" comments dropped while extracting the shared modules. * fix(mobile): stop a stale session-start report reverting a model pick Re-entering a chat tab re-delivers the same `agentStatus.model`, and the reported-model effect re-applied it unconditionally — so picking a model, moving to another tab, and coming back reverted the pill to the model the agent reported at session start, which cannot have observed the `/model` sent after it. The status stream reconnecting had the same effect. A report is now only treated as evidence when the matched catalog id CHANGES for that scope; a genuinely new report still supersedes a local pick. Mobile has no screen read to confirm a switch against, so the repeat is all we can key off. * fix(mobile): close four session-option picker defects found in review D1 — a picker apply could interleave with a composer send. The composer already blocks a text send while an apply is dispatching, but not the reverse: the host spaces a send's body and its Enter ~500ms apart, so an apply tapped inside that window was submitted as part of the user's prompt, and the pill then claimed a model change that never ran as a command. The pickers render inside the composer, so they now take its in-flight state directly — the same guard, mirrored. D2 — an option was filed under the wrong model. `setTrackedSessionOption` resolves the owning model when it commits, not when the command was built, and the report effect mutates the same record off-queue. A report landing mid-dispatch therefore recorded `/effort low` against the model it switched TO. Ports desktop's supersession guard, which skips the commit when the baseline moved. D3 — a command template's prefix also matches prose that starts with it, so "/model is a weird word" tracked that prose as the current model, rendered it as the pill label, and matched no catalog model, dropping every per-model option. Parsed values are now canonicalized against the catalog; a typed value containing whitespace is treated as a prompt rather than a command. Perf — `/` on a Codex tab returned all 45 commands into a non-virtualized ScrollView showing ~5, re-reconciled on every streaming tick above the transcript. Capped at 12. Also splits the row primitives out of MobileNativeChatSessionOptionPickers.tsx, which the D1 guard pushed to 402 effective lines against a 400 cap. * refactor: share the session-option display ordering CATEGORY_ORDER and the non-model sort were byte-identical in NativeChatSessionOptionPickers.tsx and mobile's labels module — pure logic with no i18n in it, so there was no reason for two copies that can drift. Both now call sortNativeChatSessionOptions from the shared snapshot module. * refactor(mobile): align model picker layout * style(mobile): round native chat composer * fix(mobile): inset rounded chat composer
65 lines
2.9 KiB
TypeScript
65 lines
2.9 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
CLAUDE_SESSION_OPTION_CATALOG,
|
|
CODEX_SESSION_OPTION_CATALOG
|
|
} from './agent-session-option-catalog-claude-codex'
|
|
import {
|
|
applyNativeChatReportedSessionOptions,
|
|
createNativeChatSessionOptionRecord,
|
|
matchNativeChatCatalogModelId,
|
|
type NativeChatSessionOptionRecord
|
|
} from './native-chat-session-option-state'
|
|
|
|
function claudeRecord(): NativeChatSessionOptionRecord {
|
|
return createNativeChatSessionOptionRecord('claude')
|
|
}
|
|
|
|
describe('applyNativeChatReportedSessionOptions', () => {
|
|
it('reports become authority and reset stale per-model values on a model change', () => {
|
|
const record = claudeRecord()
|
|
record.model = { value: 'sonnet', source: 'dispatched' }
|
|
record.valuesByModel.opus = { effort: { value: 'high', source: 'dispatched' } }
|
|
expect(applyNativeChatReportedSessionOptions(record, { model: 'opus' })).toBe(true)
|
|
expect(record.model).toEqual({ value: 'opus', source: 'reported' })
|
|
// A model change invalidates previously tracked values for the destination.
|
|
expect(record.valuesByModel.opus).toEqual({})
|
|
})
|
|
|
|
it('promotes a dispatched guess the report confirms', () => {
|
|
const record = claudeRecord()
|
|
record.model = { value: 'sonnet', source: 'dispatched' }
|
|
expect(applyNativeChatReportedSessionOptions(record, { model: 'sonnet' })).toBe(true)
|
|
expect(record.model).toEqual({ value: 'sonnet', source: 'reported' })
|
|
})
|
|
|
|
it('keeps locally tracked options when the reported model is unchanged', () => {
|
|
const record = claudeRecord()
|
|
record.model = { value: 'sonnet', source: 'reported' }
|
|
record.valuesByModel.sonnet = { effort: { value: 'high', source: 'dispatched' } }
|
|
expect(applyNativeChatReportedSessionOptions(record, { model: 'sonnet' })).toBe(false)
|
|
expect(record.valuesByModel.sonnet?.effort).toEqual({ value: 'high', source: 'dispatched' })
|
|
})
|
|
|
|
it('is a no-op when the report matches tracked state', () => {
|
|
const record = claudeRecord()
|
|
record.model = { value: 'sonnet', source: 'reported' }
|
|
expect(applyNativeChatReportedSessionOptions(record, { model: 'sonnet' })).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('matchNativeChatCatalogModelId', () => {
|
|
it('matches exact ids, labels, and provider-id containment', () => {
|
|
expect(matchNativeChatCatalogModelId(CLAUDE_SESSION_OPTION_CATALOG, 'sonnet')).toBe('sonnet')
|
|
expect(matchNativeChatCatalogModelId(CLAUDE_SESSION_OPTION_CATALOG, 'Sonnet 5')).toBe('sonnet')
|
|
expect(matchNativeChatCatalogModelId(CLAUDE_SESSION_OPTION_CATALOG, 'claude-sonnet-5')).toBe(
|
|
'sonnet'
|
|
)
|
|
expect(matchNativeChatCatalogModelId(CODEX_SESSION_OPTION_CATALOG, 'gpt-5.5')).toBe('gpt-5.5')
|
|
})
|
|
|
|
it('returns null for unrecognized reports', () => {
|
|
expect(matchNativeChatCatalogModelId(CLAUDE_SESSION_OPTION_CATALOG, 'mystery-model')).toBeNull()
|
|
expect(matchNativeChatCatalogModelId(CLAUDE_SESSION_OPTION_CATALOG, '')).toBeNull()
|
|
})
|
|
})
|