mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 16:47:34 +00:00
ff27338299
* wip: connect fails for hosts the managed server can't serve; remove relay session, deploy and relay UI * wip: delete relay-only client modules left unreachable, prune their tests and gates * wip: format * wip: exhaustive unserved message * wip: drop relay attestation test for the deleted ownership proof * fix: prune stale baselines; type the test transport stub * fix(ssh): census proves leftover relay leases; name the remedy for older terminals; translate every connect-failure surface * test(ssh): leftover leases defer to the host census * test(e2e): remove relay-path SSH e2e specs and their CI lanes * test(e2e): drop the auto-convert case that built its relay era through a live relay * test(e2e): mark relay-era browser and catalog journeys fixme until they seed a profile * test(e2e): seed relay-era browser and catalog journeys from a saved profile The three journeys built their old-version state through a connect without an orcad template, which now refuses the host. They now start from a seeded relay-era profile, so the first connect converts the host as an upgrading user's would. * chore(ci): drop shard timings for the deleted relay tests * test(e2e): carry a relay-era login cookie across the browser conversion; own every launch * test(ci): drop the deleted SSH layout oracle from its route * test(e2e): open the retained browser after conversion, retrying a pre-connect card * test(e2e): bind the relay-era browser partition before seeding its cookie A relay-era build always recorded the partition binding before a page stored data in it. Seeding the cookie into an unbound partition made the binding store refuse it (browser_route_partition_binding_store_invalid), so the retained tab showed the generic routing card and Retry could never clear it. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: m4air <m4air@Mac.localdomain> Co-authored-by: Claude <noreply@anthropic.com>
240 lines
12 KiB
JavaScript
240 lines
12 KiB
JavaScript
import { DEDICATED_E2E_SPECS } from './ci-e2e-job-selection.mjs'
|
|
import { existsSync, readFileSync } from 'node:fs'
|
|
import { join, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { parse as parseYaml } from 'yaml'
|
|
import {
|
|
hasNativeImeSourceChange,
|
|
PR_E2E_SOURCE_ROUTES,
|
|
selectPrE2eSpecs
|
|
} from './pr-e2e-source-routing.mjs'
|
|
|
|
const projectDir = resolve(import.meta.dirname, '../..')
|
|
const prWorkflow = parseYaml(readFileSync(join(projectDir, '.github/workflows/pr.yml'), 'utf8'))
|
|
|
|
const filterStep = prWorkflow.jobs.code_paths.steps.find(
|
|
(step) => step.name === 'Filter changed E2E specs'
|
|
)
|
|
const rollbackStep = prWorkflow.jobs.preflight.steps.find(
|
|
(step) => step.name === 'Check VM runtime rollback compatibility'
|
|
)
|
|
/** The route that sends a change to the two-Electron restart-survival spec. */
|
|
const restartSurvivalRoute = PR_E2E_SOURCE_ROUTES.find(
|
|
(route) => route.id === 'client-hosted-browser.restart-survival'
|
|
)
|
|
|
|
describe('restart-survival E2E routing', () => {
|
|
// Every file below carries behavior the restart spec is the only test that exercises end to end.
|
|
it.each([
|
|
'src/main/runtime/orca-runtime.ts',
|
|
'src/main/runtime/orca-runtime-browser.ts',
|
|
'src/main/runtime/client-hosted-page-reconciliation-window.ts',
|
|
'src/main/runtime/runtime-browser-client-page-adoption.ts',
|
|
'src/main/runtime/runtime-browser-client-page-recovery.ts',
|
|
'src/main/runtime/browser-host-client-page-adoption.ts',
|
|
'src/main/runtime/browser-host-page-reconciliation-orchestration.ts',
|
|
'src/main/runtime/rpc/methods/browser-client-host.ts',
|
|
'src/main/browser/browser-client-host-authority-replacement-wait.ts',
|
|
'src/main/browser/paired-runtime-browser-client-host-composition.ts',
|
|
'src/renderer/src/runtime/web-session-tabs-sync.ts',
|
|
'src/renderer/src/runtime/host-session-snapshot-authority.ts',
|
|
'src/renderer/src/runtime/restored-client-hosted-browser-host-attach.ts',
|
|
'src/renderer/src/store/slices/runtime-status.ts',
|
|
'src/shared/runtime-types.ts',
|
|
'src/shared/browser-client-host-protocol.ts'
|
|
])('routes %s', (path) => {
|
|
expect(restartSurvivalRoute.matches(path)).toBe(true)
|
|
})
|
|
|
|
// The pattern is deliberately not "anything under src": routing every PR at a two-Electron spec
|
|
// is the cost the filter exists to avoid.
|
|
it.each([
|
|
'src/main/git/git-status.ts',
|
|
'src/renderer/src/components/tab-bar/BrowserTab.tsx',
|
|
'src/main/terminal/pty-manager.ts',
|
|
// The status/types entries name whole files, not a suffix any longer name may end with.
|
|
'src/shared/computer-use-runtime-types.ts'
|
|
])('does not route %s', (path) => {
|
|
expect(restartSurvivalRoute.matches(path)).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('PR E2E gate contract', () => {
|
|
it('selects modified Playwright specs without running deleted tests', () => {
|
|
expect(filterStep.run).toContain('--diff-filter=AMCR')
|
|
expect(filterStep.run).toContain('config/scripts/pr-e2e-source-routing.mjs')
|
|
expect(filterStep.run).not.toContain('tests/playwright\\.')
|
|
expect(
|
|
selectPrE2eSpecs([
|
|
'tests/e2e/active-view-restart-restore.spec.ts',
|
|
'tests/e2e/deleted.spec.ts.bak',
|
|
'tests/e2e/global-teardown.unit.test.ts'
|
|
])
|
|
).toEqual(['tests/e2e/active-view-restart-restore.spec.ts'])
|
|
})
|
|
|
|
it('scopes the VM rollback oracle to the PR range and recipe schema authorities', () => {
|
|
expect(rollbackStep.run).toMatch(/diff-base\.mjs "\$BASE_SHA"[\s\S]*"\$DIFF_BASE" HEAD --/)
|
|
expect(rollbackStep.run).toContain('src/shared/ephemeral-vm-recipes.ts')
|
|
expect(rollbackStep.run).toContain('src/shared/orca-yaml-hook-types.ts')
|
|
})
|
|
|
|
it('routes P0 sentinels from their causal sources', () => {
|
|
const cases = [
|
|
[
|
|
'src/renderer/src/components/tab-bar/TabBarQuickCommandsMenu.tsx',
|
|
'tests/e2e/terminal-quick-command-pre-bind-recovery.spec.ts'
|
|
],
|
|
['src/main/runtime/orca-runtime-files.ts', 'tests/e2e/paired-quick-open-large-tree.spec.ts'],
|
|
[
|
|
'src/renderer/src/runtime/sync-runtime-graph.ts',
|
|
'tests/e2e/host-parked-pane-remote-viewer.spec.ts'
|
|
],
|
|
[
|
|
'src/renderer/src/runtime/remote-runtime-terminal-multiplexer.ts',
|
|
'tests/e2e/paired-remote-terminal-materialization-reconnect.spec.ts'
|
|
],
|
|
[
|
|
'src/renderer/src/components/terminal-pane/remote-pane-layout-push.ts',
|
|
'tests/e2e/paired-remote-pane-layout-retry.spec.ts'
|
|
]
|
|
]
|
|
for (const [source, spec] of cases) {
|
|
expect(selectPrE2eSpecs([source]), source).toEqual([spec])
|
|
expect(selectPrE2eSpecs([source.replace(/\.tsx?$/, '.test.ts')]), source).toEqual([])
|
|
expect(existsSync(join(projectDir, spec)), spec).toBe(true)
|
|
}
|
|
const parkedSplitSpec = 'tests/e2e/terminal-parked-cli-split.spec.ts'
|
|
for (const source of [
|
|
'src/main/window/attach-main-window-services.ts',
|
|
'src/preload/api/ui-command-event-api.ts',
|
|
'src/preload/index.ts',
|
|
'src/renderer/src/components/terminal-pane/terminal-pane-split-request-routing.ts',
|
|
'src/renderer/src/components/terminal-pane/use-terminal-pane-lifecycle.ts',
|
|
'src/renderer/src/components/terminal-pane/use-terminal-tab-cold-parking.ts',
|
|
'src/renderer/src/hooks/ipc-events/terminal-ui-routing-ipc-bridge.ts'
|
|
]) {
|
|
expect(selectPrE2eSpecs([source]), source).toContain(parkedSplitSpec)
|
|
expect(selectPrE2eSpecs([source.replace(/\.ts$/, '.test.ts')]), source).not.toContain(
|
|
parkedSplitSpec
|
|
)
|
|
}
|
|
expect(existsSync(join(projectDir, parkedSplitSpec)), parkedSplitSpec).toBe(true)
|
|
|
|
const restartContinuitySpec = 'tests/e2e/paired-remote-terminal-serve-restart-binding.spec.ts'
|
|
for (const source of [
|
|
'src/main/daemon/daemon-attach-only-retirement.ts',
|
|
'src/main/daemon/daemon-pty-applied-size.ts',
|
|
'src/main/daemon/daemon-pty-session-control.ts',
|
|
'src/main/daemon/daemon-pty-spawn-result.ts',
|
|
'src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.ts',
|
|
'src/renderer/src/components/terminal-pane/terminal-error-accumulation.ts',
|
|
'src/renderer/src/runtime/web-runtime-session.ts',
|
|
'src/renderer/src/runtime/web-session-tabs-sync.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-adoption.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-surface.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-inventory.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-inventory-validation.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-cache.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-pane.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-queue.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-recovery-rpc-lane.ts',
|
|
'src/renderer/src/runtime/web-session-terminal-orphan-topology.ts'
|
|
]) {
|
|
expect(selectPrE2eSpecs([source]), source).toContain(restartContinuitySpec)
|
|
expect(selectPrE2eSpecs([source.replace(/\.ts$/, '.test.ts')]), source).not.toContain(
|
|
restartContinuitySpec
|
|
)
|
|
}
|
|
expect(existsSync(join(projectDir, restartContinuitySpec)), restartContinuitySpec).toBe(true)
|
|
const quickCommandSpec = 'tests/e2e/terminal-quick-command-pre-bind-recovery.spec.ts'
|
|
for (const source of [
|
|
'src/renderer/src/components/terminal-pane/pty-connection.ts',
|
|
'src/renderer/src/components/terminal-pane/pty-connection/connect-pane-pty.ts',
|
|
'src/renderer/src/components/terminal-pane/pty-connection/fresh-spawn-start.ts',
|
|
'src/renderer/src/components/terminal-pane/pty-connection/pane-pty-visibility-bind.ts',
|
|
'src/renderer/src/components/terminal-pane/pty-connection/pty-input-recovery.ts'
|
|
]) {
|
|
expect(selectPrE2eSpecs([source]), source).toContain(quickCommandSpec)
|
|
expect(selectPrE2eSpecs([source.replace(/\.ts$/, '.test.ts')]), source).not.toContain(
|
|
quickCommandSpec
|
|
)
|
|
}
|
|
for (const source of [
|
|
'src/main/ripgrep/bundled-ripgrep-path.ts',
|
|
'src/shared/bundled-ripgrep.ts',
|
|
'src/shared/ripgrep-process-availability.ts'
|
|
]) {
|
|
expect(selectPrE2eSpecs([source]), source).toEqual([
|
|
'tests/e2e/paired-quick-open-large-tree.spec.ts'
|
|
])
|
|
}
|
|
expect(
|
|
selectPrE2eSpecs([
|
|
'src/main/runtime/orca-runtime-files.ts',
|
|
'tests/e2e/paired-quick-open-large-tree.spec.ts'
|
|
])
|
|
).toEqual(['tests/e2e/paired-quick-open-large-tree.spec.ts'])
|
|
expect(selectPrE2eSpecs(['src/renderer/src/components/FileExplorer.tsx'])).toEqual([])
|
|
expect(
|
|
selectPrE2eSpecs([
|
|
'src/renderer/src/components/terminal-pane/remote-runtime-pty-transport.ts'
|
|
])
|
|
).toContain('tests/e2e/paired-remote-terminal-materialization-reconnect.spec.ts')
|
|
expect(
|
|
selectPrE2eSpecs([
|
|
'src/renderer/src/components/terminal-pane/remote-runtime-pty-transport-test-harness.ts'
|
|
])
|
|
).not.toContain('tests/e2e/paired-remote-terminal-materialization-reconnect.spec.ts')
|
|
expect(selectPrE2eSpecs(['src/main/ipc/pty.ts'])).not.toContain(
|
|
'tests/e2e/paired-remote-terminal-materialization-reconnect.spec.ts'
|
|
)
|
|
})
|
|
|
|
it('triggers the real-IME lane from every surface an input method can judge', () => {
|
|
for (const file of [
|
|
'src/renderer/src/components/terminal-pane/terminal-ime-composition-route.ts',
|
|
'src/renderer/src/components/terminal-pane/terminal-ime-native-text-forwarder.ts',
|
|
'src/renderer/src/components/terminal-pane/terminal-ios-hangul-preedit.ts',
|
|
'src/renderer/src/components/terminal-pane/xterm-bypass-policy.ts',
|
|
'src/renderer/src/lib/pane-manager/terminal-ime-anchor.ts',
|
|
'src/shared/terminal-unicode-provider.ts',
|
|
// The xterm fork owns the helper textarea the IME attaches to; no file here says "ime".
|
|
'config/patches/@xterm__xterm@6.1.0-beta.287.patch',
|
|
'config/patches/xterm-src/browser/Terminal.ts',
|
|
// The harness is source too: breaking the runner or a probe is how the lane goes blind.
|
|
'config/scripts/run-terminal-ibus-hangul-e2e.mjs',
|
|
'config/scripts/terminal-ime-engagement-receipt.mjs',
|
|
'tests/e2e/terminal-ime-boundary-probe.ts',
|
|
'tests/e2e/terminal-ime-byte-reader.ts',
|
|
'tests/e2e/terminal-ime-engagement-receipt.ts',
|
|
'tests/e2e/terminal-ibus-hangul-native.spec.ts'
|
|
]) {
|
|
expect(hasNativeImeSourceChange([file]), file).toBe(true)
|
|
}
|
|
|
|
// Why: a real ibus session on a Git or tab-bar edit is the cost the filter exists to avoid,
|
|
// and a unit test beside the source must not summon a three-and-a-half-minute lane.
|
|
for (const file of [
|
|
'src/main/git/git-status.ts',
|
|
'src/renderer/src/components/tab-bar/BrowserTab.tsx',
|
|
'src/main/terminal/pty-manager.ts',
|
|
'docs/STYLEGUIDE.md',
|
|
'src/renderer/src/components/terminal-pane/terminal-ime-composition-route.test.ts',
|
|
'src/renderer/src/lib/pane-manager/terminal-ime-anchor.test.ts'
|
|
]) {
|
|
expect(hasNativeImeSourceChange([file]), file).toBe(false)
|
|
}
|
|
})
|
|
|
|
it('keeps the native IME spec out of the lane that would silently skip it', () => {
|
|
expect(DEDICATED_E2E_SPECS).toContain('tests/e2e/terminal-ibus-hangul-native.spec.ts')
|
|
// Why it still has to be routed: the dedicated lane is selected by the same route, so the
|
|
// spec appearing in test_files is how a spec-only edit reaches the real-IME lane at all.
|
|
expect(selectPrE2eSpecs(['src/shared/terminal-unicode-provider.ts'])).toContain(
|
|
'tests/e2e/terminal-ibus-hangul-native.spec.ts'
|
|
)
|
|
})
|
|
})
|