Files
orca/src/main/git/worktree-sparse-checkout-cache.ts
T
Neil 62451920ed fix(git): preserve SSH review context and worktree ownership (#24945)
* fix(git): preserve SSH arguments and guard background writes

* test(terminal): settle fish fixture startup readiness

* fix(git): preserve bare UNC SSH paths

* fix(git): unescape shell operators in Windows SSH paths

* test(runtime): settle removal writes before fixture cleanup

* test(git): skip optional OpenSSH probe when unavailable

* perf(git): skip equal-tip reads and bound relay discovery

* test(processes): ratchet the removed relay Git spawn

* test(shells): wait for initial zsh output before sending input

* Fix SSH review context and recover Git maintenance cleanup safely

* Keep relay Git compatibility fixtures outside shared client projects

* Fence superseded maintenance and preserve mixed-version session search

* test: model Git child termination and search catalogs

* test: retain catalog authority over history flags
2026-10-03 05:24:35 -07:00

165 lines
7.4 KiB
TypeScript

import type { GitRuntimeOptions } from './git-runtime-options'
import { canonicalWorktreePath } from './worktree-path-comparison'
import { detectSparseCheckout } from './worktree-sparse-state'
// Worktree porcelain omits sparse state, so cache the per-worktree filesystem detection.
// Keys isolate repositories and distros; one global budget bounds retained results.
//
// Invalidation coverage:
// - Orca-driven remove/move: explicit calls below (worktree-removal.ts, worktree-move.ts).
// - External `git sparse-checkout` toggle while extensions.worktreeConfig is on: it rewrites
// `config.worktree`, which the git-common-dir watcher already classifies as structural and
// routes through notifyWorktreesChanged -> the invalidator this module registers (repo-scoped).
// - External toggle with extensions.worktreeConfig off, or a bare pattern-file edit: unwitnessed
// by the watcher (same blind spot `readRepoWorktreeAdminFingerprint` already documents and
// accepts). Past the reconcile window below, a read still returns instantly from the stale entry
// but also kicks a deduplicated background re-detect; a flip fires the change listener (wired to
// the existing worktrees-changed notification) so the visible staleness window collapses from the
// interval to one refresh cycle instead of blocking the listing that noticed it. That notification
// itself runs the invalidator registered below, so a flip is immediately followed by a full clear
// of the repo's cache (not just the one entry) -- an intentionally forced one-time full re-detect
// on the rare edge that actually flipped, rather than partial state that could quietly diverge.
// - App cold start: the map starts empty, so the first read is always a fresh detect.
const SPARSE_CHECKOUT_CACHE_RECONCILE_INTERVAL_MS = 5 * 60_000
export const MAX_SPARSE_CHECKOUT_CACHE_ENTRIES = 512
// Part of the cache key, not just a probe argument. A distro-less read of a WSL-hosted repo
// resolves the gitdir pointer against a fabricated Win32 path and reports "not sparse"; several
// callers (filesystem-auth root rebuild, worktree ownership checks) list a repo with no options at
// all and would otherwise publish that wrong answer onto the entry the distro-carrying listing
// reads. Keying on it also pins each entry's revalidation to the options that produced it, so the
// background probe can never re-derive a warm entry under weaker options and flip it. Every field
// here must be in the key; widening this type means widening `cacheKey`.
type SparseCheckoutProbeOptions = Pick<GitRuntimeOptions, 'wslDistro'>
type SparseCheckoutCacheEntry = {
isSparse: boolean
cachedAt: number
revalidating?: Promise<void>
}
export type SparseCheckoutChangeListener = (
repoPath: string,
worktreePath: string,
isSparse: boolean
) => void
const sparseCheckoutStateCache = new Map<string, SparseCheckoutCacheEntry>()
let changeListener: SparseCheckoutChangeListener | undefined
function retainSparseCheckoutCacheEntry(key: string, entry: SparseCheckoutCacheEntry): void {
sparseCheckoutStateCache.delete(key)
sparseCheckoutStateCache.set(key, entry)
while (sparseCheckoutStateCache.size > MAX_SPARSE_CHECKOUT_CACHE_ENTRIES) {
const oldest = sparseCheckoutStateCache.keys().next()
if (oldest.done || oldest.value === key) {
break
}
sparseCheckoutStateCache.delete(oldest.value)
}
}
// Distro last so the repo- and worktree-scoped prefix deletes below still match every variant.
function cacheKey(
repoPath: string,
worktreePath: string,
options: SparseCheckoutProbeOptions
): string {
return `${worktreeKeyPrefix(repoPath, worktreePath)}${options.wslDistro?.trim().toLowerCase() ?? ''}`
}
function worktreeKeyPrefix(repoPath: string, worktreePath: string): string {
return `${canonicalWorktreePath(repoPath)}\0${canonicalWorktreePath(worktreePath)}\0`
}
function deleteKeysWithPrefix(prefix: string): void {
for (const key of sparseCheckoutStateCache.keys()) {
if (key.startsWith(prefix)) {
sparseCheckoutStateCache.delete(key)
}
}
}
/** Wired by the ipc/ layer to the shared worktrees-changed notification; last registration wins. */
export function onSparseCheckoutStateChanged(
listener: SparseCheckoutChangeListener | undefined
): void {
changeListener = listener
}
/** Cached wrapper around {@link detectSparseCheckout}; see module doc for invalidation coverage. */
export async function detectSparseCheckoutCached(
repoPath: string,
worktreePath: string,
options: SparseCheckoutProbeOptions = {}
): Promise<boolean> {
const key = cacheKey(repoPath, worktreePath, options)
const cached = sparseCheckoutStateCache.get(key)
if (!cached) {
const isSparse = await detectSparseCheckout(worktreePath, options)
retainSparseCheckoutCacheEntry(key, { isSparse, cachedAt: Date.now() })
return isSparse
}
if (Date.now() - cached.cachedAt < SPARSE_CHECKOUT_CACHE_RECONCILE_INTERVAL_MS) {
retainSparseCheckoutCacheEntry(key, cached)
return cached.isSparse
}
// Stale-while-revalidate: serve the still-cached value now and correct it in the background,
// deduplicated so concurrent readers past the window don't each start their own probe. Whichever
// reader wins the dedupe re-probes with the entry's own distro, because that distro is what
// routed it to this key.
cached.revalidating ??= revalidateInBackground(key, repoPath, worktreePath, cached, options)
return cached.isSparse
}
async function revalidateInBackground(
key: string,
repoPath: string,
worktreePath: string,
startingEntry: SparseCheckoutCacheEntry,
options: SparseCheckoutProbeOptions
): Promise<void> {
try {
const isSparse = await detectSparseCheckout(worktreePath, options)
// Identity guard against a race with an explicit invalidate/clear -- or a remove+recreate at
// the same path that repopulates the key with a fresh cold read -- while this was in flight.
// A `has()`/presence check can't tell "still mine" from "someone else's fresh value" sharing
// the key; comparing the map's current entry object to the one we started from can.
if (sparseCheckoutStateCache.get(key) === startingEntry) {
retainSparseCheckoutCacheEntry(key, { isSparse, cachedAt: Date.now() })
}
if (isSparse !== startingEntry.isSparse) {
changeListener?.(repoPath, worktreePath, isSparse)
}
} catch {
// Leave whatever's there in place; the next read past the window retries.
if (sparseCheckoutStateCache.get(key) === startingEntry) {
startingEntry.revalidating = undefined
}
}
}
/** Drop one worktree's cached state; call when Orca itself removes or moves a worktree path. */
export function invalidateSparseCheckoutState(repoPath: string, worktreePath: string): void {
deleteKeysWithPrefix(worktreeKeyPrefix(repoPath, worktreePath))
}
/** Clear one repo's cached entries; wired to the shared worktree-change invalidator registry in ipc/. */
export function clearSparseCheckoutStateCacheForRepo(repoPath: string): void {
deleteKeysWithPrefix(`${canonicalWorktreePath(repoPath)}\0`)
}
/** Clear every cached entry; fallback for a change notification whose repo can't be resolved to a path. */
export function clearSparseCheckoutStateCache(): void {
sparseCheckoutStateCache.clear()
}
export function __resetSparseCheckoutStateCacheForTests(): void {
sparseCheckoutStateCache.clear()
changeListener = undefined
}
export function __getSparseCheckoutStateCacheSizeForTests(): number {
return sparseCheckoutStateCache.size
}