mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
* perf(hooks): register direct .cmd hooks for Gemini, DSH, Kiro, Droid and Command Code on Windows On a cmd-safe profile path these agents now register the managed .cmd path itself instead of a `powershell.exe -EncodedCommand` launcher, so each hook event no longer pays a second PowerShell start-up on top of the runner's own shell. Profiles the bare path cannot carry (spaces, non-ASCII, UNC) keep the encoded launcher. Same pattern as Claude (#18875) and Muse (#26755). Refs #20913 * refactor(hooks): one Windows batch-hook helper and one payload-delivery table - Add wrapWindowsBatchHookCommand (bare .cmd path, encoded launcher otherwise) and use it for Muse, Gemini, DSH, Kiro, Droid and Command Code. - Fold the five agents into windows-hook-payload-delivery.test.ts as rows run under each vendor's shell, from a plain and a spaced profile, with a stale encoded registration seeded per row; drop the separate runner suite and its CI list entries. - Replace the Windows-only per-agent registration tests with ones that stub process.platform, so they run on every CI OS. - Fix stale launcher, helper and DSH comments. Refs #20913 --------- Co-authored-by: Orca Worker <orca-worker@localhost>
235 lines
7.4 KiB
TypeScript
235 lines
7.4 KiB
TypeScript
import { homedir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import type { SFTPWrapper } from 'ssh2'
|
|
import type { AgentHookInstallState, AgentHookInstallStatus } from '../../shared/agent-hook-types'
|
|
import {
|
|
buildManagedCommandHook,
|
|
createManagedCommandMatcher,
|
|
getSharedManagedScriptPath,
|
|
readHooksJson,
|
|
removeManagedCommands,
|
|
wrapPosixHookCommand,
|
|
writeHooksJson,
|
|
writeManagedScript,
|
|
type HookDefinition
|
|
} from '../agent-hooks/installer-utils'
|
|
import { wrapWindowsBatchHookCommand } from '../agent-hooks/windows-direct-cmd-hook-command'
|
|
import { refreshManagedScriptIfPresent } from '../agent-hooks/managed-hook-script-refresh'
|
|
import {
|
|
readHooksJsonRemote,
|
|
writeHooksJsonRemote,
|
|
writeManagedScriptRemote
|
|
} from '../agent-hooks/installer-utils-remote'
|
|
import { buildCommandCodeManagedScript } from './command-code-managed-script'
|
|
|
|
const COMMAND_CODE_EVENTS = [
|
|
{
|
|
eventName: 'PreToolUse',
|
|
definition: { matcher: '.*', hooks: [{ type: 'command', command: '' }] }
|
|
},
|
|
{
|
|
eventName: 'PostToolUse',
|
|
definition: { matcher: '.*', hooks: [{ type: 'command', command: '' }] }
|
|
},
|
|
{ eventName: 'Stop', definition: { hooks: [{ type: 'command', command: '' }] } }
|
|
] as const
|
|
|
|
function getConfigPath(): string {
|
|
return join(homedir(), '.commandcode', 'settings.json')
|
|
}
|
|
|
|
function getManagedScriptFileName(): string {
|
|
return process.platform === 'win32' ? 'command-code-hook.cmd' : 'command-code-hook.sh'
|
|
}
|
|
|
|
function getManagedScriptPath(): string {
|
|
return getSharedManagedScriptPath(getManagedScriptFileName())
|
|
}
|
|
|
|
function getManagedCommand(scriptPath: string): string {
|
|
return process.platform === 'win32'
|
|
? wrapWindowsBatchHookCommand(scriptPath)
|
|
: wrapPosixHookCommand(scriptPath)
|
|
}
|
|
|
|
function buildInstalledConfig(
|
|
config: NonNullable<ReturnType<typeof readHooksJson>>,
|
|
command: string,
|
|
scriptFileName: string
|
|
): void {
|
|
const nextHooks = { ...config.hooks }
|
|
const isManagedCommand = createManagedCommandMatcher(scriptFileName)
|
|
const managedEvents = new Set<string>(COMMAND_CODE_EVENTS.map((event) => event.eventName))
|
|
|
|
// Why: Orca owns only command-code-hook.* entries. Sweep retired managed
|
|
// events while preserving user-authored Command Code hooks.
|
|
for (const [eventName, definitions] of Object.entries(nextHooks)) {
|
|
if (managedEvents.has(eventName) || !Array.isArray(definitions)) {
|
|
continue
|
|
}
|
|
const cleaned = removeManagedCommands(definitions, isManagedCommand)
|
|
if (cleaned.length === 0) {
|
|
delete nextHooks[eventName]
|
|
} else {
|
|
nextHooks[eventName] = cleaned
|
|
}
|
|
}
|
|
|
|
for (const event of COMMAND_CODE_EVENTS) {
|
|
const current = Array.isArray(nextHooks[event.eventName]) ? nextHooks[event.eventName] : []
|
|
const cleaned = removeManagedCommands(current, isManagedCommand)
|
|
const definition: HookDefinition = {
|
|
...event.definition,
|
|
hooks: [buildManagedCommandHook(command)]
|
|
}
|
|
nextHooks[event.eventName] = [...cleaned, definition]
|
|
}
|
|
|
|
config.hooks = nextHooks
|
|
}
|
|
|
|
export class CommandCodeHookService {
|
|
async refreshManagedScripts(): Promise<void> {
|
|
await refreshManagedScriptIfPresent(getManagedScriptPath(), buildCommandCodeManagedScript())
|
|
}
|
|
|
|
getStatus(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const scriptPath = getManagedScriptPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
const command = getManagedCommand(scriptPath)
|
|
const missing: string[] = []
|
|
let presentCount = 0
|
|
for (const event of COMMAND_CODE_EVENTS) {
|
|
const definitions = Array.isArray(config.hooks?.[event.eventName])
|
|
? config.hooks![event.eventName]!
|
|
: []
|
|
const hasCommand = definitions.some((definition) =>
|
|
(definition.hooks ?? []).some((hook) => hook.command === command)
|
|
)
|
|
if (hasCommand) {
|
|
presentCount += 1
|
|
} else {
|
|
missing.push(event.eventName)
|
|
}
|
|
}
|
|
|
|
const managedHooksPresent = presentCount > 0
|
|
let state: AgentHookInstallState
|
|
let detail: string | null
|
|
if (missing.length === 0) {
|
|
state = 'installed'
|
|
detail = null
|
|
} else if (presentCount === 0) {
|
|
state = 'not_installed'
|
|
detail = null
|
|
} else {
|
|
state = 'partial'
|
|
detail = `Managed hook missing for events: ${missing.join(', ')}`
|
|
}
|
|
return { agent: 'command-code', state, configPath, managedHooksPresent, detail }
|
|
}
|
|
|
|
install(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const scriptPath = getManagedScriptPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
buildInstalledConfig(config, getManagedCommand(scriptPath), getManagedScriptFileName())
|
|
writeManagedScript(scriptPath, buildCommandCodeManagedScript())
|
|
writeHooksJson(configPath, config)
|
|
return this.getStatus()
|
|
}
|
|
|
|
async installRemote(sftp: SFTPWrapper, remoteHome: string): Promise<AgentHookInstallStatus> {
|
|
const home = remoteHome.replace(/\/$/, '')
|
|
const remoteConfigPath = `${home}/.commandcode/settings.json`
|
|
const remoteScriptPath = `${home}/.orca/agent-hooks/command-code-hook.sh`
|
|
try {
|
|
const config = await readHooksJsonRemote(sftp, remoteConfigPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse remote Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
buildInstalledConfig(config, wrapPosixHookCommand(remoteScriptPath), 'command-code-hook.sh')
|
|
await writeManagedScriptRemote(sftp, remoteScriptPath, buildCommandCodeManagedScript('posix'))
|
|
await writeHooksJsonRemote(sftp, remoteConfigPath, config)
|
|
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'installed',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: true,
|
|
detail: null
|
|
}
|
|
} catch (err) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: false,
|
|
detail: err instanceof Error ? err.message : String(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
remove(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
const nextHooks = { ...config.hooks }
|
|
const isManagedCommand = createManagedCommandMatcher(getManagedScriptFileName())
|
|
for (const [eventName, definitions] of Object.entries(nextHooks)) {
|
|
if (!Array.isArray(definitions)) {
|
|
continue
|
|
}
|
|
const cleaned = removeManagedCommands(definitions, isManagedCommand)
|
|
if (cleaned.length === 0) {
|
|
delete nextHooks[eventName]
|
|
} else {
|
|
nextHooks[eventName] = cleaned
|
|
}
|
|
}
|
|
|
|
config.hooks = nextHooks
|
|
writeHooksJson(configPath, config)
|
|
return this.getStatus()
|
|
}
|
|
}
|
|
|
|
export const commandCodeHookService = new CommandCodeHookService()
|