mirror of
https://github.com/stablyai/orca.git
synced 2026-09-21 16:02:20 +00:00
Neil
991a3fe963
Enable eleven oxlint rules that simplify code without changing behavior, and fix
every existing violation. Each candidate was gated on measured cost rather than
assumption, so rules that regressed runtime performance or type checking were
dropped instead of suppressed.
typescript/no-redundant-type-constituents is the largest addition: 113 sites, no
autofix. Dead constituents are deleted. Where the redundant literal existed to
document intent (`string | 'all'`), it is preserved as `(string & {})`, which
keeps the autocomplete hint the original code was reaching for instead of
flattening it away. The rule also caught a broken import —
remote-shared-control-retirement-probe.ts pulled RuntimeStatus from
src/shared/types, which does not export it, so the type silently degraded to
`any`; no tsconfig covers that file, so tsc never saw it.
oxlint stays at 1.77.0 rather than 1.78.0 because .npmrc sets
minimum-release-age=4320 and 1.78.0 is younger than that window.
Rules evaluated and rejected, with what disqualified each:
- prefer-string-raw: String.raw is a runtime call, not a literal (184x slower)
- prefer-string-replace-all: 26% slower
- text-encoding-identifier-case: ~5% slower, reproducible
- prefer-spread: [...str] is 110% slower than split('') and differs on surrogates
- no-implicit-coercion: `!!x` narrows types and `Boolean(x)` does not (22 tsc errors)
- prefer-arrow-callback: arrows are not constructible, breaking `new` on mocks
- object-shorthand: rewrites source text asserted by a tracked reliability gate
- switch-case-braces: pushes ten files past max-lines, which cannot be suppressed
- no-useless-switch-case: drops `case undefined:` that switch-exhaustiveness-check needs
- arrow-body-style: 115 violations have no fix, and it breaks max-lines
- newline-after-import: false-positives on the leading-semicolon ASI idiom
electron-vite-output-contract asserted on the literal
Object.prototype.hasOwnProperty.call text; retarget it to Object.hasOwn, which
rejects inherited keys identically.
77 lines
3.2 KiB
JavaScript
77 lines
3.2 KiB
JavaScript
import { readFileSync } from 'node:fs'
|
|
import { join, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
const projectDir = resolve(import.meta.dirname, '../..')
|
|
|
|
function source(path) {
|
|
return readFileSync(join(projectDir, path), 'utf8')
|
|
}
|
|
|
|
function sourceBetween(contents, startMarker, endMarker) {
|
|
const start = contents.indexOf(startMarker)
|
|
const end = contents.indexOf(endMarker, start + startMarker.length)
|
|
if (start === -1 || end === -1) {
|
|
throw new Error(`Missing source boundary: ${startMarker} → ${endMarker}`)
|
|
}
|
|
return contents.slice(start, end)
|
|
}
|
|
|
|
describe('computer-use modifier safety', () => {
|
|
it('uses mouse-event flags instead of held modifier keys on macOS', () => {
|
|
const macOS = source('native/computer-use-macos/Sources/OrcaComputerUseMacOS/main.swift')
|
|
const clickInput = sourceBetween(macOS, 'static func click(', 'static func scroll(')
|
|
const mouseInput = sourceBetween(
|
|
macOS,
|
|
'private static func mouse(',
|
|
'private static func keyEvent('
|
|
)
|
|
|
|
expect(mouseInput).toContain('event.flags = flags')
|
|
// Every click event flows through the shared delivery plan and carries
|
|
// the modifier flags on the mouse event itself.
|
|
expect(clickInput).toContain('SyntheticMouseClickDelivery.deliver(')
|
|
expect(clickInput).toContain('currentSyntheticClickRecipient(')
|
|
expect(clickInput).toContain('event.flags = flags')
|
|
expect(clickInput).not.toContain('down: true')
|
|
})
|
|
|
|
it('submits each modified Windows click in a closed, timed SendInput batch', () => {
|
|
const windows = source('native/computer-use-windows/runtime.ps1')
|
|
const modifiedClick = sourceBetween(
|
|
windows,
|
|
'public static void SendModifiedClick',
|
|
'private static INPUT KeyboardInput'
|
|
)
|
|
const mouseClick = sourceBetween(
|
|
windows,
|
|
'function Send-OrcaMouseClick',
|
|
'function Send-OrcaDrag'
|
|
)
|
|
|
|
expect(modifiedClick).toContain('SendInput((uint)values.Length, values')
|
|
expect(modifiedClick).toContain('SendInput((uint)releaseValues.Length, releaseValues')
|
|
expect(modifiedClick).toContain('if (sent != (uint)values.Length)')
|
|
expect(modifiedClick).toContain('releases.Add(MouseInput(mouseInput, mouseUp))')
|
|
expect(modifiedClick).not.toContain('int count')
|
|
expect(mouseClick).toMatch(
|
|
/for \(\$i = 0; \$i -lt \$clickCount; \$i\+\+\) \{\s+\[OrcaDesktopWin32\]::SendModifiedClick\(/
|
|
)
|
|
expect(mouseClick).toContain('if ($i + 1 -lt $clickCount) { Start-Sleep -Milliseconds 35 }')
|
|
expect(windows).not.toContain('keybd_event')
|
|
})
|
|
|
|
it('keeps Linux modifier release in the xdotool sequence and a fallback', () => {
|
|
const linux = source('native/computer-use-linux/runtime.py')
|
|
const modifiedClick = sourceBetween(linux, 'def modified_click_at(', 'def scroll_at(')
|
|
|
|
expect(modifiedClick).toContain('command.extend(["keyup", modifier])')
|
|
expect(modifiedClick).toContain('is_wayland')
|
|
expect(modifiedClick).toContain('modified clicks require xdotool on an X11 session')
|
|
expect(modifiedClick).toContain('finally:')
|
|
expect(modifiedClick).toContain('check=False')
|
|
expect(modifiedClick).toContain('timeout=5')
|
|
expect(modifiedClick).toContain('timeout=2')
|
|
})
|
|
})
|