Neil
5447a26fd1
* perf(lint): keep JS plugins out of default oxlint and adopt ast-grep Any jsPlugin makes Oxlint hand every file's AST to Node, so the seven custom plugins cost the default `oxlint` run several times its native time. - Move app-store-performance, quadratic-buffer-concat, renderer-scrollbar-style and ime-enter-guard (scope- or dataflow-aware) to config/oxlint-js-plugins.json, run by `pnpm lint:js-plugins`, CI, lint-staged and the changed-lines gate. - Port sort-comparator-performance, mobile-pairing and native-chat-design-tokens to ast-grep rules with rule tests, and delete the plugins. - Add @ast-grep/cli, config/sgconfig.yml, `pnpm lint:ast-grep` / `test:ast-grep`, a CI step, and an ast-grep pass in check-changed-code-quality. - Add flaky-test rules (wall-clock reads, real-time waits, polling loops, unquarantined skips, unexplained timeout bumps), baselined by a count ratchet. * Enforce flaky-test ratchet on changed files; refresh baseline * docs(agents): keep custom-rule details out of AGENTS.md * Resolve ast-grep from the repo so gate scans of other roots work
2.6 KiB
Performance regression checks
pnpm --silent audit:perf > performance-audit.json scans production src/ with
the existing app-store and buffer-concatenation rules. Warnings are advisory in this full inventory; tool/parser failures fail.
New warning findings on changed lines fail pnpm check:code-quality:changed.
Tests, generated files, mobile/ and cloud/ are outside this source audit.
The ast-grep rule config/ast-grep/rules/no-repeated-collator.yml (pnpm lint:ast-grep,
an error everywhere) detects optioned localeCompare and Intl.Collator construction
inside inline sort/toSorted callbacks. Construct one collator outside the
callback, preserving locale, options and tie-breakers. If the locale changes at
runtime, reconstruct at the next sort or key the cache by locale. Bare comparisons
and standalone equality checks are allowed. There is no autofix or interprocedural
analysis: named comparators, aliases, custom methods and deferred callbacks need
manual review. A finding identifies repeated setup, not proof of visible lag.
pnpm test:perf:contracts runs the explicit selection in
vitest.performance.config.ts: SQLite statement reuse and schema parity, relay
filesystem concurrency, incremental Codex scans and reader lifetimes, pinned JSONL
readers and snapshots, linear tool-result pairing and attribution allocation,
tokenizer rejection, highlighting cache, queued cancellation, terminal backing-memory
retention and detector fixtures. Missing
listed files fail configuration loading. Tests run serially, without retries,
and inherit the full suite's setup and forced-GC support. This makes existing
regression coverage easy to run and attribute; it does not create new workload
coverage by itself.
Incremental Claude scans and persisted Claude cache checkpoints are also included.
.github/workflows/performance-contracts.yml runs daily and manually on Linux,
macOS and Windows, and on PRs changing this tooling or any listed contract file.
It uploads per-OS JSON test results, plus the source inventory once from Linux
because that scan is OS-independent. Its schedule starts after merge. Run the existing
test:e2e:terminal-perf:scale:report for rendered typing/frame budgets. Unit tests do not
measure SSH RTT, WSL scheduling or a packaged Electron renderer.
To extend coverage, select a production-path regression with an operation-count, identity, queue-admission or retained-memory oracle. Confirm it fails with the old behavior. Use controlled, counterbalanced benchmark samples for timings; avoid new machine-dependent millisecond gates in the normal unit suite. A green source scan and these contracts cannot establish that the whole app is fast.