mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 16:47:34 +00:00
OrcaWinandOrcaWin
8f6283b32b
* test: replace redundant checks with observed behavior * docs: reconcile completed audit batches and upstream review --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
92 lines
3.5 KiB
JavaScript
92 lines
3.5 KiB
JavaScript
import { describe, expect, it, vi } from 'vitest'
|
|
import {
|
|
readPublishedVersionsFromEnv,
|
|
resolveDevChannelBaseVersion
|
|
} from './dev-channel-base-version.mjs'
|
|
|
|
describe('dev channel base version', () => {
|
|
it('falls back to package.json when no tags are supplied', () => {
|
|
expect(resolveDevChannelBaseVersion('1.4.168-rc.1')).toBe('1.4.168')
|
|
expect(resolveDevChannelBaseVersion('1.4.168', [])).toBe('1.4.168')
|
|
})
|
|
|
|
// The bug this exists for: main sat at 1.4.165-rc.0 for twenty hours while three
|
|
// stables shipped, so hourlies claimed a version their users had already passed.
|
|
it('climbs past stables that shipped while main stood still', () => {
|
|
expect(
|
|
resolveDevChannelBaseVersion('1.4.165-rc.0', [
|
|
'v1.4.165',
|
|
'v1.4.166',
|
|
'v1.4.167',
|
|
'v1.4.165-rc.0'
|
|
])
|
|
).toBe('1.4.168')
|
|
})
|
|
|
|
// Why +1 on a stable but not on a prerelease: 1.4.167 is spent, so the next dev
|
|
// build is 1.4.168. But 1.4.168-rc.1 means 1.4.168 is still being built toward,
|
|
// which is what main holds — claiming 1.4.169 would jump a release nobody cut.
|
|
it('takes the patch above a shipped stable and holds at an open prerelease', () => {
|
|
expect(resolveDevChannelBaseVersion('1.4.167', ['v1.4.167'])).toBe('1.4.168')
|
|
expect(resolveDevChannelBaseVersion('1.4.168-rc.1', ['v1.4.168-rc.1'])).toBe('1.4.168')
|
|
})
|
|
|
|
// Why max and not most-recent: a hotfix on an old line published today would
|
|
// otherwise drag every subsequent hourly backwards.
|
|
it('reads the highest tag, not the last one listed', () => {
|
|
expect(resolveDevChannelBaseVersion('1.4.160', ['v1.4.167', 'v1.3.99', 'v1.4.120'])).toBe(
|
|
'1.4.168'
|
|
)
|
|
})
|
|
|
|
// 2026-09-14: v1.4.202's GitHub release was deleted for a bug after hourlies
|
|
// had already shipped as 1.4.203. Without the channel tags as a floor, the
|
|
// next hourlies would have been 1.4.202-hourly, which electron-updater will
|
|
// not install over 1.4.203-hourly.
|
|
it('does not drop below an already-published channel version', () => {
|
|
expect(
|
|
resolveDevChannelBaseVersion('1.4.197', [
|
|
'v1.4.201',
|
|
'v1.4.202-hourly.202609141912',
|
|
'v1.4.203-hourly.202609140417'
|
|
])
|
|
).toBe('1.4.203')
|
|
})
|
|
|
|
it('treats package.json as a floor when it leads the tags', () => {
|
|
expect(resolveDevChannelBaseVersion('1.5.0-rc.0', ['v1.4.167'])).toBe('1.5.0')
|
|
})
|
|
|
|
// Why skipped rather than fatal: the main repo carries legacy tags, and one
|
|
// unparseable entry must not fail every hourly build.
|
|
it('ignores tags it cannot parse', () => {
|
|
expect(resolveDevChannelBaseVersion('1.4.160', ['nightly', '', 'v1.4.167', 'latest'])).toBe(
|
|
'1.4.168'
|
|
)
|
|
})
|
|
|
|
it('rejects a package version that is not semver', () => {
|
|
expect(() => resolveDevChannelBaseVersion('not-a-version')).toThrow(/not valid semver/)
|
|
})
|
|
|
|
it('carries major and minor rollovers through the bump', () => {
|
|
expect(resolveDevChannelBaseVersion('1.4.0', ['v2.0.0'])).toBe('2.0.1')
|
|
})
|
|
|
|
it('reads whitespace-separated tags from explicit input or the environment', () => {
|
|
expect(readPublishedVersionsFromEnv(' \tv1.4.167\r\nv1.4.166\n')).toEqual([
|
|
'v1.4.167',
|
|
'v1.4.166'
|
|
])
|
|
expect(readPublishedVersionsFromEnv('')).toEqual([])
|
|
try {
|
|
vi.stubEnv('ORCA_PUBLISHED_VERSIONS', 'v1.4.170\tv1.4.169')
|
|
expect(readPublishedVersionsFromEnv()).toEqual(['v1.4.170', 'v1.4.169'])
|
|
vi.stubEnv('ORCA_PUBLISHED_VERSIONS', undefined)
|
|
expect(readPublishedVersionsFromEnv()).toEqual([])
|
|
} finally {
|
|
vi.unstubAllEnvs()
|
|
}
|
|
})
|
|
})
|