mirror of
https://github.com/stablyai/orca.git
synced 2026-10-18 00:03:20 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
92 lines
2.3 KiB
TypeScript
92 lines
2.3 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import {
|
|
parseDevinHooksConfigText,
|
|
readConfigFromOrcaOverlapDetail,
|
|
readDevinHooksConfig
|
|
} from './hook-config-json'
|
|
|
|
describe('readDevinHooksConfig', () => {
|
|
let dir: string
|
|
|
|
beforeEach(() => {
|
|
dir = mkdtempSync(join(tmpdir(), 'orca-devin-jsonc-'))
|
|
})
|
|
|
|
afterEach(() => {
|
|
rmSync(dir, { recursive: true, force: true })
|
|
})
|
|
|
|
it('parses JSONC comments in Devin config', () => {
|
|
const path = join(dir, 'config.json')
|
|
writeFileSync(
|
|
path,
|
|
`{
|
|
// Devin user hooks
|
|
"hooks": {},
|
|
"permissions": { "mode": "normal" }
|
|
}
|
|
`
|
|
)
|
|
|
|
const config = readDevinHooksConfig(path)
|
|
|
|
expect(config).toEqual({
|
|
hooks: {},
|
|
permissions: { mode: 'normal' }
|
|
})
|
|
})
|
|
|
|
it('rejects recovered partial parses from malformed JSONC', () => {
|
|
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
|
|
try {
|
|
expect(parseDevinHooksConfigText('{"hooks": }', 'Devin config.json')).toBeNull()
|
|
expect(warn).toHaveBeenCalledWith(
|
|
expect.stringContaining('Could not parse Devin config.json')
|
|
)
|
|
} finally {
|
|
warn.mockRestore()
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('readConfigFromOrcaOverlapDetail', () => {
|
|
it('warns when legacy read_config_from imports Claude', () => {
|
|
const detail = readConfigFromOrcaOverlapDetail({
|
|
hooks: {},
|
|
read_config_from: ['claude', 'custom']
|
|
})
|
|
|
|
expect(detail).toContain('read_config_from')
|
|
expect(detail).toContain('claude')
|
|
})
|
|
|
|
it('warns when object-shaped read_config_from leaves Claude enabled', () => {
|
|
const detail = readConfigFromOrcaOverlapDetail({
|
|
hooks: {},
|
|
read_config_from: { claude: true }
|
|
})
|
|
|
|
expect(detail).toContain('read_config_from.claude')
|
|
})
|
|
|
|
it('warns when read_config_from is omitted because imports default to enabled', () => {
|
|
const detail = readConfigFromOrcaOverlapDetail({
|
|
hooks: {}
|
|
})
|
|
|
|
expect(detail).toContain('read_config_from.claude')
|
|
})
|
|
|
|
it('does not warn when read_config_from disables Claude', () => {
|
|
const detail = readConfigFromOrcaOverlapDetail({
|
|
hooks: {},
|
|
read_config_from: { claude: false }
|
|
})
|
|
|
|
expect(detail).toBeNull()
|
|
})
|
|
})
|