mirror of
https://github.com/stablyai/orca.git
synced 2026-11-03 10:37:35 +00:00
OrcaWinandm4air
3359fd2bfc
* refactor(ipc): worktree handlers are local or runtime only * refactor(runtime): explain the route witness on removal listing * test(runtime): pin the SSH create refusal and drop the deleted branch's reliability gap * test(runtime): drop a needless cast in the SSH create refusal test --------- Co-authored-by: m4air <m4air@Mac.localdomain>
79 lines
3.3 KiB
TypeScript
79 lines
3.3 KiB
TypeScript
// createManagedWorktree used to pick remote-vs-local from the raw `connectionId` field, so a repo
|
|
// stamped only `executionHostId: 'ssh:*'` ran `git worktree add` on the client against a remote
|
|
// path. That is the #11163 shape: read the execution host, never one spelling of it.
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
vi.mock('electron', () => ({
|
|
BrowserWindow: { fromId: vi.fn(() => null) },
|
|
webContents: { fromId: vi.fn(() => null) },
|
|
ipcMain: { on: vi.fn(), removeListener: vi.fn() },
|
|
app: { getPath: vi.fn(() => '/tmp'), isPackaged: false }
|
|
}))
|
|
|
|
const createRuntimeFolderWorktreeMock = vi.hoisted(() => vi.fn())
|
|
vi.mock('./runtime-folder-worktree-create', () => ({
|
|
createRuntimeFolderWorktree: createRuntimeFolderWorktreeMock
|
|
}))
|
|
|
|
const createRuntimeLocalManagedWorktreeMock = vi.hoisted(() => vi.fn())
|
|
vi.mock('./runtime-local-worktree-create', () => ({
|
|
createRuntimeLocalManagedWorktree: createRuntimeLocalManagedWorktreeMock
|
|
}))
|
|
|
|
import { OrcaRuntimeService } from './orca-runtime'
|
|
import { SshHostNotServedError } from '../providers/ssh-host-not-served-error'
|
|
|
|
const TARGET_ID = 'remote-1'
|
|
const REMOTE_PATH = '/srv/app'
|
|
|
|
type RuntimeInternals = {
|
|
resolveRepoSelector: (selector: string) => Promise<unknown>
|
|
resolveLineageForWorktreeCreate: (input: unknown) => Promise<unknown>
|
|
recordCreatedWorktreeLineage: (worktree: unknown, resolution: unknown) => unknown
|
|
}
|
|
|
|
function makeRuntime(repo: Record<string, unknown>): OrcaRuntimeService {
|
|
const store = {
|
|
getSettings: () => ({ disabledTuiAgents: [], workspaceDir: '/tmp/workspaces' }),
|
|
getProjectHostSetups: () => []
|
|
}
|
|
const runtime = new OrcaRuntimeService(store as never)
|
|
const internals = runtime as unknown as RuntimeInternals
|
|
vi.spyOn(internals, 'resolveRepoSelector').mockResolvedValue(repo)
|
|
vi.spyOn(internals, 'resolveLineageForWorktreeCreate').mockResolvedValue(null)
|
|
vi.spyOn(internals, 'recordCreatedWorktreeLineage').mockReturnValue({
|
|
lineage: null,
|
|
workspaceLineage: null,
|
|
warnings: []
|
|
})
|
|
return runtime
|
|
}
|
|
|
|
describe('createManagedWorktree execution-host routing', () => {
|
|
beforeEach(() => {
|
|
createRuntimeFolderWorktreeMock.mockReset()
|
|
createRuntimeFolderWorktreeMock.mockResolvedValue({ worktree: { id: 'folder-1' } })
|
|
createRuntimeLocalManagedWorktreeMock.mockReset()
|
|
// Name the defect in the failure output: reaching this mock means a remote repo was routed
|
|
// into a client-side `git worktree add`.
|
|
createRuntimeLocalManagedWorktreeMock.mockRejectedValue(
|
|
new Error('local_worktree_create_ran_for_remote_repo')
|
|
)
|
|
})
|
|
|
|
// The SSH host is not served here: the create refuses rather than running `git worktree add`.
|
|
it.each([
|
|
['a repo stamped executionHostId only', { executionHostId: `ssh:${TARGET_ID}` }],
|
|
['a legacy connectionId-only repo', { connectionId: TARGET_ID }]
|
|
])('refuses %s instead of creating locally', async (_name, host) => {
|
|
const runtime = makeRuntime({ id: 'repo-remote', path: REMOTE_PATH, kind: 'git', ...host })
|
|
|
|
await expect(
|
|
runtime.createManagedWorktree({ repoSelector: 'repo-remote', name: 'feature' })
|
|
).rejects.toThrow(SshHostNotServedError)
|
|
|
|
// A local `git worktree add` against a remote path is the silent-substitution failure.
|
|
expect(createRuntimeLocalManagedWorktreeMock).not.toHaveBeenCalled()
|
|
})
|
|
})
|